Your message dated Wed, 26 Jul 2006 03:32:20 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#250955: fixed in xmms 1:1.2.10+20060726-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: xmms
Version: 1.2.10-1
Severity: minor
Tags: patch
The current software volume control in the ALSA plugin follows a linear
curve. Because of this, it is unconvenient to choose a low volume
accurately, and the feeling when using the slider is rather unnatural.
For a better feeling, it should follow an exponential curve. The
attached patch implements such a curve.
Regards,
Nicolas
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (900, 'testing'), (800, 'unstable'), (700, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.6-nestor
Locale: LANG=C, LC_CTYPE=fr_FR.UTF-8
Versions of packages xmms depends on:
ii libc6 2.3.2.ds1-12 GNU C Library: Shared libraries an
ii libglib1.2 1.2.10-9 The GLib library of C routines
ii libgtk1.2 1.2.10-16 The GIMP Toolkit set of widgets fo
ii libice6 4.3.0.dfsg.1-1 Inter-Client Exchange library
ii libsm6 4.3.0.dfsg.1-1 X Window System Session Management
ii libx11-6 4.3.0.dfsg.1-1 X Window System protocol client li
ii libxext6 4.3.0.dfsg.1-1 X Window System miscellaneous exte
ii libxi6 4.3.0.dfsg.1-1 X Window System Input extension li
ii xlibs 4.3.0.dfsg.1-1 X Window System client libraries m
-- no debconf information
diff -ru xmms-1.2.10.orig/Output/alsa/audio.c xmms-1.2.10/Output/alsa/audio.c
--- xmms-1.2.10.orig/Output/alsa/audio.c 2004-01-28 00:09:39.000000000
+0100
+++ xmms-1.2.10/Output/alsa/audio.c 2004-05-26 01:13:42.000000000 +0200
@@ -22,6 +22,7 @@
#include "alsa.h"
#include <ctype.h>
#include <libxmms/xconvert.h>
+#include <math.h>
static snd_pcm_t *alsa_pcm = NULL;
static snd_pcm_status_t *alsa_status = NULL;
@@ -488,10 +489,10 @@
for (i = 0; i < length; i += 4)
\
{
\
*ptr = type2##_TO_##endian(type2##_FROM_## endian(*ptr) *
\
- alsa_cfg.vol.left / 100);
\
+ lvol / 256);
\
ptr++;
\
*ptr = type2##_TO_##endian(type2##_FROM_##endian(*ptr) *
\
- alsa_cfg.vol.right / 100);
\
+ rvol / 256);
\
ptr++;
\
}
\
} while (0)
@@ -502,7 +503,7 @@
for (i = 0; i < length; i += 4)
\
{
\
*ptr = type2##_TO_##endian(type2##_FROM_## endian(*ptr) *
\
- vol / 100);
\
+ vol / 256);
\
ptr++;
\
}
\
} while (0)
@@ -520,9 +521,9 @@
type *ptr = data; \
for (i = 0; i < length; i += 2) \
{ \
- *ptr = *ptr * alsa_cfg.vol.left / 100; \
+ *ptr = *ptr * lvol / 256; \
ptr++; \
- *ptr = *ptr * alsa_cfg.vol.right / 100; \
+ *ptr = *ptr * rvol / 256; \
ptr++; \
} \
} while (0)
@@ -532,7 +533,7 @@
type *ptr = data; \
for (i = 0; i < length; i += 4) \
{ \
- *ptr = *ptr * vol / 100; \
+ *ptr = *ptr * vol / 256; \
ptr++; \
} \
} while (0)
@@ -548,14 +549,16 @@
static void volume_adjust(void* data, int length, AFormat fmt, int channels)
{
- int i, vol;
+ int i, vol, lvol, rvol;
if ((alsa_cfg.vol.left == 100 && alsa_cfg.vol.right == 100) ||
(channels == 1 &&
(alsa_cfg.vol.left == 100 || alsa_cfg.vol.right == 100)))
return;
- vol = MAX(alsa_cfg.vol.left, alsa_cfg.vol.right);
+ lvol = (int)(pow(10,(alsa_cfg.vol.left-100)/40.0)*256);
+ rvol = (int)(pow(10,(alsa_cfg.vol.right-100)/40.0)*256);
+ vol = MAX(lvol,rvol);
switch (fmt)
{
--- End Message ---
--- Begin Message ---
Source: xmms
Source-Version: 1:1.2.10+20060726-1
We believe that the bug you reported is fixed in the latest version of
xmms, which is due to be installed in the Debian FTP archive:
xmms-dev_1.2.10+20060726-1_i386.deb
to pool/main/x/xmms/xmms-dev_1.2.10+20060726-1_i386.deb
xmms_1.2.10+20060726-1.diff.gz
to pool/main/x/xmms/xmms_1.2.10+20060726-1.diff.gz
xmms_1.2.10+20060726-1.dsc
to pool/main/x/xmms/xmms_1.2.10+20060726-1.dsc
xmms_1.2.10+20060726-1_i386.deb
to pool/main/x/xmms/xmms_1.2.10+20060726-1_i386.deb
xmms_1.2.10+20060726.orig.tar.gz
to pool/main/x/xmms/xmms_1.2.10+20060726.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Baumann <[EMAIL PROTECTED]> (supplier of updated xmms package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 25 Jul 2006 14:18:00 +0200
Source: xmms
Binary: xmms-dev xmms
Architecture: source i386
Version: 1:1.2.10+20060726-1
Distribution: unstable
Urgency: low
Maintainer: Daniel Baumann <[EMAIL PROTECTED]>
Changed-By: Daniel Baumann <[EMAIL PROTECTED]>
Description:
xmms - Versatile X audio player
xmms-dev - XMMS development static library and header files
Closes: 250955 347179 361485 379094 379751 379761
Changes:
xmms (1:1.2.10+20060726-1) unstable; urgency=low
.
* New upstream snapshot:
- fixes problems with volume control with ALSA plugin (Closes: #250955).
- fixes problems with variable bitrate mp3 (Closes: #379751, #379761).
* Added Filipino translation (Closes: #347179).
* Bootstrapping with current libtool (Closes: #379094).
* Updated build-depends for kfreebsd-amd64 (Closes: #361485).
Files:
f56dec0ba498fad5dc7e42be50079629 996 sound optional xmms_1.2.10+20060726-1.dsc
027e438db75d1802592be5b0e0e51a45 3516814 sound optional
xmms_1.2.10+20060726.orig.tar.gz
359cb95dae57d9332b1661ca683eff5a 114488 sound optional
xmms_1.2.10+20060726-1.diff.gz
49c9f32654caacd6b9e8ba5783a7b081 2471058 sound optional
xmms_1.2.10+20060726-1_i386.deb
8887946766dca09206fbc0f6541a92d3 118244 devel optional
xmms-dev_1.2.10+20060726-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
iD8DBQFEx0Gf+C5cwEsrK54RAjnoAJwIJ+Xhfexvr+sAayfKtpclUi/9vQCeLxH7
dS2GcGDydavdLWtjbwrM4a0=
=Cb5y
-----END PGP SIGNATURE-----
--- End Message ---
