Your message dated Thu, 2 Jan 2025 22:16:34 +0100 with message-id <[email protected]> and subject line git-daemon-run package removed has caused the Debian Bug report #618606, regarding git-daemon-run: confusing message on upgrade if service was removed (fail: git-daemon: runsv not running) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 618606: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=618606 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: git-daemon-run Version: 1:1.7.4.1-4 Severity: minor Just stumbled on some confusing output: # update-service --remove /etc/sv/git-daemon Service git-daemon removed, the service daemon received the TERM and CONT signals. # dpkg-reconfigure git-daemon-run Service git-daemon added. fail: git-daemon: runsv not running # sv stat /etc/sv/git-daemon run: /etc/sv/git-daemon: (pid 9732) 7s; run: log: (pid 9731) 7s The same happens on upgrade if the admin has removed /etc/sv/git-daemon. * What are the correct semantics? Is postinst right to add back the service after the admin removed it? (Yes, I think so.) * Would it make sense to notice this case and give a hint to the user? For example, # git-daemon service disabled? if test -n "$2" && ! update-service --check /etc/sv/git-daemon then echo >&2 'git-daemon-run/upgrade: re-enabling git-daemon service' fi # enable git-daemon service update-service --add /etc/sv/git-daemon * Is the output from "sv -v term git-daemon" ('fail: git-daemon: runsv not running') useful to the user? We are ignoring the exit status; it could make sense to send output from sv -v term to /dev/null, too. But if failures are expected, I wonder why postinst uses -v in the first place. Hmm. I'm not too comfortable with this story yet.
--- End Message ---
--- Begin Message ---Source: git Source-Version: 1:2.47.1-1 The latest version of git in sid does not include runit configuration any more, meaning this bug no longer applies. I enjoyed using it, but it isn't responsible from a security perspective to keep it as a recommended configuration. Thanks for the helpful user input while it was included. Jonathan
--- End Message ---
