Your message dated Fri, 03 Jan 2025 01:00:00 +0000
with message-id <[email protected]>
and subject line Bug#1078134: fixed in lz4 1.9.4-4
has caused the Debian Bug report #1078134,
regarding lz4: new lz4Config.cmake file causes FTBFS due to bogus xxhash
dependency
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1078134: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078134
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: lz4
Version: 1.9.4-3
Severity: important
Tags: ftbfs
Control: affects -1 yuzu
Control: block 1077401 by -1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi, the newly introduced lz4Config.cmake file is currently causing yuzu (and
probably other packages as well) to failing to build from source, since the
file contains an INTERFACE (aka transitive) dependency on the "xxhash" library,
contained in libxxhash-dev. This is wrong, since xxhash is a hidden (i.e.
internal) dependency of liblz4, and users need not pass compiler or linker
directives mentioning xxhash when consuming liblz4. As you can see from the
files themselves:
$ dpkg --listfiles liblz4-dev | xargs grep -s xxhash
/usr/lib/x86_64-linux-gnu/cmake/lz4/lz4Targets.cmake:
INTERFACE_LINK_LIBRARIES "xxhash"
/usr/lib/x86_64-linux-gnu/cmake/lz4/lz4Targets.cmake:
INTERFACE_LINK_LIBRARIES "xxhash"
grep: /usr/lib/x86_64-linux-gnu/liblz4.so: binary file matches
xxhash isn't included in public headers, and the pkg-config file rightfully
doesn't mention xxhash at all. CMake is the only one wrong.
Given upstream's only supported build system are Makefiles, and the only
supported way of consuming the library as a dependency is via its pkg-config
file, you have two choices:
1. Go back to using the official Makefiles, and stop using the community
maintained CMake build scripts
2. Fix this issue upstream, and keep fixing CMake issues, adding maintenance
burden
Given using CMake instead of the officially supported build system has caused
issues to Arch Linux in the past[1] for the zstd package (which has the same
upstream developer and build system situation), I generally find it unwise to
use CMake at all for Debian. I know, people will keep asking for CMake config
files, but sometimes it's fine to just say no. In my opinion, this is a
decision that has to be taken upstream, not here; Debian should follow
upstream's recommendations.
If you have any question related to CMake or build systems in general, feel
free to ask!
Bye :)
[1]: https://www.phoronix.com/news/Arch-Linux-Bizarre-Zstd
- -- System Information:
Debian Release: trixie/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 6.9.12-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
iIoEARYIADIWIQS6VuNIvZRFHt7JcAdKkgiiRVB3pwUCZrNMwxQcYW5kcmVhQHBh
cHBhY29kYS5pdAAKCRBKkgiiRVB3p9KMAQC6tGUvQD30GejfqLARrGRuGBL4E0S8
KCy0FaiuG6TIEwD+PacPP0ElqhY9EdQ88VmkAvdX7al6Nb1jSljNldNC3Qg=
=ladj
-----END PGP SIGNATURE-----
--- End Message ---
--- Begin Message ---
Source: lz4
Source-Version: 1.9.4-4
Done: Nobuhiro Iwamatsu <[email protected]>
We believe that the bug you reported is fixed in the latest version of
lz4, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Nobuhiro Iwamatsu <[email protected]> (supplier of updated lz4 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 03 Jan 2025 09:20:45 +0900
Source: lz4
Architecture: source
Version: 1.9.4-4
Distribution: unstable
Urgency: medium
Maintainer: Nobuhiro Iwamatsu <[email protected]>
Changed-By: Nobuhiro Iwamatsu <[email protected]>
Closes: 1077401 1078134
Changes:
lz4 (1.9.4-4) unstable; urgency=medium
.
* Update d/patches/use-system-xxhash.patch.
- Add -lxxhash to liblz4.pc.in.
* d/control: Add libxxhash-dev to B-D of liblz4-dev.
(Closes: #1078134, #1077401)
Checksums-Sha1:
2b74eaef8a728b5880fbb8828c104651da2bdba5 1934 lz4_1.9.4-4.dsc
775042e04fcb3f1049ca0c5e08727589b39d6980 7372 lz4_1.9.4-4.debian.tar.xz
20e79271180fa87190fe6744b82d1d0a12ab7bb2 8376 lz4_1.9.4-4_amd64.buildinfo
Checksums-Sha256:
2ce2f46adeb4919bc12fc7e48b6271f7d9a685c004ec8ac8381adf77ed233581 1934
lz4_1.9.4-4.dsc
2310e5f1a4a7044722e8aebf927329dd9eb9615bf6fbe9800b590153d9d6b869 7372
lz4_1.9.4-4.debian.tar.xz
5c930b4ea4df7a4c030bf28e508169b4057e9c2b3b3527a020e30d78cc048557 8376
lz4_1.9.4-4_amd64.buildinfo
Files:
83b2b03e45abeefe20d71eb9f13cbbd9 1934 utils optional lz4_1.9.4-4.dsc
177ec1dddb64d7b1726a7c921cc62d5b 7372 utils optional lz4_1.9.4-4.debian.tar.xz
24851388b04ddced58626625bee21de1 8376 utils optional
lz4_1.9.4-4_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEXmKe5SMhlzV7hM9DMiR/u0CtH6YFAmd3L2sACgkQMiR/u0Ct
H6bzhw/+M2jZ0EKwmDK2uUk8RewnSBWKx+tp40LPkWy/TwKTQDfKbXYxQ14ejGlQ
aLIjUe4IoEINBsz3nqavBkvh83FG1jtEoyG13x5RIzRDwDPIIkfEqZwh6/QUSeOg
prLXaYeM+b8qnScteQk6zLj+t/sokoykEgA5ep9agqc+cfMWrYycm+eh6Ml6QURL
gkmMKnrog3OX8oFDrB2PwL0oSIqbqhdZBVCzb3vWLXVXujr8phPQ+ALqyv96AOw6
1fwpaMsNxtzfGHOvdGZgtupOYwexbNg+xCAAlo45tnDH8uE3B598WgC1nuHMN/RE
UpKAJWHjDZ74dH3tTx0cMG/59IhJI7w2RbRftWB9O7fSPqtvGEmmIv8CUO6f2M7p
aP65/QLpkaVl69tOp4jxPLNtIKT0dAcu2IhgGkTvmg9Zssex7IYO1bIMlUtqZimR
PKDoRbeFNG1ey+Uq8Ol9684IwMC8UyVRFg2uT72c8CtArKWWWE/VlmowiAnfK9N2
TycwcTGso5MlbtQrW0xXUwsHoPJ6AiQ0UrEPkb8YpVtKdT0gLgi8fES4s85UwILb
v9sC9PPKllvao3Pfi8evYXGy9+7fePD+hlAP/P5//nM/AiaqTl+iHPY7IlUJILQl
z0yh5j4k4lNAHIc5aNNCtncnkTnD7uSpP2iO49TFkjAyXNe2DGY=
=IRQK
-----END PGP SIGNATURE-----
pgpgkDGowjgbg.pgp
Description: PGP signature
--- End Message ---
