Your message dated Fri, 03 Jan 2025 01:00:08 +0000
with message-id <[email protected]>
and subject line Bug#1078134: fixed in lz4 1.10.0-2
has caused the Debian Bug report #1078134,
regarding lz4: new lz4Config.cmake file causes FTBFS due to bogus xxhash
dependency
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1078134: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078134
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: lz4
Version: 1.9.4-3
Severity: important
Tags: ftbfs
Control: affects -1 yuzu
Control: block 1077401 by -1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi, the newly introduced lz4Config.cmake file is currently causing yuzu (and
probably other packages as well) to failing to build from source, since the
file contains an INTERFACE (aka transitive) dependency on the "xxhash" library,
contained in libxxhash-dev. This is wrong, since xxhash is a hidden (i.e.
internal) dependency of liblz4, and users need not pass compiler or linker
directives mentioning xxhash when consuming liblz4. As you can see from the
files themselves:
$ dpkg --listfiles liblz4-dev | xargs grep -s xxhash
/usr/lib/x86_64-linux-gnu/cmake/lz4/lz4Targets.cmake:
INTERFACE_LINK_LIBRARIES "xxhash"
/usr/lib/x86_64-linux-gnu/cmake/lz4/lz4Targets.cmake:
INTERFACE_LINK_LIBRARIES "xxhash"
grep: /usr/lib/x86_64-linux-gnu/liblz4.so: binary file matches
xxhash isn't included in public headers, and the pkg-config file rightfully
doesn't mention xxhash at all. CMake is the only one wrong.
Given upstream's only supported build system are Makefiles, and the only
supported way of consuming the library as a dependency is via its pkg-config
file, you have two choices:
1. Go back to using the official Makefiles, and stop using the community
maintained CMake build scripts
2. Fix this issue upstream, and keep fixing CMake issues, adding maintenance
burden
Given using CMake instead of the officially supported build system has caused
issues to Arch Linux in the past[1] for the zstd package (which has the same
upstream developer and build system situation), I generally find it unwise to
use CMake at all for Debian. I know, people will keep asking for CMake config
files, but sometimes it's fine to just say no. In my opinion, this is a
decision that has to be taken upstream, not here; Debian should follow
upstream's recommendations.
If you have any question related to CMake or build systems in general, feel
free to ask!
Bye :)
[1]: https://www.phoronix.com/news/Arch-Linux-Bizarre-Zstd
- -- System Information:
Debian Release: trixie/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 6.9.12-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
iIoEARYIADIWIQS6VuNIvZRFHt7JcAdKkgiiRVB3pwUCZrNMwxQcYW5kcmVhQHBh
cHBhY29kYS5pdAAKCRBKkgiiRVB3p9KMAQC6tGUvQD30GejfqLARrGRuGBL4E0S8
KCy0FaiuG6TIEwD+PacPP0ElqhY9EdQ88VmkAvdX7al6Nb1jSljNldNC3Qg=
=ladj
-----END PGP SIGNATURE-----
--- End Message ---
--- Begin Message ---
Source: lz4
Source-Version: 1.10.0-2
Done: Nobuhiro Iwamatsu <[email protected]>
We believe that the bug you reported is fixed in the latest version of
lz4, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Nobuhiro Iwamatsu <[email protected]> (supplier of updated lz4 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 03 Jan 2025 07:59:41 +0900
Source: lz4
Architecture: source
Version: 1.10.0-2
Distribution: experimental
Urgency: medium
Maintainer: Nobuhiro Iwamatsu <[email protected]>
Changed-By: Nobuhiro Iwamatsu <[email protected]>
Closes: 1077401 1078134 1078995 1085679 1091188
Changes:
lz4 (1.10.0-2) experimental; urgency=medium
.
* Update d/patches/use-system-xxhash.patch.
- Add -lxxhash to liblz4.pc.in.
- Drop compile definitipons 'XXH_NAMESPACE=LZ4_' with patch.
(Closes: #1091188, #1085679, #1078995)
* d/control: Add libxxhash-dev to B-D of liblz4-dev.
(Closes: #1078134, #1077401)
Checksums-Sha1:
370f44fb008d3c6e52562b76b4c31977ef9d8d56 1941 lz4_1.10.0-2.dsc
a41fbd06055542eac4f80e187a279bd8db938a85 7452 lz4_1.10.0-2.debian.tar.xz
578b1848bcc4bddf3f38661922789e2be20218fa 8399 lz4_1.10.0-2_amd64.buildinfo
Checksums-Sha256:
26de50e00e9cb7202424f3e8729d4b0760cfb0a24a6b429deb2e7b048c9d37c2 1941
lz4_1.10.0-2.dsc
cce1cd592604844ce358aa3aa0620bbfc439669c727768ca695a29dc2c36540c 7452
lz4_1.10.0-2.debian.tar.xz
c9b4edf71ac2266b8a5bec51d3891c51eb5bdf84472e54a7c6a5126505be9639 8399
lz4_1.10.0-2_amd64.buildinfo
Files:
9fb765b92f89093d33870f3b420d4de0 1941 utils optional lz4_1.10.0-2.dsc
2c50d6f32633eca5e4e7b1bd84ba8777 7452 utils optional lz4_1.10.0-2.debian.tar.xz
1d63af5023d76e6ae8492b7304c214f0 8399 utils optional
lz4_1.10.0-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEXmKe5SMhlzV7hM9DMiR/u0CtH6YFAmd3MOsACgkQMiR/u0Ct
H6bZSA//bSiA6xvi07dbdQgXAcSHezTphdW5lwd1OXBmv/MP2m9ldEPGOSPnRQVl
7xm7aJyQNgD1R7b4BUVsQJshM6bCXcdnGiwO85wVpXmWftA7ZX/5BGFoK8Ig75hG
45WXhPRqyF68XeztsPtlDEgeYOXBu3mShKnwIVLIqYCFHMohMv2m83oxEo4mYoGe
dmVBWqUsextMOF2FotaquMBbBVdC0mcL99CtsGfr156HV/IkTW94gJ2mcYT6zhGS
W9ha7iUGb4aGKB+43qUj4Hrypqsppe0S3/US8ObmVBNa9ZnjprZ2pB2BFp7D98vy
v7XLYWONLYxv9UgtO/GJxnZEGorJ45tQjjYcLsnZojlF8j8nFfY+S7AQdpkRIthv
Fty0um+Y285nyy9GB/6xhxbgfsySNK8bphgkmpmwx3YuytJbhYhelwLBEUwFePFH
7YG0k3kLYV8bQ2IHD/OarXnmXWmBO/MYFrKT7n1Z7tGuOLoELn/VErmSeXzmEjHN
uwYBmNjXSdfhyTEaq2blWM0KqOrm1agOdhTEd6mosb34CAMBDhgfcg0Xs2IBEVaz
phicOxlLTcI221q4uNXBnKJFrRgPD+56KQloOLaYibvPE59208XGd15b0WwQnpmp
U1ddJpr+EEmzzlm46gpywnUY7qmefSEHC+y7Vt+Iz1DqJrLHxVg=
=TbZS
-----END PGP SIGNATURE-----
pgpebQGRW5w8l.pgp
Description: PGP signature
--- End Message ---
