Your message dated Mon, 6 Jan 2025 15:10:53 +0100
with message-id <[email protected]>
and subject line Too intrusive
has caused the Debian Bug report #1076545,
regarding websockify: Make optional token plugins actually optional
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1076545: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076545
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: websockify
Version: 0.12.0+dfsg1-2
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: origin-ubuntu oracular ubuntu-patch
Dear Maintainer,
In Ubuntu, the attached patch was applied to achieve the following:
* d/control,d/p/optional-runtime-depends.patch:
Drop python3-{redis,jwcrypto} from Depends to Suggests as these
features are optional, patch setup.py to reflect this.
I've submitted this change to the upstream project as well.
I also dropped a duplicated dependency on python3-numpy -
python3-websockify depends on this already so no need to also do
it for websockify itself.
Thanks for considering the patch.
-- System Information:
Debian Release: trixie/sid
APT prefers oracular
APT policy: (500, 'oracular'), (100, 'oracular-proposed')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 6.8.0-31-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru websockify-0.12.0+dfsg1/debian/control
websockify-0.12.0+dfsg1/debian/control
--- websockify-0.12.0+dfsg1/debian/control 2024-07-16 02:31:21.000000000
+0100
+++ websockify-0.12.0+dfsg1/debian/control 2024-07-18 11:04:29.000000000
+0100
@@ -60,12 +60,13 @@
Package: websockify
Architecture: any
Depends:
- python3-jwcrypto,
- python3-numpy,
python3-websockify (>= ${source:Version}),
${misc:Depends},
${python3:Depends},
${shlibs:Depends},
+Suggests:
+ python3-jwcrypto,
+ python3-redis,
Description: WebSockets support for any application/server
websockify was formerly named wsproxy and was part of the noVNC project.
.
diff -Nru websockify-0.12.0+dfsg1/debian/patches/optional-runtime-depends.patch
websockify-0.12.0+dfsg1/debian/patches/optional-runtime-depends.patch
--- websockify-0.12.0+dfsg1/debian/patches/optional-runtime-depends.patch
1970-01-01 01:00:00.000000000 +0100
+++ websockify-0.12.0+dfsg1/debian/patches/optional-runtime-depends.patch
2024-07-18 10:47:28.000000000 +0100
@@ -0,0 +1,22 @@
+Description: Make optional depends optional
+ Redis and JWCryto are both optional dependencies;
+ update setuptools configuration to this effect.
+Author: James Page <[email protected]>
+Forwarded: https://github.com/novnc/websockify/pull/582
+
+--- a/setup.py
++++ b/setup.py
+@@ -31,9 +31,11 @@
+ include_package_data=True,
+ install_requires=[
+ 'numpy', 'requests',
+- 'jwcrypto',
+- 'redis',
+ ],
++ extras_requires={
++ 'redis': ['redis'],
++ 'jwt': ['jwcrypto'],
++ },
+ zip_safe=False,
+ entry_points={
+ 'console_scripts': [
diff -Nru websockify-0.12.0+dfsg1/debian/patches/series
websockify-0.12.0+dfsg1/debian/patches/series
--- websockify-0.12.0+dfsg1/debian/patches/series 2024-07-16
02:31:21.000000000 +0100
+++ websockify-0.12.0+dfsg1/debian/patches/series 2024-07-18
10:47:40.000000000 +0100
@@ -3,3 +3,4 @@
remove-testing-RSA1_5-now-deprecated-in-jwcrypto.patch
workaround-using-too-much-resource.patch
py3.12-avoid-raw-string-warning.patch
+optional-runtime-depends.patch
--- End Message ---
--- Begin Message ---
Hi,
I'm sorry but I'll have to decline that one, as I feel like the patch is
too intrusive, and I don't want to be maintaining this forever, when I
don't think this helps Debian (though I understand it is helping Ubuntu).
My suggestion: try to upstream this...
Thomas Goirand (zigo)
--- End Message ---
