Your message dated Mon, 06 Jan 2025 17:10:41 +0100
with message-id <[email protected]>
and subject line Re: wlroots: Please add color management support to wlroots
has caused the Debian Bug report #1080008,
regarding Please add color management support to wlroots
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1080008: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1080008
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: wlroots
Version: 0.18.0-2
Severity: wishlist
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Triggered by a comment from 'emersion' [1] (upstream maintainer for both
sway and wlroots) I started looking at wlroots 0.18 B-Ds.
Directly related to that, AFAICT wlroots needs a B-D on `liblcms2-dev`
to have color management support (in sway, but possibly all wlroot based
compositors).
I started to work on a patch, but by now I'm (too) confused, so I
figured I'd make it into a wishlist bug instead.
Some of the things I found:
1. Some B-Ds have different version requirements from the wlroots source
package compared to the Depends of the `libwlroots-0.18-dev` package.
This seems illogical to me, but could be intentional and I just didn't
find the reason behind it (possibly PEBKAC).
2. I (initially) thought that it would also need a B-D on `libudev`,
but while writing this bug I found that it's listed as a (B-)D for
*sway*, when wlroots has the libinput_backend feature, which is or
should be the case for the Debian package.
3. While looking through the upstream commits and various `meson.build`
files, I noticed that a lot of features have been made optional. Which
in turn IIUC means that some features that were available in f.e.
wlroots 0.17 are no longer available because a/some dependencies are not
available. Or in my opinion worse: they could be accidentally available.
4. Related to 3. I think that more features need to be explicitly
enabled. In `debian/rules` I saw that the 'drm', 'libinput' and 'x11'
backends are enabled, but maybe that should be extended?
It seems that it is unlikely that the wlroots build fails, but it could
be that it succeeds while it actually does NOT have certain features
that you actually want(ed) to have? Having a build failure in this case
seems preferable *to me*.
But while working on this I came to the conclusion that I need to learn
more about the meson build system to *fully* understand it.
And having an 'x11' backend while there's also an xwayland feature is
confusing too, so I concluded I'd better leave it up to the maintainers
of the Debian packages.
I will include my WIP patch in case it helps, but won't add the 'patch'
tag to this bug.
Cheers,
Diederik
[1] https://github.com/swaywm/sway/pull/7681#issuecomment-2308926702
- -- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 6.10.6-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-----BEGIN PGP SIGNATURE-----
iHUEARYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZtBmnQAKCRDXblvOeH7b
bgZQAQCK7mP0m7ZtGrn7uaEFyMtQtElqLLVLqIxXdPRSVco89QEAk5LbdVV3qZVT
lplNL5vm+T3/iRg396h5dW5/83CmmwA=
=6SZw
-----END PGP SIGNATURE-----
>From 79b06c8ac9c8c0f983528e802cbe10ede153ade7 Mon Sep 17 00:00:00 2001
From: Diederik de Haas <[email protected]>
Date: Wed, 28 Aug 2024 16:36:31 +0200
Subject: [PATCH] d/control: Update Build Dependencies
>From ``meson.build``:
8bbe8624dfdb ("build: bump pixman version")
Upped the minimal required version of libpixman to version 0.42.0.
Note that this commit was already part of wlroots 0.17.
>From ``backend/drm/meson.build``:
22d9df2af483 ("backend/drm: send output layer feedback events")
Upped the minimal required version of libliftoff to 0.4.0, not 0.4.1.
The right version was set in libwlroots-0.18-dev binary package.
6e6c4408d36d ("backend/drm: add support for libliftoff v0.5.0")
OTOH prepared for version 0.5.0, but doesn't require it (yet).
0a79bc28c7eb ("build: require libinput v1.19")
Upped the minimal required version of libinput to 1.19.
Note that that version is available in Stable, but not older versions.
56c842fcde8a ("d/control: Drop version superfluous information")
Dropped the version requirement (of 1.9.0) because "We have recent
enough versions even in stable.", but even o-o-s has 1.12, so I do
consider this different enough to bring back the version requirement.
>From ``render/meson.build``:
895e3d18b903 ("render/color: introduce wlr_color_transform")
Added color management support to wlroots, but only if liblcms2-dev is
available. This can be used by sway if wlroots has this functionality.
Fixes: 89f88ab37a7f ("d/control: Update build-deps for new upstream version")
Link:
https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/8bbe8624dfdb4fbf120aee3dd6f0f8eeeed3bf7e
Link:
https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/22d9df2af483bb862c24bcb973e8ab3475759ebe
Link:
https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/6e6c4408d36ddad705458ca4b2e301192f7963fd
Link:
https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/895e3d18b90337369b03f44258c108b3c1f346ca
Link: https://github.com/swaywm/sway/pull/7681#issuecomment-2308926702
---
debian/control | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/debian/control b/debian/control
index 78b0326aa..52de1f328 100644
--- a/debian/control
+++ b/debian/control
@@ -14,9 +14,10 @@ Build-Depends: dpkg-dev (>= 1.22.5),
libegl-dev,
libgbm-dev,
libgles2-mesa-dev,
- libinput-dev,
- libliftoff-dev (>= 0.4.1),
- libpixman-1-dev,
+ libinput-dev (>= 1.19.0),
+ liblcms2-dev,
+ libliftoff-dev (>= 0.4.0),
+ libpixman-1-dev (>= 0.42.0),
libpng-dev,
libseat-dev,
libsystemd-dev,
--
2.45.2
--- End Message ---
--- Begin Message ---
Version: 0.18.2-1
On Thu Aug 29, 2024 at 2:16 PM CEST, Diederik de Haas wrote:
> Source: wlroots
> Version: 0.18.0-2
> Severity: wishlist
>
> Triggered by a comment from 'emersion' [1] (upstream maintainer for both
> sway and wlroots) I started looking at wlroots 0.18 B-Ds.
> Directly related to that, AFAICT wlroots needs a B-D on `liblcms2-dev`
> to have color management support (in sway, but possibly all wlroot based
> compositors).
>
> [1] https://github.com/swaywm/sway/pull/7681#issuecomment-2308926702
With the upload of 0.18.2-1 wlroots now has that color management
support. IIUC it does require a rebuild of sway for sway to pick up that
color management support as well. But this bug is fixed, thanks :-)
signature.asc
Description: PGP signature
--- End Message ---
