Your message dated Fri, 07 Feb 2025 07:04:11 +0000
with message-id <[email protected]>
and subject line Bug#1095250: fixed in frotz 2.55+dfsg-2
has caused the Debian Bug report #1095250,
regarding frotz FTCBFS: upstream Makefile changes broke cross compilation
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1095250: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095250
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: frotz
Version: 2.55+dfsg-1
Tags: patch
User: [email protected]
Usertags: ftcbfs
frotz fails to cross build from source for two reasons. For one thing,
upstream renamed the variable PKG_CONFIG to PKGCONF_BIN and
dh_auto_build does not supply the latter. As a result, frotz uses the
build architecture pkgconf and fails finding many of the required
libraries. For another ux_defines.h is listed in .PHONY and thus rebuilt
on every invocation. This incurs a rebuild during make install, but
dh_auto_install does not pass cross tools to make install and hence the
wrong toolchain is being used there. I suspect upstream wants
ux_defines.h to always get rebuilt, but that runs counter to the general
idea of building during dh_auto_build. I'm not sure dropping it from
.PHONY is something acceptable upstream, but it is necessary on the
Debian side. I'm attaching a patch for your convenience.
Helmut
diff --minimal -Nru frotz-2.55+dfsg/debian/changelog
frotz-2.55+dfsg/debian/changelog
--- frotz-2.55+dfsg/debian/changelog 2025-02-03 07:35:10.000000000 +0100
+++ frotz-2.55+dfsg/debian/changelog 2025-02-05 08:25:13.000000000 +0100
@@ -1,3 +1,13 @@
+frotz (2.55+dfsg-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Adapt to upstream rename PKG_CONFIG -> PKGCONF_BIN.
+ + cross.patch: Remove ux_defines.h from .PHONY to avoid rebuilding during
+ make install.
+
+ -- Helmut Grohne <[email protected]> Wed, 05 Feb 2025 08:25:13 +0100
+
frotz (2.55+dfsg-1) unstable; urgency=medium
* New upstream release, obsoleting uint32.patch.
diff --minimal -Nru frotz-2.55+dfsg/debian/patches/cross.patch
frotz-2.55+dfsg/debian/patches/cross.patch
--- frotz-2.55+dfsg/debian/patches/cross.patch 1970-01-01 01:00:00.000000000
+0100
+++ frotz-2.55+dfsg/debian/patches/cross.patch 2025-02-05 08:25:13.000000000
+0100
@@ -0,0 +1,9 @@
+--- frotz-2.55+dfsg.orig/src/curses/Makefile
++++ frotz-2.55+dfsg/src/curses/Makefile
+@@ -74,5 +74,5 @@
+ %.o: %.c $(DEFINES)
+ $(CC) $(CFLAGS) $(CURSES_CFLAGS) $(NO_SOUND) -fPIC -fpic -o $@ -c $<
+
+-.PHONY: clean $(DEFINES)
++.PHONY: clean
+ .DELETE_ON_ERROR:
diff --minimal -Nru frotz-2.55+dfsg/debian/patches/series
frotz-2.55+dfsg/debian/patches/series
--- frotz-2.55+dfsg/debian/patches/series 2025-02-03 07:02:10.000000000
+0100
+++ frotz-2.55+dfsg/debian/patches/series 2025-02-05 08:25:13.000000000
+0100
@@ -0,0 +1 @@
+cross.patch
diff --minimal -Nru frotz-2.55+dfsg/debian/rules frotz-2.55+dfsg/debian/rules
--- frotz-2.55+dfsg/debian/rules 2021-03-02 13:36:29.000000000 +0100
+++ frotz-2.55+dfsg/debian/rules 2025-02-05 08:25:13.000000000 +0100
@@ -5,13 +5,14 @@
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+include /usr/share/dpkg/buildtools.mk
include /usr/share/dpkg/buildflags.mk
%:
dh $@
override_dh_auto_build:
- dh_auto_build -- BINDIR=/usr/games CFLAGS="$(CPPFLAGS) $(CFLAGS)"
curses dumb sdl
+ dh_auto_build -- BINDIR=/usr/games CFLAGS="$(CPPFLAGS) $(CFLAGS)"
curses dumb sdl PKGCONF_BIN='$(PKG_CONFIG)'
override_dh_auto_install:
dh_auto_install -- BINDIR=/usr/games PREFIX=/usr install_frotz
install_dfrotz install_sfrotz
--- End Message ---
--- Begin Message ---
Source: frotz
Source-Version: 2.55+dfsg-2
Done: Stephen Kitt <[email protected]>
We believe that the bug you reported is fixed in the latest version of
frotz, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stephen Kitt <[email protected]> (supplier of updated frotz package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 07 Feb 2025 07:46:03 +0100
Source: frotz
Architecture: source
Version: 2.55+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Stephen Kitt <[email protected]>
Closes: 1095250
Changes:
frotz (2.55+dfsg-2) unstable; urgency=medium
.
[ Helmut Grohne ]
* Fix FTCBFS:
+ Adapt to upstream rename PKG_CONFIG -> PKGCONF_BIN.
+ cross.patch: Remove ux_defines.h from .PHONY to avoid rebuilding during
make install.
Closes: #1095250.
Checksums-Sha1:
65549aae8098f8b008875085df977e38f6435626 2128 frotz_2.55+dfsg-2.dsc
675c10d5d6a1eea194fa372d0cd70c2ed8676b27 7736 frotz_2.55+dfsg-2.debian.tar.xz
41ee86cfc72f60dc6a667426c8e771f208cd72d7 12557
frotz_2.55+dfsg-2_source.buildinfo
Checksums-Sha256:
9cd22361dec413359c68f29c2cb715907826a42943708522af164a7e7df0b40e 2128
frotz_2.55+dfsg-2.dsc
2427587cbd4e68df193a5b190123fdd3fcd6e8328839ec19a8cf7dab9420e6f5 7736
frotz_2.55+dfsg-2.debian.tar.xz
de9dbe2b420efe0e864bc58baa0aa0164a3a1f40d56ebaa76716f0be2d47460e 12557
frotz_2.55+dfsg-2_source.buildinfo
Files:
32e79ab757b68a83660486b162156d02 2128 games optional frotz_2.55+dfsg-2.dsc
83df82b324353e543747f1af783b9ce9 7736 games optional
frotz_2.55+dfsg-2.debian.tar.xz
426e6177e5721f7a650deab1560d912b 12557 games optional
frotz_2.55+dfsg-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmelrHkACgkQgNMC9Yht
g5yOPA/8CIVdyMeQdpOfkMP2SefivFRFj8TM3OGT3QlCAjfZAp1BTmHChca2dWoA
ixhGgzo1k9JGAkOFR/uMUUHk6ewlW7KEQ2bPS1hgKXU/8B0rxYdylZhJzYdPJSDD
yVEzCzkc0/M4A4fwwY1r6g0vFVwM1CejmX8FelR4H8gI+S4gJuaYNIqz8t+FE+SN
+EdDcJGIR8lZyZQH4MEKtZDWnv/RJaXdBVndyJQK7ExHibTTtl9U9pq+rH4bqoRl
pc6LzFMEe7ZnyqeKqzXPpc+p/2CgbG5NuWdmp1ze+ZO6yDaWtawGdxX00xCsK3kk
mHZijXkOotqRBT772EpwAEBTGE24kqpiVBTEY3hu6grO2hTVtFrkqss/4Q8En8OA
nc3+fjJKFr56O/n3nurKt+8njHzMYzrg0sZ3Rp0FB1Ujfsdu39y1w6FKI5oZxALz
Cir/1Ra9EMg+QCjo0fwsHNQ66eNqBE+YrfeL/zDrn3G1sFzbn3zzgU/YXaj3aPFE
VtzkQwq2tiL6V39R/8K4ZYjZIfxx8aZBpYT6Waf1ntkR7gA4COAFn2e+oanDsfW9
4vv21VB8QLn2WJ6j4wJPCOVKOH5MRe8s9/66K352Ikfin9GMLKLdA7grEvQZuprZ
Cb8E5c3LHoScU4QVCxDpUgYNp8h8ztZoCjq7XfJ7jCkYdxFqWpY=
=q4Nk
-----END PGP SIGNATURE-----
pgptjpx_w5f_Z.pgp
Description: PGP signature
--- End Message ---
