Your message dated Fri, 28 Feb 2025 08:31:56 +0100
with message-id <[email protected]>
and subject line Re: Bug#984459: spring: Broken manpages due to bashisms in 
source
has caused the Debian Bug report #984459,
regarding spring: Broken manpages due to bashisms in source
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
984459: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=984459
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: spring
Version: 105.0.1+dfsg-2
Severity: important

In spring.6.txt there are snippets like the following:

    {sys: echo -e "{USER_WRITEDIRS}"}

However, this is not portable across shells, as echo -e is a bash
extension, causing this to print a literal -e when /bin/sh is dash.
This is important, since that is the default for Debian systems,
including on all buildds.

Interestingly, the escape sequences still give the right value for
dash, the only difference is whether -e is printed too, so I suspect
the -e is entirely superfluous and asciidoc(?) has already done the
expansion (and potentially risks double-expanding on bash, so \\n might
print as a newline rather than a literal \n), but that is just
speculation. Regardless, this should be fixed one way or another, as
the packages currently in the archive have stray -e's in the manpage:

       
+---------+-------------------+--------------------------------------+--------------------------------------+--------------------------------------+
       |priority |      section      |                normal                |   
            portable               |              isolation               |
       
+---------+-------------------+--------------------------------------+--------------------------------------+--------------------------------------+
       |         |                   |                                      |   
                                   |                                      |
       |    high | custom user write | -e directory defined via --write-dir | 
-e directory defined via --write-dir | -e directory defined via --write-dir |
       |         |                   |                                      |   
                                   |                                      |
       |         |                   | SPRING_WRITEDIR envvar               | 
SPRING_WRITEDIR envvar               | SPRING_WRITEDIR envvar               |
       
+---------+-------------------+--------------------------------------+--------------------------------------+--------------------------------------+
       |         |                   |                                      |   
                                   |                                      |
       |         | automatic scanned | -e CONFIG_HOME                       | 
-e INSTALL_DIR                       | ISOLATION_DIR                        |
       |         |                   |                                      |   
                                   |                                      |
       |         |                   | ETC_DIRS                             | 
CONFIG_HOME                          |                                      |
       |         |                   |                                      |   
                                   |                                      |
       |         |                   | USR_SHARE                            | 
ETC_DIRS                             |                                      |
       |         |                   |                                      |   
                                   |                                      |
       |         |                   |                                      | 
USR_SHARE                            |                                      |
       
+---------+-------------------+--------------------------------------+--------------------------------------+--------------------------------------+
       |         |                   |                                      |   
                                   |                                      |
       |     low | custom user read  | -e SPRING_DATADIR envvar             | 
-e SPRING_DATADIR envvar             | -e SPRING_DATADIR envvar             |
       |         |                   |                                      |   
                                   |                                      |
       |         |                   | SpringData configtag                 | 
SpringData configtag                 | SpringData configtag                 |
       
+---------+-------------------+--------------------------------------+--------------------------------------+--------------------------------------+

(spring(6) in the latest amd64 unstable package)

In case you're interested, this was discovered by the automated builds
done as part of reproducible-builds.org.

Jess

--- End Message ---
--- Begin Message ---
Version: 106.0+dfsg-1

[Stephen Kitt]
> https://salsa.debian.org/games-team/spring/-/blob/master/doc/manpages/spring.6.txt

Thank you.  In that case, I believe it was fixed with upload
106.0+dfsg-1 when debian/patches/manpage.patch was included.

-- 
Happy hacking
Petter Reinholdtsen

--- End Message ---

Reply via email to