Your message dated Mon, 31 Jul 2006 16:50:00 +0200
with message-id <[EMAIL PROTECTED]>
and subject line cvsweb: Bugs fixed in cvsweb 3.0.6-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: cvsweb
Version: 3:3.0.0-1.1
Severity: important
Tags: patch

The new version of cvsweb should behave exactly like the old version,
so upgrades work in place.  This is the case for more stuff but not
for all, which broke at least my upgrade.

The current version of cvsweb is not able to act CGI-less like it is
configured on <http://cvs.debian.org/> and <http://cvs.infodrom.org/>.
It can only be used as /cgi-bin/cvsweb.  This is unfortunate since not
only viewcvs (Python) supported this but also the older version of
cvsweb (Perl) and, hence, I believe that the new version should
support this as well.

Fortunately, the required changes are only minimal:

 1. Don't turn zero / into one /, the rule was probably intended to
    reduce multiple slashes into only one.  However, without the
    /cgi-bin/ component, there would not be one slash in the first
    place.

 2. Only apply the thttpd rule if the script is executed from within
    thttpd, and not from within Apache, for example.

 3. Only add /$where to the URL if $where is about, which is not the
    case when called without the /cgi-bin/ component

 4. Decode the Query string before splitting it by /;/ since ";" could
    be encoded as "%3b", which is the case for an Apache redirect if
    you don't request "noescape|NE"

I'm attaching a patch to fix this.

If cvsweb doesn't break again, you can find the configuration for the
virtual host at the following URL
http://cvs.infodrom.org/config/luonnotar/web/cvs.infodrom.org?cvsroot=infodrom.org

Regards,

        Joey

-- 
Unix is user friendly ...  It's just picky about its friends.

Please always Cc to me when replying to me on the lists.
--- /usr/lib/cgi-bin/cvsweb.orig        2004-05-05 07:51:04.000000000 +0200
+++ /usr/lib/cgi-bin/cvsweb     2004-05-05 09:43:05.000000000 +0200
@@ -302,17 +302,17 @@
 $doCheckout    =  ($where =~ m|^/$CheckoutMagic/|o);
 $where         =~ s|^/$CheckoutMagic/|/|o;
 $where         =~ s|^/||;
-$scriptname    =~ s|^/*|/|;
+$scriptname    =~ s|^/+|/|;
 
 # Let's workaround thttpd's stupidity..
-if ($scriptname =~ m|/$|) {
+if ($ENV{'SERVER_SOFTWARE'} =~ m|thttpd| && $scriptname =~ m|/$|) {
   $pathinfo .= '/';
   my $re = quotemeta $pathinfo;
   $scriptname =~ s/$re$//;
 }
 
 $scriptwhere  = $scriptname;
-$scriptwhere .= '/' . urlencode($where);
+$scriptwhere .= '/' . urlencode($where) if ($where);
 $where = '/' if ($where eq '');
 
 # In text-based browsers, it's very annoying to have two links per file;
@@ -383,6 +383,7 @@
 
 my %query = ();
 if (defined($ENV{QUERY_STRING})) {
+  $ENV{QUERY_STRING} = uri_unescape($ENV{QUERY_STRING});
   for my $p (split(/[;&]+/, $ENV{QUERY_STRING})) {
     next unless $p;
     $p =~ y/+/ /;

--- End Message ---
--- Begin Message ---
Source: cvsweb
Source-Version: 3.0.6-1

We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive:

cvsweb_3.0.6-1.diff.gz
  to pool/main/c/cvsweb/cvsweb_3.0.6-1.diff.gz
cvsweb_3.0.6-1.dsc
  to pool/main/c/cvsweb/cvsweb_3.0.6-1.dsc
cvsweb_3.0.6-1_all.deb
  to pool/main/c/cvsweb/cvsweb_3.0.6-1_all.deb
cvsweb_3.0.6.orig.tar.gz
  to pool/main/c/cvsweb/cvsweb_3.0.6.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.
        
Thank you for reporting the bug, which will now be closed.
        
Daniel Leidert (dale) <[EMAIL PROTECTED]> (supplier of updated
cvsweb package)
        
(This message was generated, because there were problems during upload,
so the bugs were not automatically closed. I'm really sorry for the
trouble.)

-----

Format: 1.7
Date: Sun, 11 Jun 2006 11:24:11 +0200
Source: cvsweb
Binary: cvsweb
Architecture: source all
Version: 3:3.0.6-1
Distribution: unstable
Urgency: low
Maintainer: Michael Banck <[EMAIL PROTECTED]>
Changed-By: Daniel Leidert (dale) <[EMAIL PROTECTED]>
Description: 
 cvsweb     - CGI interface to your CVS repository
Closes: 110181 269950 372622 372992
Changes: 
 cvsweb (3:3.0.6-1) unstable; urgency=low
 .
   * New upstream release 3.0.6 (closes #338996).
 .
   [ Daniel Leidert ]
   * New maintainer (closes: #372622).
   * debian/changelog: Changed to UTF-8 (solves lintian error).
   * debian/control: Change to latest standards version 3.7.2. Fixed short
     description. Removed dpkg-dev and debmake from build-dependencies in
     accordance to http://lists.debian.org/debian-devel/2005/12/msg01428.html
     (closes: #372992). Added dpatch and moved debhelper to build dependencies.
   * debian/copyright: Updated copyright info.
   * debian/rules: Completely rewritten. Makes use of various debhelper scripts
     and dpatch etc. to ease build process and remove debmake and dpkg-dev
     build dependencies.
   * debian/cvsweb.docs: Added. See above.
   * debian/cvsweb.manpages: Ditto.
   * debian/cvsweb.install: Ditto. Further now install cvsweb.css and
     cvsweb.conf into /etc/cvsweb (closes: #110181).
   * debian/cvsweb.dirs: See above.
   * debian/cvsweb.links: See above. Further links /var/www/cvsweb to
     /usr/share/cvsweb (closes: #269950).
   * debian/NEWS: Inform about configuration path changes. See above.
   * debian/cvsweb.preinst: Ditto.
   * debian/cvsweb.postinst: Ditto.
   * debian/patches/01_debianize_script_and_config.dpatch: This is not new.
     Only moved patch to dpatch and changed config-path to /etc/cvsweb (see
     above).
   * debian/patches/90_extend_httpd_config_sample.dpatch: Ditto.
   * debian/patches/02_allow_cgiless_execution.dpatch: Add support for CGI-less
     execution (closes #247452).
Files: 
 dc0cda68c140b4cca0fbec796003e32e 580 devel optional cvsweb_3.0.6-1.dsc
 0e1eec962b1db00e01b295fff84b6e89 72484 devel optional cvsweb_3.0.6.orig.tar.gz
 d3a20b76b7778921e6bd86b0910ea0e4 10702 devel optional cvsweb_3.0.6-1.diff.gz
 8434c0aaedded7c122db5453b24d2bfc 66180 devel optional cvsweb_3.0.6-1_all.deb



--- End Message ---

Reply via email to