Your message dated Thu, 6 Mar 2025 20:37:05 +0100
with message-id
<ailmef7luzwx6gfop7oobi62lhtx6nmherqcx3kfikjk67ad7q@[email protected]>
and subject line Re: Bug#1099661: software-properties-common:
apt-add-repository scripts lack robustness, breaking Debian-derivative distros
has caused the Debian Bug report #1099661,
regarding software-properties-common: apt-add-repository scripts lack
robustness, breaking Debian-derivative distros
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1099661: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1099661
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: software-properties-common
Version: 0.99.30-4.1
Severity: important
X-Debbugs-Cc: [email protected]
Dear Maintainer,
I am trying, and failing, to use software-properties-common on Devuan (= Debian
without systemd). I get:
# add-apt-repository ppa:libreoffice/ppa
Traceback (most recent call last):
File "/usr/bin/apt-add-repository", line 361, in <module>
addaptrepo = AddAptRepository()
File "/usr/bin/apt-add-repository", line 39, in __init__
self.distro.get_sources(self.sourceslist)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/aptsources/distro.py", line 92, in
get_sources
raise NoDistroTemplateException(
...<2 lines>...
)
aptsources.distro.NoDistroTemplateException: Error: could not find a
distribution template for devuan/excalibur ceres
Devuan does has a templates .info file, /usr/share/python-
apt/templates/Devuan.info ; and I have added Devuan excalibur to that file.
That template file is of course not part of software-properties-common, but
your package is intended to support such distribution templates, IIUC.
Anyway, there seems to be a combination of two problems (at least).
The first is in the treatment of uppercase vs lowercase. The template file name
has Devuan in uppercase, but in some places in the code it seems the
distribution name is determined to be devuan, lowercase.
The second is the inclusion of an extra space plus "ceres" in the distro name.
I would have expected either "devuan/excalibur" or just "excalibur", but
instead it's "devuan/excalibur ceres", which is probably not right. I think
this may have something to do with the parsing of /etc/devuan_version:
# cat /etc/devuan_version
excalibur/ceres
# cat /etc/debian_version
trixie/sid
(although I could be wrong). Anyway, I would appreciate your help in
"robustifying" your package so that it is more flexible in the use of
templates, for Debian-derivative distributions like Devuan and others.
Here's the entry for excalibur in the Devuan.info template file:
Suite: excalibur
RepositoryType: deb
BaseURI: http://deb.devuan.org/merged/
MatchURI: [a-z]{2}\.deb\.devuan\.org
MirrorsFile: Devuan.mirrors
_Description: Devuan 6 'Excalibur'
Component: main
_CompDescription: Officially supported
Component: contrib
_CompDescription: DFSG-compatible Software with Non-Free Dependencies
Component: non-free
_CompDescription: Non-DFSG-compatible Software
-- System Information:
Distributor ID: Devuan
Description: Devuan GNU/Linux 6 (excalibur/ceres)
Release: 6
Codename: excalibur ceres
Architecture: x86_64
Kernel: Linux 6.6.13-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_IL, LC_CTYPE=en_IL (charmap=UTF-8), LANGUAGE=en_IL:en
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled
Versions of packages software-properties-common depends on:
ii ca-certificates 20241223
ii gir1.2-glib-2.0 2.83.3-2
ii gir1.2-packagekitglib-1.0 1.3.0-2devuan1
ii packagekit 1.3.0-2devuan1
ii python-apt-common 2.9.8
ii python3 3.13.1-2
ii python3-dbus 1.3.2-5+b4
ii python3-gi 3.50.0-4
ii python3-software-properties 0.99.30-4.1
software-properties-common recommends no packages.
software-properties-common suggests no packages.
-- no debconf information
--- End Message ---
--- Begin Message ---
On March 6, 2025 2:06:33 PM GMT+01:00, Eyal Rozenberg <[email protected]> wrote:
>Package: software-properties-common
>Version: 0.99.30-4.1
>Severity: important
>X-Debbugs-Cc: [email protected]
>
>Dear Maintainer,
>
>I am trying, and failing, to use software-properties-common on Devuan (= Debian
>without systemd). I get:
>
> # add-apt-repository ppa:libreoffice/ppa
> Traceback (most recent call last):
> File "/usr/bin/apt-add-repository", line 361, in <module>
> addaptrepo = AddAptRepository()
> File "/usr/bin/apt-add-repository", line 39, in __init__
> self.distro.get_sources(self.sourceslist)
> ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
> File "/usr/lib/python3/dist-packages/aptsources/distro.py", line 92, in
>get_sources
> raise NoDistroTemplateException(
> ...<2 lines>...
> )
> aptsources.distro.NoDistroTemplateException: Error: could not find a
>distribution template for devuan/excalibur ceres
>
>
>Devuan does has a templates .info file, /usr/share/python-
>apt/templates/Devuan.info ; and I have added Devuan excalibur to that file.
>That template file is of course not part of software-properties-common, but
>your package is intended to support such distribution templates, IIUC.
>
>Anyway, there seems to be a combination of two problems (at least).
>
>The first is in the treatment of uppercase vs lowercase. The template file name
>has Devuan in uppercase, but in some places in the code it seems the
>distribution name is determined to be devuan, lowercase.
It used to be upper case but now it's lower case in recent python-apt versions
as we switched to os-release to determine info as opposed to lsb_release.
>
>The second is the inclusion of an extra space plus "ceres" in the distro name.
>I would have expected either "devuan/excalibur" or just "excalibur", but
>instead it's "devuan/excalibur ceres", which is probably not right. I think
>this may have something to do with the parsing of /etc/devuan_version:
>
> # cat /etc/devuan_version
> excalibur/ceres
> # cat /etc/debian_version
> trixie/sid
>
>(although I could be wrong). Anyway, I would appreciate your help in
>"robustifying" your package so that it is more flexible in the use of
>templates, for Debian-derivative distributions like Devuan and others.
We are using os-release in python-apt now to query this.
These are downstream Devuan bugs, go fix them yourselves.
--- End Message ---
