Your message dated Fri, 07 Mar 2025 13:49:45 +0000
with message-id <[email protected]>
and subject line Bug#966483: fixed in iptables-netflow 2.6-7.1
has caused the Debian Bug report #966483,
regarding iptables-netflow: sourcing of external scripts in dkms file?
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
966483: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966483
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: iptables-netflow
Version: 2.5-2
Severity: serious
tags: patch
Hello, looks like your dkms ship file is sourcing external stuff with
pushd/popd and so on.
I don't think this is a sane idea, specially because in Debian we don't even
use version.sh script to fill the dkms.conf file.
Can you please remove the two lines?
this is what we do to test dkms packages:
if ! dkms_conf=$(dpkg -L $pkg | grep '/usr/src' | grep '/dkms.conf$'); then
echo "I: Package $pkg has no dkms.conf, skipping"
return
fi
echo "I: Testing binary package $pkg"
dkms_pkg=$(bash -c ". $dkms_conf; echo \$PACKAGE_NAME" 2>/dev/null)
dkms_ver=$(bash -c ". $dkms_conf; echo \$PACKAGE_VERSION" 2>/dev/null)
bash -c ". dkms.conf; echo \$PACKAGE_NAME"
/tmp/iptables-netflow-2.5 /tmp/iptables-netflow-2.5
/tmp/iptables-netflow-2.5
ipt-netflow
I think dkms.conf files are meant to be sourced from outside, and launching
scripts is a bad idea.
this is the trivial patch:
Description: Don't print useless stuff and change directory in dkms file, it is
meant to be sourced from outside.
Author: Gianfranco Costamagna <[email protected]>
Bug-Debian: https://bugs.debian.org/-1
Last-Update: 2020-07-29
--- iptables-netflow-2.5.orig/dkms.conf
+++ iptables-netflow-2.5/dkms.conf
@@ -1,7 +1,5 @@
PACKAGE_NAME="ipt-netflow"
-pushd `dirname $BASH_SOURCE`
PACKAGE_VERSION=`./version.sh`
-popd
BUILT_MODULE_NAME[0]=ipt_NETFLOW
DEST_MODULE_LOCATION[0]=/kernel/extra
STRIP[0]=no
--- End Message ---
--- Begin Message ---
Source: iptables-netflow
Source-Version: 2.6-7.1
Done: Andreas Beckmann <[email protected]>
We believe that the bug you reported is fixed in the latest version of
iptables-netflow, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Beckmann <[email protected]> (supplier of updated iptables-netflow
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 07 Mar 2025 14:32:07 +0100
Source: iptables-netflow
Architecture: source
Version: 2.6-7.1
Distribution: unstable
Urgency: medium
Maintainer: Axel Beckert <[email protected]>
Changed-By: Andreas Beckmann <[email protected]>
Closes: 966483 1076456 1081377 1088678 1089498
Changes:
iptables-netflow (2.6-7.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Use debhelper-compat (= 13) substitution instead of dh-exec.
* Remove useless pushd/popd from dkms.conf. (Closes: #966483)
* Dump the generated compat_def.h.
* Update from upstream Git.
* Fix dkms status invocation.
* Avoid dkms recursion.
* dkms.conf: Declare BUILD_EXCLUSIVE_KERNEL_MIN="3".
* Fix module build for Linux v4.3.
* Unexporting find_module() has been backported to Linux v5.10.220.
(Closes: #1076456, #1088678)
* Fix module build for Linux v6.11. (Closes: #1081377)
* Fix module build for Linux v6.12. (Closes: #1089498)
* Work around physindev in nf_bridge_info being replaced by physinif to fix
module build for Linux v6.8, v6.7.2, v6.6.14, v6.1.75.
Checksums-Sha1:
debac79247e1a63712dca1f87889b57003bc175e 2072 iptables-netflow_2.6-7.1.dsc
a5378367542d380d30038b56b09326b0c1a47bf3 24532
iptables-netflow_2.6-7.1.debian.tar.xz
f983844090fd071e1b87c221772f05b961b50353 5537
iptables-netflow_2.6-7.1_source.buildinfo
Checksums-Sha256:
27a175fbe9c0a4b7f63e02266f8bf213c23aceec9f8f87e433eff99a5c28aad7 2072
iptables-netflow_2.6-7.1.dsc
a308af75736268c51f8a2601c33b325a7fbdcb11e40d76eeaedae1b4c8d8524e 24532
iptables-netflow_2.6-7.1.debian.tar.xz
754fc2f623fb069d33b90a75d93de6db989346c3c6e241030b4322eafc815c3d 5537
iptables-netflow_2.6-7.1_source.buildinfo
Files:
38c3007cf7d42662e00d90f46f3e5c0e 2072 kernel optional
iptables-netflow_2.6-7.1.dsc
ba031506e779c6e966faf788d9951eca 24532 kernel optional
iptables-netflow_2.6-7.1.debian.tar.xz
d5b223bafe5ba3a3580709b9e76e4eb8 5537 kernel optional
iptables-netflow_2.6-7.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJEBAEBCAAuFiEE6/MKMKjZxjvaRMaUX7M/k1np7QgFAmfK9o8QHGFuYmVAZGVi
aWFuLm9yZwAKCRBfsz+TWentCLLuD/wMxKeaqPdPfbSC5HupVX9Py7EODSxSR3Q5
ZKPyq31lVwqIomBXMjNrGadYl21WbeKXKPNWzibjRenv8/8hzEyAaFhFjlIEmPJ8
6Obn5bJTbAUO0MHj6EFPJE+XYTJCp3NYwOx5c0VleGWgzvhSA6jmA7iI2In1ZpT9
/onVBbP+9lhgo9b4jbg/tdnRwAdnBP0zMJT7Qo569SfCvNjVlZqZenS5gbiEKZXe
txL/8lLhEgS0wNaDUVA0tr41MMxkhnM0Mz4sNH6SBCxyuKQ8at7KQwzQWb87pszB
ZX3hvIGeXqoEoNOkXUUckt7QWFKyXTFIECqDcD3Oolu+nVvEiwx4YsvME8+Bg9Nx
zaVRjOwkRIvpdgAz/OERVyyFYrETkAXjZCAGVhldM+mOZf+DqhPQQRnkNBQjDka6
rRI0ZPd0x6IDDUAyAj3T4dlpjSUFr/OjRaCdoODUAxzRfS+TeBmRRUJzWQ4bdEFr
OTFszSNGLcIdmqs+X9M3WIpp4ADzNSNhqO53VurM+nC8yAiTv1uLEdQwQHl3Ioen
JjEsxyqiXm84I96C/pHI9IQDr9KJcRwx0ooiqgb4CqvtGL/sdqXYQMdcr+DpD0Ac
lAGkDjJejNEa5XHdkMIsK3QaZFhIQ4obTLFiWCg77jy4UxCkefTmd7wIGnXKaEH0
JWW+QUPEfw==
=ZoC/
-----END PGP SIGNATURE-----
pgpzs06eDqDt5.pgp
Description: PGP signature
--- End Message ---
