Your message dated Sun, 06 Apr 2025 06:19:30 +0000
with message-id <[email protected]>
and subject line Bug#1060420: fixed in less 668-1
has caused the Debian Bug report #1060420,
regarding less: Fix build failure on GNU/Hurd
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1060420: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060420
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: less
Source-Version: 590-2
Severity: important
Tags: patch
Forwarded: https://github.com/gwsw/less/pull/469
X-Debbugs-Cc: [email protected]

Hi!

This package has been failing to build for a while on GNU/Hurd, due to
the assumption that PATH_MAX is defined on all systems, which is not
the case on GNU/Hurd as it tries to impose no arbitrary limits
gratuitously.

I've prepared a patch fixing this and submitted that upstream, and
adapted that for the current version in Debian, which I'm attaching.

Thanks,
Guillem
From d29a630e1a112613e20bff4917fee879951a6112 Mon Sep 17 00:00:00 2001
From: Guillem Jover <[email protected]>
Date: Thu, 11 Jan 2024 02:18:07 +0100
Subject: [PATCH] Do not assume PATH_MAX is defined
Origin: vendor
Forwarded: https://github.com/gwsw/less/pull/469

On systems such as GNU/Hurd, PATH_MAX is not defined, because the system
intends to impose no arbitrary limits. In other systems though it might
be defined but to a very large value.

We can use realpath() with its POSIX.1-2008 semantics, where passing a
NULL argument will make it allocate the destination buffer, but not all
systems support these semantics yet.

For now, instead of complicating the code to cope with realpath()
limitations on some systems, we simply handle the case where PATH_MAX
is not defined, where realpath() should always support these semantics.
---
 filename.c |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

--- a/filename.c
+++ b/filename.c
@@ -800,10 +800,25 @@ lrealpath(path)
 	char *path;
 {
 #if HAVE_REALPATH
+	/*
+	 * Not all systems support the POSIX.1-2008 realpath() behavior of
+	 * allocating when passing a NULL argument. And PATH_MAX is not
+	 * required to be defined, or might contain an exceedinly big value.
+	 * We assume that if it is not defined (such as on GNU/Hurd), then
+	 * realpath() accepts NULL.
+	 */
+#ifndef PATH_MAX
+		char *rpath;
+
+		rpath = realpath(path, NULL);
+		if (rpath != NULL)
+			return rpath;
+#else
 	char rpath[PATH_MAX];
 	if (realpath(path, rpath) != NULL)
 		return (save(rpath));
 #endif
+#endif
 	return (save(path));
 }
 

--- End Message ---
--- Begin Message ---
Source: less
Source-Version: 668-1
Done: Milan Kupcevic <[email protected]>

We believe that the bug you reported is fixed in the latest version of
less, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Milan Kupcevic <[email protected]> (supplier of updated less package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 06 Apr 2025 01:23:51 -0400
Source: less
Architecture: source
Version: 668-1
Distribution: sid
Urgency: medium
Maintainer: Milan Kupcevic <[email protected]>
Changed-By: Milan Kupcevic <[email protected]>
Closes: 655926 1060420 1073071 1083280
Changes:
 less (668-1) sid; urgency=medium
 .
   * new upstream release
     - CVE-2024-32487 fixed in v654, drop patches (#1068938, #1069681)
     - more can go backwards (closes: #655926)
     - fix build failure on GNU/Hurd (closes: #1060420)
     - fix incorrect handling of UTF-8 chars in prompts (closes: #1083280)
     - exit code 1 with LESSOPEN if stdin is /dev/null (closes: #1073071)
     - extremely slow regex searches on very long lines (lp: #2067276)
   * d/p/less-is-more-434417: update upstream patch status
   * d/control: switch to debhelper 13 compatibility level
   * d/control: comply to standards version 4.7.2
   * d/copyright: update
   * d/u/signing-key.asc: rearmor
Checksums-Sha1:
 883e333013a2c52e1940ef087693421bbee5de4f 1889 less_668-1.dsc
 7f4a99fd98bf63ebc11c5bc85c0a0605376614d4 649770 less_668.orig.tar.gz
 5158b41ab8b4d4024f9a5547608184a3f579b4cc 195 less_668.orig.tar.gz.asc
 ad04273c351c72c28bf59b931c233e58df499bd9 22332 less_668-1.debian.tar.xz
 9c1182fb3343bb1d868971b50f93eaeb39f1e15f 5717 less_668-1_amd64.buildinfo
Checksums-Sha256:
 84c63a051999d30deab36131d98345d4277105dadfd5d7c63ffea6a631f498f1 1889 
less_668-1.dsc
 2819f55564d86d542abbecafd82ff61e819a3eec967faa36cd3e68f1596a44b8 649770 
less_668.orig.tar.gz
 5b24942fb8e4352fc22ddff6ccaa61eb978d590fb3eecd26591f5cca8965ab03 195 
less_668.orig.tar.gz.asc
 83e659f43c11ee8591685744cd71e6b99e8cb430224649ac98557068d881e4ce 22332 
less_668-1.debian.tar.xz
 7c59557e392d0bcbd46a2c02a3d0fb0caac2b117c8110dde5cd1f7023b083b65 5717 
less_668-1_amd64.buildinfo
Files:
 5cb46eed210a107b6798ad73359f30b1 1889 text important less_668-1.dsc
 d72760386c5f80702890340d2f66c302 649770 text important less_668.orig.tar.gz
 355fb9223c31dccb4f79a9ee1baddeba 195 text important less_668.orig.tar.gz.asc
 19bacd8440ea36161ab41ca17c73b7a6 22332 text important less_668-1.debian.tar.xz
 d44651e9068edf4ed830a0eecba0c05b 5717 text important less_668-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQHFBAEBCgAvFiEEVkf/m69krCYf+z+G6e1ngbRVCQ4FAmfyGBERHG1pbGFuQGRl
Ymlhbi5vcmcACgkQ6e1ngbRVCQ4klQv/dvkbRqPVICogzL0VF0D2D7upLA7DBAJe
wosz+EjJxiCKTscsTqZvR4BDZanW5bTsQLHwA9K0wdh56dMX1YGmV/hyde5A3dGZ
NdNdazskEiQMovGoUT7fDFoh3GMad5lariuSLYeTAzq2qoOrPiyEIyzAtWqsEecn
R5O/SDqZuWX0xSlH0pRofgDg+l6qTBPxD+Cz8IhYrSYopU/CLBpko/PHS5fJYQF7
nE8mZC65qKPhnciiT8tsPKEU4aTQt6KBocw0uq13YRNg46pYmUolMGnR+REg5vPo
1NN+cq/2cFQ+FA8qX3cv1gTE25hzJaeDrSQtHIJi2nDO1KHFH7T19PouXzrEnBRz
I9uRlO2i6AuzzU+AEn70fjTi8v9HAQDIunSkq2wVyxWuOHA+NgJ7uH81zd46ZEh4
fJdZyYexnJS1PE3k8S0CT8JkpfuJnzc1I3fnY/RtwBZiBk2MfcoFNY8xsJc7ZMpS
9BHwY+g9eUxfX3fzgvt+w2nGcCSpcp9k
=Tnhu
-----END PGP SIGNATURE-----

Attachment: pgp8AnSZIBBYE.pgp
Description: PGP signature


--- End Message ---

Reply via email to