Your message dated Sun, 11 May 2025 09:58:36 +0000
with message-id <[email protected]>
and subject line Bug#1104974: Removed package(s) from unstable
has caused the Debian Bug report #696674,
regarding chronicle: cache and comments don't play well together
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
696674: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696674
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: chronicle
Version: 4.6-2
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
I think there is a logical problem in the cache handling which makes
it a bit useless in connection with comments.
If I'm reading readBlogEntry() correctly, it
* first tries to read from the cache and returns if it finds the
entry
* otherwise writes the entry to the cache, unless the entry has
comments and it's "new" enough.
So for a new posting what happens is:
- - it's not found in the cache
- - it gets written to the cache since obviously (!) it has no comments
yet
- - later a comment might be written
- - but this will never appear after a rebuild since from now on the
cached version is returned
Something like the attached patch seems to improve the situation; the
idea is simply that entries are never cached if they are "new",
independent of the fact if they have comments or not.
Cheers,
gregor
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJQ2cgLAAoJELs6aAGGSaoGPDMP/0xyhF9jnYsW4N5h5QQK8rjW
KqJFlcu6t0atcFJ81PvlDpjTQJmZa0Gp3xPcvPIWd2shkLCoLH2UjiOIxnKjtjFg
Jhy1M3OW9AyJxw0Q3sJ2TO9nJM71VNub3CZGDo8hDP6WQAMB5pBwjUjIAcmUHc2+
pV185YI7GOYtkdbQx9KUIkb52yOSKAbB0hgJ7v8JWTwbJmPiszhjIUfegVtWs6He
viGvSL6uH1BuR8Y6q3feah1yeQNQ6LJXs3vmVsEl7JymW6MRYvrFrrthUHLa2Q3v
Aw9lnvEH0YB+Kb3WxxE1jOR/oYRgOCRVCgira0xU7VcZhlpXh2qjoW5Ym9Goka0W
sTG3nm25JRi+4g7J20M98V07i4sQuaR2LVfwS0+mQRKQ9EHztAmOYDgnNpGd0P+J
wcfVvr0Qn8psaKg5mw38mzIkVKfGy4peXSZYWAs06ZVHvQsQU4wkTjEgoxxhtycX
KFyWyQDasn4MTT0gZqLJ+iO/eulUg9b23yvmJrLdozSIOTBJnzoW1QmguzAd9hyJ
I3froWldvPKM8ljSjE2k19zdtucWhSxhEedaYIV9yRtuemSVM5UTQ5BBzdhHytMu
zkZ2qWKfqzNaKueoiPa4Vpx6ql3GKuaOthe8f2QkDk2WQdsQB4ksIXoA1CG+1g1F
2xrkqR3ZJ6LxeMGaEd2s
=QUdR
-----END PGP SIGNATURE-----
--- unpacked/usr/bin/chronicle 2011-05-15 20:15:12.000000000 +0200
+++ /usr/bin/chronicle 2012-12-25 16:12:36.000000000 +0100
@@ -2527,27 +2529,21 @@
{
my $update = 1;
+ #
+ # The number of seconds past the epoch of today and the
+ # date the blog is supposed to be published is used.
+ #
+ my $time = str2time( $entry{ 'date' } );
+ my $today = time;
- if ( ( $entry{ 'comment_count' } ) &&
- ( $entry{ 'comment_count' } ) > 0 )
- {
-
- #
- # The number of seconds past the epoch of today and the
- # date the blog is supposed to be published is used.
- #
- my $time = str2time( $entry{ 'date' } );
- my $today = time;
-
- #
- # The number of days that should be allowd.
- #
- my $days = $CONFIG{ 'comment-days' } * 60 * 60 * 24;
+ #
+ # The number of days that should be allowd.
+ #
+ my $days = $CONFIG{ 'comment-days' } * 60 * 60 * 24;
- if ( ( $time + $days ) > $today )
- {
- $update = 0;
- }
+ if ( ( $time + $days ) > $today )
+ {
+ $update = 0;
}
#
@@ -2555,7 +2551,6 @@
#
# We don't store in the cache if:
#
- # * The entry has comments.
# * The entry is "recent", as set by "--comment-days".
#
#
--- End Message ---
--- Begin Message ---
Version: 4.6-2.1+rm
Dear submitter,
as the package chronicle has just been removed from the Debian archive
unstable we hereby close the associated bug reports. We are sorry
that we couldn't deal with your issue properly.
For details on the removal, please see https://bugs.debian.org/1104974
The version of this package that was in Debian prior to this removal
can still be found using https://snapshot.debian.org/.
Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.
This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].
Debian distribution maintenance software
pp.
Thorsten Alteholz (the ftpmaster behind the curtain)
--- End Message ---
