Your message dated Tue, 09 Sep 2025 15:05:50 +0000
with message-id <[email protected]>
and subject line Bug#991343: fixed in mojoshader
0.0~hg1314+git20250606.93d9d45+dfsg-1
has caused the Debian Bug report #991343,
regarding mojoshader: FTBFS if libsdl2-dev is installed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
991343: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991343
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: mojoshader
Version: 0.0~hg1314+dfsg-1
Severity: important
Tags: ftbfs bullseye sid patch
I tried building mojoshader in a non-minimal environment to check whether
it was broken by the new version of spirv-tools. In particular, I have
libsdl2-dev installed.
My build failed with this error:
[ 80%] Linking C executable finderrors
/usr/bin/cmake -E cmake_link_script CMakeFiles/finderrors.dir/link.txt
--verbose=1
/usr/lib/ccache/cc -g -O2 -ffile-prefix-map=/srv/tmp/smcv/mojoshader=.
-fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic
-Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -rdynamic
CMakeFiles/finderrors.dir/utils/finderrors.c.o
CMakeFiles/mojoshader.dir/mojoshader.c.o
CMakeFiles/mojoshader.dir/mojoshader_common.c.o
CMakeFiles/mojoshader.dir/mojoshader_opengl.c.o
CMakeFiles/mojoshader.dir/mojoshader_metal.c.o
CMakeFiles/mojoshader.dir/mojoshader_d3d11.c.o
CMakeFiles/mojoshader.dir/mojoshader_vulkan.c.o
CMakeFiles/mojoshader.dir/profiles/mojoshader_profile_arb1.c.o
CMakeFiles/mojoshader.dir/profiles/mojoshader_profile_bytecode.c.o
CMakeFiles/mojoshader.dir/profiles/mojoshader_profile_d3d.c.o
CMakeFiles/mojoshader.dir/profiles/mojoshader_profile_hlsl.c.o
CMakeFiles/mojoshader.dir/profiles/mojoshader_profile_glsl.c.o
CMakeFiles/mojoshader.dir/profiles/mojoshader_profile_metal.c.o
CMakeFiles/mojoshader.dir/profiles/mojoshader_profile_spirv.c.o
CMakeFiles/mojoshader.dir/profiles/mojoshader_profile_common.c.o
CMakeFiles/mojoshader.dir/mojoshader_effects.c.o
CMakeFiles/mojoshader.dir/mojoshader_compiler.c.o
CMakeFiles/mojoshader.dir/mojoshader_preprocessor.c.o
CMakeFiles/mojoshader.dir/mojoshader_lexer.c.o
CMakeFiles/mojoshader.dir/mojoshader_assembler.c.o -o finderrors -lm
/usr/bin/ld: CMakeFiles/finderrors.dir/utils/finderrors.c.o: in function
`do_file':
./obj-x86_64-linux-gnu/./utils/finderrors.c:67: undefined reference to
`SDL_PollEvent'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./utils/finderrors.c:72: undefined
reference to `SDL_GL_SwapWindow'
/usr/bin/ld: CMakeFiles/finderrors.dir/utils/finderrors.c.o: in function
`lookup':
./obj-x86_64-linux-gnu/./utils/finderrors.c:25: undefined reference to
`SDL_GL_GetProcAddress'
/usr/bin/ld: CMakeFiles/finderrors.dir/utils/finderrors.c.o: in function `main':
./obj-x86_64-linux-gnu/./utils/finderrors.c:238: undefined reference to
`SDL_Init'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./utils/finderrors.c:240: undefined
reference to `SDL_GL_LoadLibrary'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./utils/finderrors.c:242: undefined
reference to `SDL_CreateWindow'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./utils/finderrors.c:244: undefined
reference to `SDL_GL_CreateContext'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./utils/finderrors.c:268: undefined
reference to `SDL_Quit'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./utils/finderrors.c:243: undefined
reference to `SDL_GetError'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./utils/finderrors.c:239: undefined
reference to `SDL_GetError'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./utils/finderrors.c:241: undefined
reference to `SDL_GetError'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./utils/finderrors.c:245: undefined
reference to `SDL_GetError'
collect2: error: ld returned 1 exit status
The attached patch fixes this by taking a change from the new upstream git
repository <https://github.com/icculus/mojoshader>, and using it to replace
part of CMakeLists.patch.
smcv
>From 96469b21e1420ca38cdc7d5d332f1c05dd1b4666 Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Wed, 21 Jul 2021 10:16:50 +0100
Subject: [PATCH] Add patch from upstream to link to SDL if and only if
required
The previous version of CMakeLists.patch unconditionally disabled
linking of finderrors to ${SDL2}, which avoided FTBFS when SDL is not
available, but caused FTBFS when SDL *is* available.
Now, finderrors is linked to SDL if and only if it was detected, so that
the build will succeed in environments with or without SDL.
---
debian/patches/CMakeLists.patch | 13 ++-------
...ke-Don-t-fail-if-SDL2-can-t-be-found.patch | 29 +++++++++++++++++++
debian/patches/series | 1 +
3 files changed, 32 insertions(+), 11 deletions(-)
create mode 100644 debian/patches/cmake-Don-t-fail-if-SDL2-can-t-be-found.patch
diff --git a/debian/patches/CMakeLists.patch b/debian/patches/CMakeLists.patch
index c9b8882..80666ab 100644
--- a/debian/patches/CMakeLists.patch
+++ b/debian/patches/CMakeLists.patch
@@ -1,5 +1,5 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 0d8b4e6..d279707 100644
+index d7a74de..424da2a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,5 +1,6 @@
@@ -54,16 +54,7 @@ index 0d8b4e6..d279707 100644
IF(EFFECT_SUPPORT)
TARGET_SOURCES(mojoshader PRIVATE
mojoshader_effects.c
-@@ -229,7 +228,7 @@ ENDIF(SDL2)
-
- IF(COMPILER_SUPPORT)
- ADD_EXECUTABLE(finderrors utils/finderrors.c)
-- TARGET_LINK_LIBRARIES(finderrors mojoshader ${SDL2} ${LIBM} ${LOBJC} ${CARBON_FRAMEWORK})
-+ TARGET_LINK_LIBRARIES(finderrors mojoshader ${LIBM} ${LOBJC} ${CARBON_FRAMEWORK})
- IF(SDL2)
- SET_SOURCE_FILES_PROPERTIES(
- utils/finderrors.c
-@@ -257,6 +256,30 @@ IF(COMPILER_SUPPORT)
+@@ -259,6 +258,30 @@ IF(COMPILER_SUPPORT)
TARGET_LINK_LIBRARIES(mojoshader-compiler mojoshader ${LIBM} ${LOBJC} ${CARBON_FRAMEWORK})
ENDIF(COMPILER_SUPPORT)
diff --git a/debian/patches/cmake-Don-t-fail-if-SDL2-can-t-be-found.patch b/debian/patches/cmake-Don-t-fail-if-SDL2-can-t-be-found.patch
new file mode 100644
index 0000000..cb71769
--- /dev/null
+++ b/debian/patches/cmake-Don-t-fail-if-SDL2-can-t-be-found.patch
@@ -0,0 +1,29 @@
+From: "Ryan C. Gordon" <[email protected]>
+Date: Mon, 28 Jun 2021 18:08:33 -0400
+Subject: cmake: Don't fail if SDL2 can't be found.
+
+Origin: upstream, commit:1e1b595dcdd22d65602d94a528f817860a256bf3
+---
+ CMakeLists.txt | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 0d8b4e6..d7a74de 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -229,12 +229,14 @@ ENDIF(SDL2)
+
+ IF(COMPILER_SUPPORT)
+ ADD_EXECUTABLE(finderrors utils/finderrors.c)
+- TARGET_LINK_LIBRARIES(finderrors mojoshader ${SDL2} ${LIBM} ${LOBJC} ${CARBON_FRAMEWORK})
+ IF(SDL2)
++ TARGET_LINK_LIBRARIES(finderrors mojoshader ${SDL2} ${LIBM} ${LOBJC} ${CARBON_FRAMEWORK})
+ SET_SOURCE_FILES_PROPERTIES(
+ utils/finderrors.c
+ PROPERTIES COMPILE_FLAGS "-DFINDERRORS_COMPILE_SHADERS=1"
+ )
++ ELSE(SDL2)
++ TARGET_LINK_LIBRARIES(finderrors mojoshader ${LIBM} ${LOBJC} ${CARBON_FRAMEWORK})
+ ENDIF(SDL2)
+ ENDIF(COMPILER_SUPPORT)
+
diff --git a/debian/patches/series b/debian/patches/series
index d042827..319683f 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
+cmake-Don-t-fail-if-SDL2-can-t-be-found.patch
CMakeLists.patch
perl-script.patch
--
2.32.0
--- End Message ---
--- Begin Message ---
Source: mojoshader
Source-Version: 0.0~hg1314+git20250606.93d9d45+dfsg-1
Done: Yangfl <[email protected]>
We believe that the bug you reported is fixed in the latest version of
mojoshader, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Yangfl <[email protected]> (supplier of updated mojoshader package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 06 Sep 2025 23:47:24 +0800
Source: mojoshader
Architecture: source
Version: 0.0~hg1314+git20250606.93d9d45+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Yangfl <[email protected]>
Changed-By: Yangfl <[email protected]>
Closes: 976553 991343 1097408 1113292
Changes:
mojoshader (0.0~hg1314+git20250606.93d9d45+dfsg-1) unstable; urgency=medium
.
* New upstream snapshot
* Fix FTBFS on architectures where char is unsigned
(Closes: #976553)
* Require libsdl2-dev (Closes: #991343)
* Fix FTBFS with GCC-15 (Closes: #1097408)
* Fix FTBFS with CMake 4 (Closes: #1113292)
* Bump Standards-Version to 4.7.2
Checksums-Sha1:
11cf78e458c5f5f226d96db0a84559ff3c613fdf 2269
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg-1.dsc
2e4c77461e4e977a3810ad0d7cdef77ed853452e 346056
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg.orig.tar.xz
f6d12ac757e527ccb2ee359ef9e1956aefcf923d 5688
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg-1.debian.tar.xz
c01738b95b0af400e77f6aa08f4667197d34f7ad 12562
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg-1_amd64.buildinfo
Checksums-Sha256:
0c4c227ca3ffebbcc6e20b8930d3cb13f3933a4c69df7469193efff6a0768d6e 2269
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg-1.dsc
2d2253227be5654a49145fa9fd1013524aaf1378d2dd512dc09ab7787e02d132 346056
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg.orig.tar.xz
9baecf03728d85f5dfbdecfc6bca607e70f0cb243d20904d73334e88c738cf30 5688
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg-1.debian.tar.xz
db10d3f881fb446c1fc7cc892aad7a71de924abb2ae812f47721837bb4f4cfdb 12562
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg-1_amd64.buildinfo
Files:
b31d0c55b0b48e396a818548ddba5942 2269 libs optional
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg-1.dsc
f391040b9bf060e7a2142be4858ab410 346056 libs optional
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg.orig.tar.xz
6d0dbf5136d30ef32eff0b859e046826 5688 libs optional
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg-1.debian.tar.xz
b418096c556aa1284989d7b954fc1c6e 12562 libs optional
mojoshader_0.0~hg1314+git20250606.93d9d45+dfsg-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmjAOJYACgkQwpPntGGC
Ws4k5A/+ILeaFZXZJIlehrMTjoG2ymbr+958qnxEBzopT6I7lVuuTAkQ06rBFyuy
F6gpAHSjG+pbwn3oblOeJMf66Sk4miSpUBc5bRe9Fq/SwxxN9DWU/+8+aXGC9UoT
6NVWbVi5+G0ggoGmEFJUCl3p3qMtqNieIKITZR9jWcUgyxkkYD7wzkQ0c5BdrUIZ
xzTKpKAYoCLmqQwH4INhNyHmFbwREk/CrIlEkJPtIp4oq2GtRrToO1wHVA1X+teE
CTQOUVkDr3mUncxuoV0j3ZTaRKw67xSmdRakMRNzvH4eMOV6vLrU4sJbMQ86g/8M
TMIXatllMYvKnDrVbA0MDBq3fBukiKNHchZhfiv5TtF5i4TY5POfpqtOYL5i33Ml
YuMG/ozBqaVfor4GILgrpsVihMhE5ZwBGDusntSXElwFfOv9RstsJ6Th3deIxs8Z
NEmcI3z7GEagIvrNiQ+zsA6RDsZON9lqme1ro6RIqS+72bK1Y3CV9Ls7gP9LXKgo
yaS7xdKEAWogkwBNT08iltwNGL47EmG6ZzAnsAqabB0tBNiwjJTigzHMKVXxL5WW
GNmqwMP1vZvi0JKfYGdeAQa0zBoh/QIicHF7FqvwGaTEDoX0Cbd4+fbyPy+Tz7LA
t9qy5jy1my5tjz2kqcneKHy433VB3BYsSU4FcnwRYmBI4ox0NeM=
=XvM5
-----END PGP SIGNATURE-----
pgpEJtZkATTAq.pgp
Description: PGP signature
--- End Message ---
