Your message dated Thu, 13 Nov 2025 05:18:55 +0000
with message-id <[email protected]>
and subject line Bug#1120433: fixed in gtkgreet 0.8-2
has caused the Debian Bug report #1120433,
regarding gtkgreet: Allows unauthenticated arbitrary commands at login
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1120433: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1120433
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gtkgreet
Version: gtkgreet_0.8-1
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]
Dear Maintainer,
This greeter allows unauthenticated arbitrary commands to be executed from
the login screen as the greeter user by simply typing them into the drop down
box.
Although this greeter does allow for loading a list of valid commands from
/etc/greetd/environments, loading that file does not disable the ability to
input arbitrary commands. Rather, it just adds them to a drop down of commands
to be potentially executed on the login screen in addition to the ability to
add arbitrary commands.
As this is a security hole that could potentially allow for exploitation of
the running system, I've made a patch that introduces a command line argument
to disable the ability to input those arbitrary commands. Only allowing the
existing commands from /etc/greetd/environments to be used.
Rationale for making the patch: Unfortunately due to my use-case for one of
my systems, I'm not able to avoid using this package as it is one of the few
packages that actually allows that system to work as intended. sddm, gdm,
lightdm, etc. All of them fail to work properly with the gamescope package
(Which was removed from trixie, but is still in sid.) which segfaults when used
under those display managers. greetd was the only login manager that would
allow gamescope to work as intended while retaining a user login requirement,
and gamescope was a hard dependency for my use-case. (Avoiding gamescope would
require a massive rewrite of another app (opengamepadui) which is not currently
available in Debian, but I've got working regardless.)
-- System Information:
Debian Release: 12.12
APT prefers oldstable-updates
APT policy: (500, 'oldstable-updates'), (500, 'oldstable-security'), (500,
'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64
Kernel: Linux 6.1.0-40-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Description: allow-disabling-custom-commands
Allows disabling the text entry for the command box. Limiting the commands that
can be run to the values in the environments file.
Author: Patrick Hibbs <[email protected]>
---
--- gtkgreet-0.8/gtkgreet/gtkgreet.h 2025-11-08 14:51:05.056868116 -0500
+++ gtkgreet-0.8/gtkgreet/gtkgreet.h 2025-11-08 14:51:33.693375535 -0500
@@ -27,6 +27,7 @@
gboolean use_layer_shell;
#endif
char* command;
+ gboolean disable_custom_commands;
char* selected_command;
enum QuestionType question_type;
--- gtkgreet-0.8/gtkgreet/main.c 2025-11-08 14:47:28.017040230 -0500
+++ gtkgreet-0.8/gtkgreet/main.c 2025-11-08 14:50:36.988371232 -0500
@@ -19,6 +19,8 @@
static gboolean use_layer_shell = FALSE;
#endif
+static gboolean disable_custom_commands = FALSE;
+
static GOptionEntry entries[] =
{
@@ -28,6 +30,7 @@
{ "command", 'c', 0, G_OPTION_ARG_STRING, &command, "Command to run",
"sway"},
{ "background", 'b', 0, G_OPTION_ARG_STRING, &background, "Background image
to use", NULL},
{ "style", 's', 0, G_OPTION_ARG_FILENAME, &style, "CSS style to use", NULL },
+ { "disable-custom-commands", 'x', 0, G_OPTION_ARG_NONE,
&disable_custom_commands, "Disable custom command entry", NULL},
{ NULL }
};
@@ -142,6 +145,7 @@
gtkgreet->use_layer_shell = use_layer_shell;
#endif
gtkgreet->command = command;
+ gtkgreet->disable_custom_commands = disable_custom_commands;
if (background != NULL) {
gtkgreet->background = gdk_pixbuf_new_from_file(background, &error);
--- gtkgreet-0.8/gtkgreet/window.c 2025-11-08 14:54:53.492927324 -0500
+++ gtkgreet-0.8/gtkgreet/window.c 2025-11-08 15:10:46.630013038 -0500
@@ -113,7 +113,7 @@
gtk_container_add(GTK_CONTAINER(ctx->input_box), question_box);
if (type == QuestionTypeInitial) {
- ctx->command_selector = gtk_combo_box_text_new_with_entry();
+ ctx->command_selector = (gtkgreet->disable_custom_commands == FALSE) ?
gtk_combo_box_text_new_with_entry() : gtk_combo_box_text_new();
gtk_widget_set_name(ctx->command_selector, "command-selector");
gtk_widget_set_size_request(ctx->command_selector, 384, -1);
config_update_command_selector(ctx->command_selector);
--- End Message ---
--- Begin Message ---
Source: gtkgreet
Source-Version: 0.8-2
Done: Maytham Alsudany <[email protected]>
We believe that the bug you reported is fixed in the latest version of
gtkgreet, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Maytham Alsudany <[email protected]> (supplier of updated gtkgreet package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 13 Nov 2025 13:03:37 +0800
Source: gtkgreet
Architecture: source
Version: 0.8-2
Distribution: unstable
Urgency: medium
Maintainer: Maytham Alsudany <[email protected]>
Changed-By: Maytham Alsudany <[email protected]>
Closes: 1120433
Changes:
gtkgreet (0.8-2) unstable; urgency=medium
.
[ Patrick Hibbs ]
* Add patch to allow disabling custom commands (Closes: #1120433)
.
[ Maytham Alsudany ]
* d/control: Bump Standards-Version to 4.7.2 (no changes)
* Update my maintenance address
Checksums-Sha1:
efc456d868e0eeb414c91433e8577a8fae3dfe5b 1894 gtkgreet_0.8-2.dsc
e9fe24b4adc8138a6370b624ddc0e29ff6d48f3a 2996 gtkgreet_0.8-2.debian.tar.xz
2ab3084a4648cc486afa1e38597ecc0a9a2aa5b5 14644 gtkgreet_0.8-2_amd64.buildinfo
Checksums-Sha256:
d50f6b6a47e7bcda87e8d7264334de20e9c4916c8c278b4f5bad994f032c81e0 1894
gtkgreet_0.8-2.dsc
d96b6abb226a0de9682e2bc4ec6a82da3adc8caa3b7eda1242309c877c54674c 2996
gtkgreet_0.8-2.debian.tar.xz
adaccd475bfee40b4cfcb23e991846496bd68721801d51828a5355a9e85fa551 14644
gtkgreet_0.8-2_amd64.buildinfo
Files:
9123cac7a9402e14ceb51466607cb270 1894 utils optional gtkgreet_0.8-2.dsc
193ae3d34bd240f6a1c1d1676be9742b 2996 utils optional
gtkgreet_0.8-2.debian.tar.xz
372309950e637dec31079ade661228df 14644 utils optional
gtkgreet_0.8-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEESl/RzRFQh8wD3DXB1ZeJcgbF8H8FAmkVZw0ACgkQ1ZeJcgbF
8H/Otg//S5gk+S6tk/DB3/yzp2mfiSQNZdIoDmY1QR/oErT6eEB5jTZCEEvlnJ7P
SCb3NpyRbkXfwggdalaXVhQVx8o18sgBp2jd6DInFOL0Ss/Q0ZW/URkbl0fuATI8
vn9mI2niQKrzFhLUXtOx3RQS5fCg4KbssHH91E0rbyenXFH+0lNHu982DNYvSWRz
GLY/me26luJ6AskLuBt5xjebJgA9RRGXBBGRN+WcY0Kg5f7bA38WbLayiTTi6aAJ
ZHFy6MjVt8jrtmmxyZRzEcBnNbWubBEqv2Pa9V/RCKjBo34s2kb5wjiBxY8iCGa4
/hKnuEKCG6jW0+EqV83LERiIK47Y2MMVawZLVI/dxTjbsmDZGbU7MZM/zddpzQQv
y+UBighlkSu5gEmNAihsE4J9OukuRgaYe2SjbdX9Ir5khynbjEj4mnuwMuNEvLOI
EVliOsFJTkhARs3Z0GB+qgiziinvomOkDvLjjnv/KiCh6WEYotNLCEqAgqA8VAv8
ydCDgocB8ayfiY+dm/ohbbKHN6UVV6kvdFYjOHYZyVGgv7W2DJ1fFfG98+S47xkD
GqHCV2fz5WeY47iQsboVbXqOhiaJxqkM3lG+8QULj/2uhv1B7lO0aYw/euCxLlDb
PBMu/oY1/lBPDsLHuS4r/wRHfcOQRXirpPF+tvtRrZq009Cs6VA=
=+dHY
-----END PGP SIGNATURE-----
pgpSNAnUsqgzd.pgp
Description: PGP signature
--- End Message ---
