Your message dated Tue, 09 Dec 2025 22:13:37 +0000
with message-id <[email protected]>
and subject line Bug#1119579: fixed in sumatra 1.0.36+ds-3
has caused the Debian Bug report #1119579,
regarding sumatra: please build using the default build flags
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1119579: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1119579
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: sumatra
Version: 1.0.36+ds-2
User: [email protected]
Usertags: hardening-buildflags
sumatra is not currently using the default build flags set by
dpkg-buildflags(1).
The default flags are chosen for multiple reasons including security,
performance, reproducibility, adherence to standards, and error handling.
Please make sure that sumatra builds using the default build flags. blhc(1p)
and hardening-check(1) can be used to confirm that the issue is fixed.
In the general case, packages honoring CFLAGS, LDFLAGS, and other
similar environment variables get the default build flags for free
without the need for any work on the maintainer side. In the case of
sumatra, the flags are either ignored or overridden.
The most common reasons for this are:
Hand-written Makefiles
----------------------
Some upstream Makefiles either override the values of variables such as
CFLAGS and similar or do not use them at all. See:
https://wiki.debian.org/HardeningWalkthrough#Handwritten_Makefiles
Misconfigured build systems
---------------------------
If the upstream code uses autotools, CMake, or other popular build
systems, it usually requires no further modifications. If might however
be that some variables are hardcoded in some way.
In this CMake snippet, the value of CXXFLAGS is overwritten with "-O2":
set(CMAKE_CXX_FLAGS "-O2")
If the intention is to append to CXXFLAGS, one should use the following
instead:
set(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}")
See #655870 for a similar autotools example.
Very old debhelper usage
------------------------
Packages not using dh(1), or those using a debhelper compatibility level
less than 9, need to manually include /usr/share/dpkg/buildflags.mk in
order for the dpkg-buildflags variables to be set:
https://wiki.debian.org/Hardening#dpkg-buildflags
Flags hardcoded in debian/rules (either voluntarily or not)
-----------------------------------------------------------
Some packages voluntarily hardcode the values of CFLAGS and friends in
debian/rules, ignoring the defaults set by dpkg-buildflags(1).
Others attempt to append to the variables, but end up accidentally
overriding the defaults:
#!/usr/bin/make -f
export CFLAGS += -pipe -fPIC -Wall
%:
dh $@
Debhelper only sets CFLAGS if it is not set yet. In the example above,
when dh is invoked the value of CFLAGS is "-pipe -fPIC -Wall", hence the
hardened defaults are not used. The right way to append to CFLAGS is
using DEB_CFLAGS_MAINT_APPEND instead, as documented in
dpkg-buildflags(1).
For a detailed analysis of this issue, see:
https://people.debian.org/~ema/nocflags_paper.pdf (eprint: hal-05334704)
--- End Message ---
--- Begin Message ---
Source: sumatra
Source-Version: 1.0.36+ds-3
Done: Étienne Mollier <[email protected]>
We believe that the bug you reported is fixed in the latest version of
sumatra, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Étienne Mollier <[email protected]> (supplier of updated sumatra package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 09 Dec 2025 22:20:36 +0100
Source: sumatra
Architecture: source
Version: 1.0.36+ds-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team
<[email protected]>
Changed-By: Étienne Mollier <[email protected]>
Closes: 1119579
Changes:
sumatra (1.0.36+ds-3) unstable; urgency=medium
.
* Team upload.
.
[ Andreas Tille ]
* Remove Tim Booth <[email protected]> since address is bouncing
(Thank you for your work on this package, Tim)
.
[ Étienne Mollier ]
* buildflags.patch: new: propagate build flags. (Closes: #1119579)
* d/patches/*: normalise Last-Update timestamp.
* d/watch: convert to v5 watch file.
* d/control: drop redundant Rules-Requires-Root: no.
* d/control: declare compliance to standards version 4.7.2.
Checksums-Sha1:
6a76df30a6ef2984560e70a532eb536aaf549b0a 2151 sumatra_1.0.36+ds-3.dsc
6a1864f65c53467dec56f7e65f4696239a1f9e25 12272
sumatra_1.0.36+ds-3.debian.tar.xz
Checksums-Sha256:
d13c6d092e95c9255c15f6d1539a1a37949d89a4e3f9b92bbceae7cd238ae45f 2151
sumatra_1.0.36+ds-3.dsc
c2a7306e51459ee63e03db222b1e3b6933a768a6e558b5de094638260524700f 12272
sumatra_1.0.36+ds-3.debian.tar.xz
Files:
dac7306af2bdd58fd94475f9c1afe6f4 2151 science optional sumatra_1.0.36+ds-3.dsc
a3e5fa1b312efcb9a04775b1d253653d 12272 science optional
sumatra_1.0.36+ds-3.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQJIBAEBCgAyFiEEj5GyJ8fW8rGUjII2eTz2fo8NEdoFAmk4lX8UHGVtb2xsaWVy
QGRlYmlhbi5vcmcACgkQeTz2fo8NEdqhBw/8DkZt0v2Oe/eSXnMbH53qRI8pCdEI
Ykcr8QVfHJI5ioLMqojRfCMnV8xFHRXp6Sk6rDRgpPwmfmSBbtvMwR5iQb3Pt59N
75cenRMA6u1UB0PadKoft4ReZPlbqO/SOyGzCZ0rf++VBYtcOetQO0OGGlIEjOqN
U8PUgD3Umd0EDPPIMLoSmHh45Ifysn/pjkOHfBVCetbak2esIyXhacxZAzm6ydrv
VsXnrn9TJQ6k5nQK3LB2//BBNoZZS9Wff+J9rk8X+vr3GGPkWok42md2vfCqKjoW
1YGevaOqUxf1ag4TfT6X5GsDX8HonjSpIMV+57diC538kz8nKiwDaUBKIz0G+vMO
jevlqRX8jFWNjxkSUgohXlotIjA/oSP4gDp7AqNlQ7ncSV1xdhFIgjpgruEdl2IM
p7jLmfJz3bULsKLN/MmDHAAO75MTG8kSFT1EltErTNTeKDv9PSmw/TwtXYiYpUl+
cyfr5GYggMo1ZINWqc96TQ/5bm84AeO4dgxncEX2+XSveeBMpGmew7W0FGLe+C5t
3aaUJ1nsqeGc+bgwQlUj7Jc3wbfdnBeww2RUmGxFjXTS75wwkt0tnnCZssHLlrCl
HSpb3jF8sd0aYPGRNiKMesTBVdYGNAVzzyAsymi3JoUhD03sWVJoSmXtDhSv1hlm
U/MmqpAEu0whCNk=
=sEfK
-----END PGP SIGNATURE-----
pgpylwPdWstAc.pgp
Description: PGP signature
--- End Message ---
