Your message dated Thu, 18 Dec 2025 16:49:51 +0100
with message-id <[email protected]>
and subject line Re: Bug#750123: steghide: FTBFS with clang instead of gcc
has caused the Debian Bug report #750123,
regarding steghide: FTBFS with clang instead of gcc
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
750123: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750123
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: steghide
Severity: minor
Tags: patch
User: [email protected]
Usertags: clang-ftbfs

Hello,

Using the rebuild infrastructure, your package fails to build with clang 
(instead of gcc).
See build logs here: 
http://clang.debian.net/logs/2014-01-14/steghide_0.5.1-9_unstable_clang.log

Thanks,
Alexander


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.13-1-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- steghide-0.5.1/src/BmpFile.cc	2003-09-28 11:30:30.000000000 -0400
+++ steghide-0.5.1-my/src/BmpFile.cc	2014-06-01 15:29:32.484573036 -0400
@@ -214,10 +214,10 @@
 		// create reservoir - for every i reservoir[i] contains the sample values that are neighbourss of
 		// the sample value with label i and have a lower label (and have already been found)
 		// This is necessary to use collapsing trees together with bucket sort (without huge increase in memory usage)
-		std::vector<BmpRGBSampleValue*> reservoir[svs.size()] ;
+		std::vector<BmpRGBSampleValue*> *reservoir = static_cast<std::vector<BmpRGBSampleValue*> *>(alloca(sizeof(std::vector<BmpRGBSampleValue*>) * svs.size()));
 
 		// neighbours sorted by distance (for the current source sample value)
-		std::vector<BmpRGBSampleValue*> neighbours_byd[r + 1] ;
+		std::vector<BmpRGBSampleValue*> *neighbours_byd = static_cast<std::vector<BmpRGBSampleValue*> *>(alloca(sizeof(std::vector<BmpRGBSampleValue*>) * (r + 1)));
 
 		for (std::vector<SampleValue*>::const_iterator srcsvit = svs.begin() ; srcsvit != svs.end() ; srcsvit++) {
 			BmpRGBSampleValue* srcsv = (BmpRGBSampleValue*) (*srcsvit) ;

--- End Message ---
--- Begin Message ---
On Tue, 10 Jun 2014 21:19:33 +0200 Ola Lundqvist <[email protected]> wrote:
> I have looked a little more into the patch. I see that it is a way to
> allocate a dynamic size array. Is there any specific reason why clang does
> not support this way of writing? I mean the code is really much neater when
> written the way it is instead of the quite lengthy update you propose.
> 
> I just want to ensure that this is not something that should be changed in
> clang instead. :-)

Indeed, the issue vanished with clang 3.9.1.

Compare
https://clang.debian.net/status.php?version=3.8.1&key=NON-POD
to
https://clang.debian.net/status.php?version=3.9.1&key=NON-POD

Closing this bug therefore.

Sven

-- 
GPG Fingerprint
3DF5 E8AA 43FC 9FDF D086 F195 ADF5 0EDA F8AD D585

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---

Reply via email to