Your message dated Wed, 04 Feb 2026 15:26:56 +0000
with message-id <[email protected]>
and subject line Bug#1119473: fixed in lpr 1:2008.05.17.4
has caused the Debian Bug report #1119473,
regarding lpr: please build using the default build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1119473: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1119473
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: lpr
Version: 1:2008.05.17.3+nmu3.1
User: [email protected]
Usertags: hardening-buildflags

lpr is not currently using the default build flags set by dpkg-buildflags(1).
The default flags are chosen for multiple reasons including security,
performance, reproducibility, adherence to standards, and error handling.

Please make sure that lpr builds using the default build flags. blhc(1p)
and hardening-check(1) can be used to confirm that the issue is fixed.

In the general case, packages honoring CFLAGS, LDFLAGS, and other
similar environment variables get the default build flags for free
without the need for any work on the maintainer side. In the case of
lpr, the flags are either ignored or overridden.

The most common reasons for this are:

Hand-written Makefiles
----------------------
Some upstream Makefiles either override the values of variables such as
CFLAGS and similar or do not use them at all. See:
https://wiki.debian.org/HardeningWalkthrough#Handwritten_Makefiles

Misconfigured build systems
---------------------------
If the upstream code uses autotools, CMake, or other popular build
systems, it usually requires no further modifications. If might however
be that some variables are hardcoded in some way.

In this CMake snippet, the value of CXXFLAGS is overwritten with "-O2":

 set(CMAKE_CXX_FLAGS "-O2")

If the intention is to append to CXXFLAGS, one should use the following
instead:

 set(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}")

See #655870 for a similar autotools example. 

Very old debhelper usage
------------------------
Packages not using dh(1), or those using a debhelper compatibility level
less than 9, need to manually include /usr/share/dpkg/buildflags.mk in
order for the dpkg-buildflags variables to be set:
https://wiki.debian.org/Hardening#dpkg-buildflags

Flags hardcoded in debian/rules (either voluntarily or not)
-----------------------------------------------------------
Some packages voluntarily hardcode the values of CFLAGS and friends in
debian/rules, ignoring the defaults set by dpkg-buildflags(1).

Others attempt to append to the variables, but end up accidentally
overriding the defaults:

 #!/usr/bin/make -f
 export CFLAGS += -pipe -fPIC -Wall

 %:
        dh $@

Debhelper only sets CFLAGS if it is not set yet. In the example above,
when dh is invoked the value of CFLAGS is "-pipe -fPIC -Wall", hence the
hardened defaults are not used. The right way to append to CFLAGS is
using DEB_CFLAGS_MAINT_APPEND instead, as documented in
dpkg-buildflags(1).

For a detailed analysis of this issue, see:
https://people.debian.org/~ema/nocflags_paper.pdf (eprint: hal-05334704)

--- End Message ---
--- Begin Message ---
Source: lpr
Source-Version: 1:2008.05.17.4
Done: Michael Tokarev <[email protected]>

We believe that the bug you reported is fixed in the latest version of
lpr, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Tokarev <[email protected]> (supplier of updated lpr package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 04 Feb 2026 17:31:49 +0300
Source: lpr
Architecture: source
Version: 1:2008.05.17.4
Distribution: unstable
Urgency: medium
Maintainer: Michael Tokarev <[email protected]>
Changed-By: Michael Tokarev <[email protected]>
Closes: 531133 866261 1039255 1119473 1121611
Changes:
 lpr (1:2008.05.17.4) unstable; urgency=medium
 .
   * d/control: Adopt the package (Closes: #1121611)
   * d/control: bump debhelper requirement from 9 to 13
   * d/control: drop reference to long-gone suidmanager
   * d/control: add ${misc:Depends} to Depends and
     ${misc:Pre-Depends} to Pre-Depends
   * d/rules: convert to dh-sequence
   * d/rules: use common build options (with 2 -Wno-error=foo)
     (Closes: #1119473)
   * d/dirs: stop creating dirs unnecessarily
   * d/rules: use chown user:group, not user.group
   * d/lpd.init: test for /etc/default/lpd existence before sourcing it
   * d/lpd.init: remove path to start-stop-daemon in one place
   * d/lpd.init: use `set -e' (Closes: #866261)
   * d/preinst: remove stop action, it is done by dh_installinit
   * d/printcap: comment-out an example entry, make shipped printcap
     a conffile in /etc/printcap instead of example.
     This removes d/lpr.postrm, which unmasks d/postrm and makes it work
     (Closes: #531133)
   * d/postrm: remove /var/spool/lpd/ on purge without questions
   * d/cron.weekly: move log rotation to logrotate.d/lpd
   * d/postinst: remove
     - stop fixing spool files/dirs perms when upgrading from ancient version
     - stop creating /var/log/lp-acct & lp-errs files
     - stop running update-mime when upgrading from really ancient version
   * d/NEWS.Debian: remove, a news item about ancient version
   * d/changelog: remove trailing whitespace
   * d/lpd.service: provide systemd unit file (Closes: #1039255)
Checksums-Sha1:
 7c60359bfc16d50ec61f426def36192b583aead8 1593 lpr_2008.05.17.4.dsc
 bedb89eaff28c02c2c43c31552ddeb5c8a6618b7 81804 lpr_2008.05.17.4.tar.xz
 82dddebbcd5930bd8a85306bc97e073f30c870d3 6041 lpr_2008.05.17.4_source.buildinfo
Checksums-Sha256:
 645f20c570664f3b8ca558de77a6d8578c6e5295923fb28d811f14ca562b53e6 1593 
lpr_2008.05.17.4.dsc
 2f65cb4097b5386ffbce6051785576b7dfb40ac5951e69ca86ed2ad6b564a608 81804 
lpr_2008.05.17.4.tar.xz
 9966aa84bbb415123b91aaf60ba47ac2a54286d3fa944e42b65d3d93fd95d8bf 6041 
lpr_2008.05.17.4_source.buildinfo
Files:
 aca2f454b8179c59bea4a6da72d06e84 1593 net optional lpr_2008.05.17.4.dsc
 ef77031b494f566671f149e645e29494 81804 net optional lpr_2008.05.17.4.tar.xz
 b1470e13a62f368042b95f58461c8760 6041 net optional 
lpr_2008.05.17.4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

wsG7BAEBCgBvBYJpg1lBCRCCqkokOx6UeEcUAAAAAAAeACBzYWx0QG5vdGF0aW9u
cy5zZXF1b2lhLXBncC5vcmfFUPMAJ9OJjwvj/v0hiicTwrX9ZFmaPEtM+gM+MNHW
wBYhBGSqKrUx1WkDNmv++YKqSiQ7HpR4AACCng/+IisMPKaxK1lbib/zrQ91TlGv
2lUn0dcvCInfPl7qsVnPonBrdTO8uKoz9WaD6T/PJnhcla3u/5pohifExsgVzhM/
Puwk9nkvyotUAN6FfEsZNJT+wpvH/VLl0tfUba8Pbniy5bVFnMnN0UzthtlOqdg/
IOJn9j2DScyG2RYnu7KdVt48zQMpqWIIPg27o0WVrwd6pFoo12dRfRTOXR3MCO/o
8bP/vsP6OKaqGCebB7xaaCmXGGJUuzPRiafexPj4AfuS/ojd73ZqcUEMQV1wDyHP
WjuRD7YNCM5xFmAAET+Xl13MhaaV8szFtpU9oraF0j2aqcXSku/HThSUL55gysLZ
QwBqM3VnxN6DxAhnHf4urKg+HHKaBdzt/agLzugOuQanWGH++3SeNOP7YozLDjeq
dQg9S2J+rd5fVOIAL7CK0alF833JeWGX1mriSNZGUSzVbKjOwsp0qIFmeUqIXohZ
dbArokTmwGABaTfuKxEj3rYS+0rvopVkSxhlFLexTrHViUr+ANJQkXCauqfmOpH8
GyjrxonjX1rMg+x5hfBtMiTphItFVR4hoaJEl0Bi9IDLaha5hCd9cy4Dj3KRSMat
tg0s1/Ra8l/GrVEyhBU4p1C0C9FKkBwmkVPgLCqxNcvaf326aszflLrCvuD91aSy
CleM2vpgY8mId66VNFY=
=D6z8
-----END PGP SIGNATURE-----

Attachment: pgpu1ObQNbjw0.pgp
Description: PGP signature


--- End Message ---

Reply via email to