Your message dated Sun, 10 May 2026 14:41:03 +0000
with message-id <[email protected]>
and subject line Bug#1119541: fixed in qiv 3.0.4-0.1
has caused the Debian Bug report #1119541,
regarding qiv: please build using the default build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1119541: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1119541
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: qiv
Version: 3.0.2-1
User: [email protected]
Usertags: hardening-buildflags

qiv is not currently using the default build flags set by dpkg-buildflags(1).
The default flags are chosen for multiple reasons including security,
performance, reproducibility, adherence to standards, and error handling.

Please make sure that qiv builds using the default build flags. blhc(1p)
and hardening-check(1) can be used to confirm that the issue is fixed.

In the general case, packages honoring CFLAGS, LDFLAGS, and other
similar environment variables get the default build flags for free
without the need for any work on the maintainer side. In the case of
qiv, the flags are either ignored or overridden.

The most common reasons for this are:

Hand-written Makefiles
----------------------
Some upstream Makefiles either override the values of variables such as
CFLAGS and similar or do not use them at all. See:
https://wiki.debian.org/HardeningWalkthrough#Handwritten_Makefiles

Misconfigured build systems
---------------------------
If the upstream code uses autotools, CMake, or other popular build
systems, it usually requires no further modifications. If might however
be that some variables are hardcoded in some way.

In this CMake snippet, the value of CXXFLAGS is overwritten with "-O2":

 set(CMAKE_CXX_FLAGS "-O2")

If the intention is to append to CXXFLAGS, one should use the following
instead:

 set(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}")

See #655870 for a similar autotools example. 

Very old debhelper usage
------------------------
Packages not using dh(1), or those using a debhelper compatibility level
less than 9, need to manually include /usr/share/dpkg/buildflags.mk in
order for the dpkg-buildflags variables to be set:
https://wiki.debian.org/Hardening#dpkg-buildflags

Flags hardcoded in debian/rules (either voluntarily or not)
-----------------------------------------------------------
Some packages voluntarily hardcode the values of CFLAGS and friends in
debian/rules, ignoring the defaults set by dpkg-buildflags(1).

Others attempt to append to the variables, but end up accidentally
overriding the defaults:

 #!/usr/bin/make -f
 export CFLAGS += -pipe -fPIC -Wall

 %:
        dh $@

Debhelper only sets CFLAGS if it is not set yet. In the example above,
when dh is invoked the value of CFLAGS is "-pipe -fPIC -Wall", hence the
hardened defaults are not used. The right way to append to CFLAGS is
using DEB_CFLAGS_MAINT_APPEND instead, as documented in
dpkg-buildflags(1).

For a detailed analysis of this issue, see:
https://people.debian.org/~ema/nocflags_paper.pdf (eprint: hal-05334704)

--- End Message ---
--- Begin Message ---
Source: qiv
Source-Version: 3.0.4-0.1
Done: Andreas Tille <[email protected]>

We believe that the bug you reported is fixed in the latest version of
qiv, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Tille <[email protected]> (supplier of updated qiv package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 04 May 2026 15:22:57 +0200
Source: qiv
Architecture: source
Version: 3.0.4-0.1
Distribution: unstable
Urgency: medium
Maintainer: Bart Martens <[email protected]>
Changed-By: Andreas Tille <[email protected]>
Closes: 1119541 1129147 1134500
Changes:
 qiv (3.0.4-0.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * New upstream version
     Closes: #1134500
   * Add missing Build-Depends: libjpeg-dev, libtiff-dev
     Closes: #1129147
   * Maintain qiv in Debian Phototools team
   * Build using the default build flags
     Closes: #1119541
   * d/rules: hardening
   * Standards-Version: 4.7.4 (routine-update)
   * Reorder sequence of d/control VCS fields (cme)
   * Remove Priority field (cme)
   * Remove trailing whitespace in debian/changelog (routine-update)
   * Drop default 'Rules-Requires-Root: no' from d/control (routine-
     update)
Checksums-Sha1:
 424945bef27ec093a7abfd093a2d1c3e00bd11b3 1913 qiv_3.0.4-0.1.dsc
 482a3bae0ec8902cff30221c7a24c4794014970d 143169 qiv_3.0.4.orig.tar.gz
 ead6d3454bf358365c90325f7cd60e6c069e6358 7264 qiv_3.0.4-0.1.debian.tar.xz
 9e0b4387797de8652bd320405210a7eccdb5251f 14946 qiv_3.0.4-0.1_amd64.buildinfo
Checksums-Sha256:
 e36dc17bbea0a1ab12446e50d81525d3e109c7e6544136995542c210433ed1ad 1913 
qiv_3.0.4-0.1.dsc
 6a453e033f9dd50a3ac59e1f5c90efb92ba13f31b82a49e1d599b8ae7a292cea 143169 
qiv_3.0.4.orig.tar.gz
 7067d11114b55ea00288365423d22ef6bc4e706ea9695aa923735305e40d7f98 7264 
qiv_3.0.4-0.1.debian.tar.xz
 c583ea8604346fb93fd9b0c43a2a259f9823386b7847909b795ccdd373c862e9 14946 
qiv_3.0.4-0.1_amd64.buildinfo
Files:
 bdbfc4517cf060893b1ae816689013ca 1913 graphics optional qiv_3.0.4-0.1.dsc
 361c332b610aa51b1baf2f1d36a99c4b 143169 graphics optional qiv_3.0.4.orig.tar.gz
 a11a4bfa291a18d557c06d6c4f629a14 7264 graphics optional 
qiv_3.0.4-0.1.debian.tar.xz
 405d30345a63d8f917b161e167990811 14946 graphics optional 
qiv_3.0.4-0.1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAmn4nx4RHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtEx1RAAlAXeyS4+COYlKFfgK2Gag0vir4ztKZeZ
66YWFxB4Be5KvfrYf8W+Kl0IiX/27/jdGmlkkuoG9j+Ubxn3W/yHMKCKeG8BeDz5
GalsfSe4hpPuLj9V+o1sqLBiTwpAQXwOrRNEuedagCo3d7ElBZZfSISI6MNDythu
xDo+guXxMBiq0FIZYK8R5e/w340fi3QBo5qjEQQquQjKYbj1f+nn3/Rs9Pps7ZPz
NJk6LFN8L0YOF/wwOGm9WHtwhAH7xh+a2ahABi3/iAgX5DdXrrUFEt5nb/eRfT0p
AdW2rgjuSAICCeXBYd2bzZzmjNlEHpBxTlIH5+yZjhaHqWQ3U2BI/xp+KbwqFPd/
CW3bzriQBTuEVeB7gH6wWckc3yjOENwbdd8kXc6iFCIwo/yozbH2RR2rGSxB7iT2
reKnx1nJigie3SpRko6c90fqCFhcQj/sqTPSW4VBUsputhP+SRj+cKtwH94KtXfh
QsAsK0h/og0602Uiznec19OQJ8P1KvWoyNJCwUNrYC/ciCpW/CjUVd7wS6Qgl/PZ
IMt7zcGQeH7vI8eT5ub5vy6ahXoI7cJZRZ5dQe6eUbA+XrB9t4U7wIGZRTnInq0J
Npzg96ScgyesTx5LWxZtVusnUaa9kgu4rsw7ZM/nzXagfkVbbrCmQJizpqM5rdp1
/pl2eiqo16c=
=f5w/
-----END PGP SIGNATURE-----

Attachment: pgpJiAdaQ8xzX.pgp
Description: PGP signature


--- End Message ---

Reply via email to