Your message dated Tue, 23 Jun 2026 23:05:45 +0000
with message-id <[email protected]>
and subject line Bug#1136581: fixed in sanlock 5.1.0-1
has caused the Debian Bug report #1136581,
regarding sanlock uses pidof but does not depend on procps
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1136581: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1136581
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: sanlock
Version: 4.2.0-1+b1
Usertags: pidof-without-procps

Dear maintainer(s) of sanlock,

it appears that sanlock uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of sanlock
  that use `pidof` at runtime;
* via the `Build-Depends:` field of sanlock, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of sanlock, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that sanlock uses `pidof` due to the following
code snippets:

```
path: sanlock_4.2.0-1/init.d/fence_sanlockd
        fi
        PID=$(pidofproc -p $runfile $prog)
        # We have to use SIGHUP to mean stop because sanlock


path: sanlock_4.2.0-1/fence_sanlock/fence_sanlock.in
                # make sure fence_sanlockd is alive
                [ -z "$(pidof fence_sanlockd)" ] && {
                        logger -t $prog "on fence_sanlockd stopped running"
                        return 1


path: sanlock_4.2.0-1/fence_sanlock/fence_sanlock.in
        read_leader || return 1
        [ -z "$(pidof fence_sanlockd)" ] && {
                logger -t $prog "on fence_sanlockd is not running"
                return 1


path: sanlock_4.2.0-1/fence_sanlock/fence_sanlock.in
                loop=$(($loop+1))
                tmp_pid="$(pidof fence_sanlockd)"
                [ -z "$tmp_pid" ] && {
                        logger -t $prog "fence_sanlockd not running"


path: sanlock_4.2.0-1/fence_sanlock/fence_sanlock.in
        }
        pid="$(pidof fence_sanlockd)"
        [ -z "$pid" ] && {
                logger -t $prog "Unable to determine fence_sanlockd pid"


path: sanlock_4.2.0-1/init.d/sanlock
stop() {
        PID=$(pidofproc -p $runfile $prog)
        echo -n $"Sending stop signal $prog ($PID): "
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

--- End Message ---
--- Begin Message ---
Source: sanlock
Source-Version: 5.1.0-1
Done: Håvard F. Aasen <[email protected]>

We believe that the bug you reported is fixed in the latest version of
sanlock, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Håvard F. Aasen <[email protected]> (supplier of updated sanlock package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 23 May 2026 19:58:51 +0200
Source: sanlock
Architecture: source
Version: 5.1.0-1
Distribution: unstable
Urgency: medium
Maintainer: Håvard F. Aasen <[email protected]>
Changed-By: Håvard F. Aasen <[email protected]>
Closes: 1136581
Changes:
 sanlock (5.1.0-1) unstable; urgency=medium
 .
   [ Luca Boccassi ]
   * Stop deleting system user/group on remove/purge
   * Install and use sysusers.d/tmpfiles.d config files
 .
   [ Håvard F. Aasen ]
   * New upstream release.
     - The new release removes all use of 'pidof' and therefore Closes: #1136581
   * Rebase patches.
   * Add patch to fix path for usrmerge.
   * Remove sanlk-reset and python3-sanlock packages.
   * Add libdevmapper-dev as BD to support new upstream release.
   * Upstream has moved its source to Codeberg.
   * Update Standards-Version to 4.7.4.
   * Remove 'Priority' value is now default.
   * Remove support for other init system then systemd.
   * Update symbol file after new upstream release.
   * Remove several unneeded overrides* in  d/rules.
   * Add logrotate and configuration file to binary package.
Checksums-Sha1:
 e6f31618dd923476de31b2da7e2a859c31be1d12 2115 sanlock_5.1.0-1.dsc
 ceaed9311ffd839fe8a43544c9165faf165ee8ad 256748 sanlock_5.1.0.orig.tar.gz
 b83294a96de3cdba658cb110819522e54e777d52 8032 sanlock_5.1.0-1.debian.tar.xz
 5d86d129e2b5d9fecb49a3aa3f151997957186ba 6506 sanlock_5.1.0-1_source.buildinfo
Checksums-Sha256:
 610f252b36e1a1dc16b6886a90cc2441b06fb354b2416d7ecfb1083322fa569a 2115 
sanlock_5.1.0-1.dsc
 b2b719f05df1bc0d746abae2740101f615347937abb2e284c5a88152b39ce4c0 256748 
sanlock_5.1.0.orig.tar.gz
 22ddf7aa31d41089f5d7ce67555a36ed05cfad1abd14591d2708a0c0e2ec724b 8032 
sanlock_5.1.0-1.debian.tar.xz
 90b4a67adb699f8f470078b148266220f60ea3e791e37836a1739125c33ac95d 6506 
sanlock_5.1.0-1_source.buildinfo
Files:
 60abae5e789e5e492a0110de61f81ee6 2115 libs optional sanlock_5.1.0-1.dsc
 9f34eb11f45b78ea08c8c698743211f5 256748 libs optional sanlock_5.1.0.orig.tar.gz
 5be40ab53aa4e5338a067c415ddbb81d 8032 libs optional 
sanlock_5.1.0-1.debian.tar.xz
 82d90e7c29019b21070b52efaebbf2f9 6506 libs optional 
sanlock_5.1.0-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEj23hBDd/OxHnQXSHMfMURUShdBoFAmo7C+IACgkQMfMURUSh
dBq04w//RdpkEo9Lho2+ThpQXlsEmJK/8tV583lWTeSXsZ6hLsLScnpFCPNtih+b
FSinozkYdSqoRLreS92iWpb2GLLGwe8soyEZwZN/pd6hM+NcDFv4O/RAA00XneVu
jEP6hjCXTPhNeM66mtO5PGRtLiRp1jGut+h4XeUIXB1g5ubg2pWTTbcO7VLZaY85
UusHoCTjHtLaR7S1aZ+wezRR+iJEOUdIWxh0IrviIY/wgbWgXfe7c7BFTaaMY3Jq
+ud20/4Owb4gwi2XLAQvAWunE9g4lWJdUWKmZvcIL4reCQgHZSLnlXEMJPS8LFt2
lpXKw6EPDed+RfYJhDAP+ZptMymxOC/NHgb41AxX7uXObY0HQN4WTm92Lup0Smbu
963OmwaGuNKRhiwK+F+A6XZDBPjYKYiSMfDBr5B4eYEIPNIHAibDzRO5Tn0qQB95
ocJUvBOX+GyR/GHt+LOZYczFgYlw+jIXj6JekU3qoG0D+/HkieRZQ8wWWuH9mGFw
vnenFb61X4Oq0l1BODBNY+kyyLLDAh/CCQ67gnnugViHWPLrTNo7hKotgusmyWJr
4IB/Q2ai+XZs2gQgDswovEHuyZYAUTMjIZgDG+jo3WMErg2LjSvh6ShvH/n0Ti/J
g401Hx4p7RYEqP/fckoK604KuBND1CvTgwE7j+s6fVf4daF7VRk=
=PvvJ
-----END PGP SIGNATURE-----

Attachment: pgpnn4ff8IH9a.pgp
Description: PGP signature


--- End Message ---

Reply via email to