Your message dated Sun, 12 Jul 2026 22:57:57 +0000
with message-id <[email protected]>
and subject line Bug#1093227: fixed in fake-hwclock 0.15
has caused the Debian Bug report #1093227,
regarding fake-hwclock: the logic of the force parameter for load is inverted
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1093227: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1093227
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: fake-hwclock
Version: 0.14
Severity: important
Tags: patch

Since version 0.14, calling `fake-hwclock load` *without* the `force` parameter will actually always force loading the saved clock even if older than the system clock. This is very annoying as this forces the system to an older incorrect clock at boot time even after the system clock was properly set to the correct time from the RTC by the kernel.

This is due the an inverted logic test introduced by commit 83537e2 (Tweak handling of parameters) and easily fixed with the following patch:

commit bb7d2c1a0f45905267064b376c812ec53c829286 (HEAD -> master)
Author: Aurelien Jacobs <[email protected]>
Date:   Thu Jan 16 19:15:11 2025 +0100

Fix an inverted logic issue for the force parameter of the load command

   The bug was introduced in the following commit:
   83537e2  Tweak handling of parameters.

diff --git a/fake-hwclock b/fake-hwclock
index 641c49f..d83afc8 100755
--- a/fake-hwclock
+++ b/fake-hwclock
@@ -56,7 +56,7 @@ case $COMMAND in
            SAVED="$(cat $FILE)"
            SAVED_SEC=$(date -u -d "$SAVED" '+%s')
            NOW_SEC=$(date -u '+%s')
- if [ "$FORCE"x = "false"x ] || [ $NOW_SEC -le $SAVED_SEC ] ; then + if [ "$FORCE"x != "false"x ] || [ $NOW_SEC -le $SAVED_SEC ] ; then
                date -u -s "$SAVED"
            else
echo "Current system time: $(date -u '+%Y-%m-%d %H:%M:%S')"


commit bb7d2c1a0f45905267064b376c812ec53c829286
Author: Aurelien Jacobs <[email protected]>
Date:   Thu Jan 16 19:15:11 2025 +0100

    Fix an inverted logic issue for the force parameter of the load command
    
    The bug was introduced in the following commit:
    83537e2  Tweak handling of parameters.

diff --git a/fake-hwclock b/fake-hwclock
index 641c49f..d83afc8 100755
--- a/fake-hwclock
+++ b/fake-hwclock
@@ -56,7 +56,7 @@ case $COMMAND in
             SAVED="$(cat $FILE)"
             SAVED_SEC=$(date -u -d "$SAVED" '+%s')
             NOW_SEC=$(date -u '+%s')
-            if [ "$FORCE"x = "false"x ] || [ $NOW_SEC -le $SAVED_SEC ] ; then
+            if [ "$FORCE"x != "false"x ] || [ $NOW_SEC -le $SAVED_SEC ] ; then
                 date -u -s "$SAVED"
             else
                 echo "Current system time: $(date -u '+%Y-%m-%d %H:%M:%S')"

--- End Message ---
--- Begin Message ---
Source: fake-hwclock
Source-Version: 0.15
Done: Steve McIntyre <[email protected]>

We believe that the bug you reported is fixed in the latest version of
fake-hwclock, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Steve McIntyre <[email protected]> (supplier of updated fake-hwclock package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 12 Jul 2026 23:04:22 +0100
Source: fake-hwclock
Architecture: source
Version: 0.15
Distribution: unstable
Urgency: medium
Maintainer: Steve McIntyre <[email protected]>
Changed-By: Steve McIntyre <[email protected]>
Closes: 1093227 1118233 1120144
Changes:
 fake-hwclock (0.15) unstable; urgency=medium
 .
   [ Aurelien Jacobs ]
   * Fix an inverted logic issue for the force parameter of the load
     command. Closes: #1093227
   * Remove redudant word in the man page. Closes: #1120144
   * Stop suggesting ntp, it's gone away. Instead, suggest ntpsec |
     time-daemon. Closes: #1118233
Checksums-Sha1:
 d70a6753f78964b362f419f8555a82ba4d38f546 1572 fake-hwclock_0.15.dsc
 4a0af47b8aac00910630425597b0fa80446b693b 12032 fake-hwclock_0.15.tar.xz
 cd54621536b85e8178248808ed89738207bb3e2d 5439 
fake-hwclock_0.15_source.buildinfo
Checksums-Sha256:
 427a20f062b9f1e2f5538def6b82a78473ddfedb5160a1dfeaf5acd155694b54 1572 
fake-hwclock_0.15.dsc
 44f37fc643100d8476161a5fab845df6c91fa5a9407f9fd79d5c5d799c43b485 12032 
fake-hwclock_0.15.tar.xz
 0d668de4b7e4d47c65307367011b3280427d870de07a66ed4cdda05a8bb70a7b 5439 
fake-hwclock_0.15_source.buildinfo
Files:
 00f21372d4c01b7e7f1e6e895b1a372e 1572 admin optional fake-hwclock_0.15.dsc
 9d44f5c2016eb67ae06f3dc1e23e6f4c 12032 admin optional fake-hwclock_0.15.tar.xz
 249836d681c12015b43fb4f1877afe24 5439 admin optional 
fake-hwclock_0.15_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEzrtSMB1hfpEDkP4WWHl5VzRCaE4FAmpUFyERHDkzc2FtQGRl
Ymlhbi5vcmcACgkQWHl5VzRCaE4AIw/+KhXMgN8aI6gudjXPhLNK+adpjUn9vZTF
pCHii/WPnLeeNBzzWXwrqwlHE4hiUwiB9p8lY1cr6159RIYKr5MTC/8BHGjWgENz
LJSg1TCts4HbYl+v1TzseI6iMAhaOIlyNWBB/C123oumQE5D55WX2cbvp9CSVXI0
QYB9xU0kJG867X2K9/ykjgq7ERVaQwMU7CsLq7dNYVzYw8iV2pxhWgPBM9j7EyHG
9f0GlukPKVkzewm+hgyjD4yiDoADvpbiVbxj0fDEa/aGNkfcIB0HDcJkgZwxBbZ9
/3OwKwC1KyAk12y4iQOV3MyxtL0NBMDGjW92oeAJsXUyXPduNrset7livQU39auw
7/o9egUv/9h972BhMhTVkYzDif2kzFzBP0HfkdmWmxhxwOHYmk9lFNxXQAahoBwN
QdEE+PAfUsT+crdxGNgL9uxlHN8tbEHG2KwYHSOR/mtsra8xJkSgw04PZsAuDLnq
8I6OJIWcV0/2MxEyC7G85ZLm9x3qb48tMTLbA71l+GVhGX5srUbZ3W96gRKICkiR
pCAa4M3ur+UQWoSZEVSvd+6RS42YiChzoJAIjPInkc44sze9GW0lIrMwjigMCH4q
WTC/ezEHnuDet4sp8pC+3yzxZrZwYHe+B4vG+gzJAWyd+rLXoUjod+crapcM4YO+
gRApvc0kNms=
=twhu
-----END PGP SIGNATURE-----

Attachment: pgpUKKitrXVYL.pgp
Description: PGP signature


--- End Message ---

Reply via email to