Your message dated Sat, 1 Aug 2026 15:25:04 +0200
with message-id <[email protected]>
and subject line Re: Bug#1136541: open-iscsi uses pidof but does not depend on 
procps
has caused the Debian Bug report #1136541,
regarding open-iscsi uses pidof but does not depend on procps
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1136541: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1136541
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: open-iscsi
Version: 2.1.11-5
Usertags: pidof-without-procps

Dear maintainer(s) of open-iscsi,

it appears that open-iscsi uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of open-iscsi
  that use `pidof` at runtime;
* via the `Build-Depends:` field of open-iscsi, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of open-iscsi, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that open-iscsi uses `pidof` due to the following
code snippets:

```
path: open-iscsi_2.1.11-4/utils/iscsi_discovery.sh
{
        #check if iscsid is running
        pidof iscsid &>/dev/null
        ret=$?
        if [ $ret -ne 0 ]; then
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

--- End Message ---
--- Begin Message ---
Source: open-iscsi
Source-Version: 2.1.11-5

On Thu, May 14, 2026 at 01:29:57AM +0200, Gioele Barabucci wrote:
> it appears that open-iscsi uses `pidof` in its testsuite, or that
> at least one of its binary packages uses `pidof` at runtime.

commit dc8b039ef0c9b0b2697761bf43e9e6b710aee72b
Author:     Chris Hofstaedtler <[email protected]>
AuthorDate: Fri May 8 12:19:51 2026 +0200
Commit:     Chris Hofstaedtler <[email protected]>
CommitDate: Fri May 8 12:19:52 2026 +0200

    open-iscsi: add Depends: procps for pidof

    pidof will move from Essential package sysvinit-utils to procps.
    iscsi_discovery uses pidof directly.

diff --git a/debian/control b/debian/control
index 2f741e6..3e3fa51 100644
--- a/debian/control
+++ b/debian/control
@@ -31,6 +31,7 @@ Architecture: linux-any
 Multi-Arch: foreign
 Depends:
  libopeniscsiusr (= ${binary:Version}),
+ procps,
  udev,
  ${misc:Depends},
  ${shlibs:Depends},

--- End Message ---

Reply via email to