Your message dated Sun, 03 Sep 2006 14:18:44 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#385874: fixed in mysql-dfsg-5.0 5.0.24a-2
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: mysql-server-5.0
Version: 5.0.24a-1
Severity: minor
Tags: patch

Hi,

the attached patch changes the mysql-server-5.0 init.d script(s) to use lsb
logging functions.

Regards,
David

--
David Härdeman
diff -ur ./mysql-dfsg-5.0-5.0.24a.orig/debian/control 
./mysql-dfsg-5.0-5.0.24a/debian/control
--- ./mysql-dfsg-5.0-5.0.24a.orig/debian/control        2006-09-03 
17:27:46.000000000 +0200
+++ ./mysql-dfsg-5.0-5.0.24a/debian/control     2006-09-03 18:04:56.000000000 
+0200
@@ -67,7 +67,7 @@
 Architecture: any                                                              
 
 Suggests: tinyca
 Recommends: mailx
-Depends: mysql-common (>= ${Source-Version}), mysql-client-5.0 (>= 
${Source-Version}), libdbi-perl, perl (>= 5.6), ${shlibs:Depends}, 
${misc:Depends}, adduser (>= 3.40), psmisc, passwd
+Depends: mysql-common (>= ${Source-Version}), mysql-client-5.0 (>= 
${Source-Version}), libdbi-perl, perl (>= 5.6), ${shlibs:Depends}, 
${misc:Depends}, adduser (>= 3.40), psmisc, passwd, lsb-base (>= 3.0-10)
 Conflicts: mysql-server (<< ${Source-Version}), mysql-server-4.1
 Provides: mysql-server, virtual-mysql-server, mysql-server-4.1
 Replaces: mysql-server (<< ${Source-Version}), mysql-server-4.1
diff -ur ./mysql-dfsg-5.0-5.0.24a.orig/debian/mysql-server-5.0.mysql.init 
./mysql-dfsg-5.0-5.0.24a/debian/mysql-server-5.0.mysql.init
--- ./mysql-dfsg-5.0-5.0.24a.orig/debian/mysql-server-5.0.mysql.init    
2006-09-03 17:27:46.000000000 +0200
+++ ./mysql-dfsg-5.0-5.0.24a/debian/mysql-server-5.0.mysql.init 2006-09-03 
17:59:29.000000000 +0200
@@ -10,6 +10,8 @@
 
 test -x /usr/sbin/mysqld || exit 0
 
+. /lib/lsb/init-functions
+
 SELF=$(cd $(dirname $0); pwd -P)/$(basename $0)
 CONF=/etc/mysql/my.cnf
 MYADMIN="/usr/bin/mysqladmin --defaults-file=/etc/mysql/debian.cnf"
@@ -41,12 +43,14 @@
 sanity_checks() {
   # check for config file
   if [ ! -r /etc/mysql/my.cnf ]; then
-    /bin/echo "WARNING: /etc/mysql/my.cnf cannot be read. See 
README.Debian.gz" | $ERR_LOGGER -s
-  fi 
+    log_warning_msg "$0: WARNING: /etc/mysql/my.cnf cannot be read. See 
README.Debian.gz"
+    echo "WARNING: /etc/mysql/my.cnf cannot be read. See README.Debian.gz" | 
$ERR_LOGGER
+  fi
 
   datadir=`mysqld_get_param datadir`
   if LC_ALL=C BLOCKSIZE= df --portability $datadir/. | tail -n 1 | awk '{ exit 
($4>4096) }'; then
-    /bin/echo "ERROR: The partition with $datadir is too full!" | $ERR_LOGGER 
-s
+    log_failure_msg "$0: ERROR: The partition with $datadir is too full!"
+    echo "ERROR: The partition with $datadir is too full!" | $ERR_LOGGER
     exit 1
   fi
 }
@@ -69,7 +73,7 @@
        return 0 # EXIT_SUCCESS
     else
        if [ "$2" = "warn" ]; then
-           /bin/echo -e "$ps_alive processes alive and '$MYADMIN ping' 
resulted in\n$ping_output\n" | $ERR_LOGGER -p daemon.debug
+           echo -e "$ps_alive processes alive and '$MYADMIN ping' resulted 
in\n$ping_output\n" | $ERR_LOGGER -p daemon.debug
        fi
        return 1 # EXIT_FAILURE
     fi
@@ -83,33 +87,35 @@
   'start')
        sanity_checks;
        # Start daemon
-       echo -n "Starting MySQL database server: mysqld"
+       log_daemon_msg "Starting MySQL database server" "mysqld"
        if mysqld_status check_alive nowarn; then
-          echo "...already running."
+          log_progress_msg "already running"
+          log_end_msg 0
        else
            /usr/bin/mysqld_safe > /dev/null 2>&1 &
            # 6s was reported in #352070 to be too few when using ndbcluster
            for i in 1 2 3 4 5 6 7 8 9 10 11 12 13 14; do
                 sleep 1
                if mysqld_status check_alive nowarn ; then break; fi
-                echo "."
-            done
+               log_progress_msg "."
+           done
            if mysqld_status check_alive warn; then
-                echo "."
+                log_end_msg 0
                # Now start mysqlcheck or whatever the admin wants.
-               /etc/mysql/debian-start
+               output=$(/etc/mysql/debian-start)
+               [ -n "$output" ] && log_action_msg "$output"
            else
-               echo "...failed or took more than 6s."
-               /bin/echo -e "\tPlease take a look at the syslog."
+               log_end_msg 1
+               log_failure_msg "Please take a look at the syslog"
            fi
        fi
 
        # Some warnings
         if $MYADMIN variables | egrep -q have_bdb.*YES; then
-            /bin/echo "BerkeleyDB is obsolete, see 
/usr/share/doc/mysql-server-5.0/README.Debian.gz" | $ERR_LOGGER -p daemon.info
+            echo "BerkeleyDB is obsolete, see 
/usr/share/doc/mysql-server-5.0/README.Debian.gz" | $ERR_LOGGER -p daemon.info
         fi
         if [ -f /etc/mysql/debian-log-rotate.conf ]; then
-            /bin/echo "/etc/mysql/debian-log-rotate.conf is obsolete, see 
/usr/share/doc/mysql-server-5.0/NEWS.Debian.gz" | $ERR_LOGGER -p daemon.info
+            echo "/etc/mysql/debian-log-rotate.conf is obsolete, see 
/usr/share/doc/mysql-server-5.0/NEWS.Debian.gz" | $ERR_LOGGER -p daemon.info
         fi
        ;;
 
@@ -118,13 +124,15 @@
        # at least for cron, we can rely on it here, too. (although we have 
        # to specify it explicit as e.g. sudo environments points to the normal
        # users home and not /root)
-       echo -n "Stopping MySQL database server: mysqld"        
+       log_daemon_msg "Stopping MySQL database server" "mysqld"
        if ! mysqld_status check_dead nowarn; then
          set +e
          shutdown_out=`$MYADMIN shutdown 2>&1`; r=$?
          set -e
          if [ "$r" -ne 0 ]; then
-           /bin/echo -e -n "...failed.\n$shutdown_out\nKilling MySQL database 
server by signal: mysqld"
+           log_end_msg 1
+           [ "$VERBOSE" != "no" ] && log_failure_msg "Error: $shutdown_out"
+           log_daemon_msg "Killing MySQL database server by signal" "mysqld"
            killall -15 mysqld
             server_down=
            for i in 1 2 3 4 5 6 7 8 9 10; do
@@ -136,11 +144,11 @@
         fi
 
         if ! mysqld_status check_dead warn; then
-         echo "...failed."
-         echo "Please stop MySQL manually and read 
/usr/share/doc/mysql-server-5.0/README.Debian.gz!"
+         log_end_msg 1
+         log_failure_msg "Please stop MySQL manually and read 
/usr/share/doc/mysql-server-5.0/README.Debian.gz!"
          exit -1
        else
-         echo "."
+         log_end_msg 0
         fi
        ;;
 
@@ -150,16 +158,16 @@
        ;;
 
   'reload'|'force-reload')
-       echo -n "Reloading MySQL database server: mysqld"
+       log_daemon_msg "Reloading MySQL database server" "mysqld"
        $MYADMIN reload
-       echo "."
+       log_end_msg 0
        ;;
 
   'status')
        if mysqld_status check_alive nowarn; then
-         $MYADMIN version
+         log_action_msg "$($MYADMIN version)"
        else
-         echo "MySQL is stopped."
+         log_action_msg "MySQL is stopped."
          exit 3
        fi
        ;;
diff -ur ./mysql-dfsg-5.0-5.0.24a.orig/debian/mysql-server-5.0.mysql-ndb.init 
./mysql-dfsg-5.0-5.0.24a/debian/mysql-server-5.0.mysql-ndb.init
--- ./mysql-dfsg-5.0-5.0.24a.orig/debian/mysql-server-5.0.mysql-ndb.init        
2006-09-03 17:27:46.000000000 +0200
+++ ./mysql-dfsg-5.0-5.0.24a/debian/mysql-server-5.0.mysql-ndb.init     
2006-09-03 18:01:58.000000000 +0200
@@ -24,6 +24,7 @@
 # See /usr/share/doc/mysql-server-*/README.Debian for more information.
 test -x $DAEMON || exit 0
 if $DAEMON --help | grep -q '^ndb-connectstring.*No default value'; then exit 
0; fi
+. /lib/lsb/init-functions
 
 #
 # main()
@@ -33,30 +34,30 @@
        # Start daemon
         # Creatign a PID file does not work as the master process forks
         # a child with different PID and then terminates itself.
-       echo -n "Starting MySQL NDB cluster server: ndbd"
+       log_daemon_msg "Starting MySQL NDB cluster server" "ndbd"
        if start-stop-daemon \
                --start \
                --exec $DAEMON \
                --user mysql
        then
-         echo "."
+         log_end_msg 0
        else
-         echo "...failed."
-         /bin/echo -e "\tPlease take a look at the syslog."
+         log_end_msg 1
+         log_warning_msg "Please take a look at the syslog."
          exit 1
        fi                        
        ;;
 
   'stop')
-       echo -n "Stopping MySQL NDB cluster management server: ndbd"    
+       log_daemon_msg "Stopping MySQL NDB cluster management server" "ndbd"    
        if start-stop-daemon \
                --stop \
                --oknodo \
                --exec $DAEMON
        then
-         echo "."
+         log_end_msg 0
        else
-         echo "...failed."
+         log_end_msg 1
          exit 1
         fi
        ;;
diff -ur 
./mysql-dfsg-5.0-5.0.24a.orig/debian/mysql-server-5.0.mysql-ndb-mgm.init 
./mysql-dfsg-5.0-5.0.24a/debian/mysql-server-5.0.mysql-ndb-mgm.init
--- ./mysql-dfsg-5.0-5.0.24a.orig/debian/mysql-server-5.0.mysql-ndb-mgm.init    
2006-09-03 17:27:46.000000000 +0200
+++ ./mysql-dfsg-5.0-5.0.24a/debian/mysql-server-5.0.mysql-ndb-mgm.init 
2006-09-03 18:03:39.000000000 +0200
@@ -24,6 +24,7 @@
 # See /usr/share/doc/mysql-server-*/README.Debian for more information.
 test -x $DAEMON || exit 0
 test -r $CONF || exit 0
+. /lib/lsb/init-functions
 
 #
 # main()
@@ -31,7 +32,7 @@
 case "${1:-''}" in
   'start')
        # Start daemon
-       echo -n "Starting MySQL NDB cluster management server: ndb_mgmd"
+       log_daemon_msg "Starting MySQL NDB cluster management server" "ndb_mgmd"
        # --pid-file does not work as the daemon forks itself with $PID=$PID+1
        if start-stop-daemon \
                --start \
@@ -40,24 +41,24 @@
                -- \
                -f $CONF
        then
-         echo "."
+         log_end_msg 0
        else
-         echo "...failed."
-         /bin/echo -e "\tPlease take a look at the syslog."
+         log_end_msg 1
+         log_warning_msg "Please take a look at the syslog."
          exit 1
        fi                        
        ;;
 
   'stop')
-       echo -n "Stopping MySQL NDB cluster management server: ndb_mgmd"        
+       log_daemon_msg "Stopping MySQL NDB cluster management server" 
"ndb_mgmd"        
        if start-stop-daemon \
                --stop \
                --oknodo \
                --exec $DAEMON
        then
-         echo "."
+         log_end_msg 0
        else
-         echo "...failed."
+         log_end_msg 1
          exit 1
         fi
        ;;

--- End Message ---
--- Begin Message ---
Source: mysql-dfsg-5.0
Source-Version: 5.0.24a-2

We believe that the bug you reported is fixed in the latest version of
mysql-dfsg-5.0, which is due to be installed in the Debian FTP archive:

libmysqlclient15-dev_5.0.24a-2_amd64.deb
  to pool/main/m/mysql-dfsg-5.0/libmysqlclient15-dev_5.0.24a-2_amd64.deb
libmysqlclient15off_5.0.24a-2_amd64.deb
  to pool/main/m/mysql-dfsg-5.0/libmysqlclient15off_5.0.24a-2_amd64.deb
mysql-client-5.0_5.0.24a-2_amd64.deb
  to pool/main/m/mysql-dfsg-5.0/mysql-client-5.0_5.0.24a-2_amd64.deb
mysql-client_5.0.24a-2_all.deb
  to pool/main/m/mysql-dfsg-5.0/mysql-client_5.0.24a-2_all.deb
mysql-common_5.0.24a-2_all.deb
  to pool/main/m/mysql-dfsg-5.0/mysql-common_5.0.24a-2_all.deb
mysql-dfsg-5.0_5.0.24a-2.diff.gz
  to pool/main/m/mysql-dfsg-5.0/mysql-dfsg-5.0_5.0.24a-2.diff.gz
mysql-dfsg-5.0_5.0.24a-2.dsc
  to pool/main/m/mysql-dfsg-5.0/mysql-dfsg-5.0_5.0.24a-2.dsc
mysql-server-5.0_5.0.24a-2_amd64.deb
  to pool/main/m/mysql-dfsg-5.0/mysql-server-5.0_5.0.24a-2_amd64.deb
mysql-server_5.0.24a-2_all.deb
  to pool/main/m/mysql-dfsg-5.0/mysql-server_5.0.24a-2_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Hammers <[EMAIL PROTECTED]> (supplier of updated mysql-dfsg-5.0 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun,  3 Sep 2006 19:06:53 +0200
Source: mysql-dfsg-5.0
Binary: libmysqlclient15-dev mysql-client mysql-client-5.0 mysql-server 
mysql-server-5.0 mysql-common libmysqlclient15off
Architecture: source all amd64
Version: 5.0.24a-2
Distribution: unstable
Urgency: low
Maintainer: Christian Hammers <[EMAIL PROTECTED]>
Changed-By: Christian Hammers <[EMAIL PROTECTED]>
Description: 
 libmysqlclient15-dev - mysql database development files
 libmysqlclient15off - mysql database client library
 mysql-client - mysql database client (current version)
 mysql-client-5.0 - mysql database client binaries
 mysql-common - mysql database common files (e.g. /etc/mysql/my.cnf)
 mysql-server - mysql database server (current version)
 mysql-server-5.0 - mysql database server binaries
Closes: 385874
Changes: 
 mysql-dfsg-5.0 (5.0.24a-2) unstable; urgency=low
 .
   * Added "mysqlreport" (GPL'ed) from hackmysql.com.
   * Temporarily disabled expire_days option as it causes the server
     to crash. See #368547
   * Made output of init scripts LSB compliant (thanks to David Härdeman).
     Closes: #385874
Files: 
 c731fdd3d0b6ae64bd27d566fddf6425 1093 misc optional 
mysql-dfsg-5.0_5.0.24a-2.dsc
 57ab95e741ca8f7a553190941d345142 134855 misc optional 
mysql-dfsg-5.0_5.0.24a-2.diff.gz
 7592236efbd333b0efa30b2d12048eac 40676 misc optional 
mysql-common_5.0.24a-2_all.deb
 47761784f369c729a38c6476878d70c5 38066 misc optional 
mysql-server_5.0.24a-2_all.deb
 ea9d0ac5f2f247d796f635eb64cd04e7 38062 misc optional 
mysql-client_5.0.24a-2_all.deb
 849cccc0ee7541f111875f6fffe3db2c 1807012 libs optional 
libmysqlclient15off_5.0.24a-2_amd64.deb
 c61fd77f0a3ffc432e1f96fdb670cace 7263080 libdevel optional 
libmysqlclient15-dev_5.0.24a-2_amd64.deb
 272e0e2df60c2038ee8e7d200fe34f02 7388418 misc optional 
mysql-client-5.0_5.0.24a-2_amd64.deb
 f64a46dbf361c765aad613da6aee1f9c 22520042 misc optional 
mysql-server-5.0_5.0.24a-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iEYEARECAAYFAkT7LoIACgkQkR9K5oahGObTVQCfQzg1ZfHJTSXbzvduN0OoviwW
QxwAn3r2eplgyoOworZ/ZjGH/0CQMExb
=1rlL
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to