Your message dated Sun, 17 Sep 2006 22:01:30 +0200
with message-id <[EMAIL PROTECTED]>
and subject line bug closed in experimental and now also closed in unstable
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: pilot-link
Version: 0.11.8-9
Severity: normal
Tags: patch
pilot-addresses -r <file> skips every other entry due to mishandled
attempt at allowing comment lines prefixed with a '#'.
The bug is trivially verified using the following procedure:
# pilot-addresses -w test.out
# gawk '/0\"$/ {count++} count==5 {nextfile} {print}' test.out > test.in
(or 'head +4 test.out > test.in' if top entries are single lines)
# pilot-addresses -r test.in
Look in the Address Book's 'Unfiled' category (on the Palm) to see the
problem.
This bug is already in the pilot-link bts, but devel seems a little stalled
there.
<http://bugs.pilot-link.org/bug_view_advanced_page.php?bug_id=1093>
I thought it would be more productive (and somewhat simpler thanks to
reportbug) to post the patch through debian. Please let me know if I
should have gone upstream with the patch first.
-- Brad
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.25
Locale: LANG=en_US, LC_CTYPE=en_US
Versions of packages pilot-link depends on:
ii debconf 1.4.25 Debian configuration management sy
ii libc6 2.3.2.ds1-13 GNU C Library: Shared libraries an
ii libncurses5 5.4-4 Shared libraries for terminal hand
ii libpisock8 0.11.8-10-1 Library for communicating with a P
ii libpng12-0 1.2.5.0-6 PNG library - runtime
ii libreadline4 4.3-10 GNU readline and history libraries
-- debconf information excluded
diff -rubB pilot-link-0.11.8-9/src/pilot-addresses.c pilot-link-0.11.8-10/src/pilot-addresses.c
--- pilot-link-0.11.8-9/src/pilot-addresses.c 2004-06-01 23:00:19.000000000 -0400
+++ pilot-link-0.11.8-10/src/pilot-addresses.c 2004-06-01 22:13:27.000000000 -0400
@@ -291,7 +291,7 @@
int read_file(FILE *in, int sd, int db, struct AddressAppInfo *aai)
{
int i = -1,
- l,
+ l, c,
attribute,
category;
char buf[0xffff];
@@ -302,10 +302,15 @@
fflush(stdout);
do {
- fgets(line, 1000, in);
- if (index(line, '#') == line) {
- fprintf(stderr, "\nIgnoring header\n");
+ /* Skip comment lines */
+ c = getc(in);
+ if(feof(in)) break;
+ if(c == '#') {
+ fgets(line, sizeof(line), in);
+ fprintf(stderr,"Skipping line: %s\n",line);
continue;
+ } else {
+ fseek(in, -1, SEEK_CUR);
}
i = read_field(buf, in, sizeof(buf));
--- End Message ---
--- Begin Message ---
Hello,
The bug you reported has been closed by a version of pilot-link uploaded
in experimental. Version 0.12.1 is now stable upstream and has been
uploaded in Debian unstable so the bug is really closed now.
Thanks,
--
Dr. Ludovic Rousseau [EMAIL PROTECTED]
-- Normaliser Unix c'est comme pasteuriser le camembert, L.R. --
--- End Message ---
