Your message dated Tue, 19 Sep 2006 06:02:14 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#388249: fixed in dbconfig-common 1.8.23
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: dbconfig-common
Version: 1.8.22
Severity: important
Tags: patch
Hello Sean,
I noticed your mass bug filing about the policy compliance of maintainer
scripts: they need to conditionally source the dbconfig-common files in
the config and postrm scripts.
However, the documentation does not reflect this in the example 'config'
script, thus the error can get reintroduced easily lateron. That's while
I'm filing this as important.
Please find attached a patch that solves this.
The documentation also mentioned that you need to explicitly depend on
debconf. The example packages don't do this, but I think this is right:
dbconfig-common itself already depends on debconf, and its good to keep
this dependency in one place. Therefore, I've dropped that notice from
the docs.
Thanks for your good work on dbconfig-common!
Thijs
Index: doc/dbconfig-common.sgml
===================================================================
--- doc/dbconfig-common.sgml (revision 330)
+++ doc/dbconfig-common.sgml (working copy)
@@ -86,8 +86,7 @@
not currently using debconf in your package,
you will be now, and the debconf libraries
need to be sourced first. you will need to
- depend on debconf explicitly, and either use
- dh_installdebconf or otherwise install your
+ use dh_installdebconf or otherwise install your
<var>config</var> script into your deb file
if you're not already doing so. for example,
here's an what it might look like in a <var>config</var>
@@ -358,12 +357,16 @@
# source debconf stuff
. /usr/share/debconf/confmodule
-# we support mysql and pgsql
-dbc_dbtypes="mysql, pgsql"
+
# source dbconfig-common stuff
-. /usr/share/dbconfig-common/dpkg/config
-dbc_go foo-mysql $@
+if [ -f /usr/share/dbconfig-common/dpkg/config ]; then
+ # we support mysql and pgsql
+ dbc_dbtypes="mysql, pgsql"
+ . /usr/share/dbconfig-common/dpkg/config
+ dbc_go foo-mysql $@
+fi
+
# ... rest of your code ...
</example>
signature.asc
Description: This is a digitally signed message part
--- End Message ---
--- Begin Message ---
Source: dbconfig-common
Source-Version: 1.8.23
We believe that the bug you reported is fixed in the latest version of
dbconfig-common, which is due to be installed in the Debian FTP archive:
dbconfig-common_1.8.23.dsc
to pool/main/d/dbconfig-common/dbconfig-common_1.8.23.dsc
dbconfig-common_1.8.23.tar.gz
to pool/main/d/dbconfig-common/dbconfig-common_1.8.23.tar.gz
dbconfig-common_1.8.23_all.deb
to pool/main/d/dbconfig-common/dbconfig-common_1.8.23_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
sean finney <[EMAIL PROTECTED]> (supplier of updated dbconfig-common package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 19 Sep 2006 14:33:55 +0200
Source: dbconfig-common
Binary: dbconfig-common
Architecture: source all
Version: 1.8.23
Distribution: unstable
Urgency: low
Maintainer: sean finney <[EMAIL PROTECTED]>
Changed-By: sean finney <[EMAIL PROTECTED]>
Description:
dbconfig-common - common framework for packaging database applications
Closes: 388249
Changes:
dbconfig-common (1.8.23) unstable; urgency=low
.
* Thijs Kinkhorst noticed a discrepancy in the documenation about
the config file later on in the documenation. also, since
dbconfig-common depends on debconf, it's not necessary for the
package in question to depend on debconf if it doesn't explicitly
need it (closes: #388249).
Files:
faf41c204bb33304ab5374d899c967cf 561 admin optional dbconfig-common_1.8.23.dsc
2ba9836f881ee26f8cbf06d3f014acf1 247361 admin optional
dbconfig-common_1.8.23.tar.gz
7018018b57e72bf15d27f72bf913e3d4 429586 admin optional
dbconfig-common_1.8.23_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
iD8DBQFFD+c9ynjLPm522B0RAqNEAJsGXV1+4hzu/R3pbMEfhdq5gOurpgCfTbn7
KyBywvGFSncBAA1uoI+X3Mg=
=9G9p
-----END PGP SIGNATURE-----
--- End Message ---