Your message dated Fri, 06 Oct 2006 11:02:21 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#390936: fixed in sysvinit 2.86.ds1-33
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: initscripts
Version: 2.86.ds1-30

The line

fuser -k INT -m $DIRS

is syntactically not correct it probably should be:

fuser -k -INT -m $DIRS

and similarly for another line with TERM instead of INT.

I have a patch with some additional changes for the fuser usage
that seemed like a good idea to me:

1. Replace INT with TERM and TERM with KILL. SIGINT is really only
meant for interactive use and does not reliably terminate a process.
SIGKILL is the typical last resort solution since it cannot be
caught by the process.

2. Use return value of fuser instead of string comparison with fuser
output to check for not yet terminated processes.

3. Put sleep after loop condition to prevent delay in case no
processes are left immediately.

4. Use -s switch to prevent clutter.

--- umountnfs.sh.old    2006-09-29 19:12:09.000000000 +0200
+++ umountnfs.sh        2006-10-03 00:25:58.993986124 +0200
@@ -84,18 +84,17 @@
                # Kill all processes using the directories we try to umount
                if [ -x /bin/fuser ] ; then
                        [ "$VERBOSE" = no ] || log_action_begin_msg "Asking 
non-system processes to terminate"
-                       fuser -k INT -m $DIRS
+                       fuser -k -TERM -s -m $DIRS
                        [ "$VERBOSE" = no ] || log_action_end_msg 0

                        for count in 1 2 3 4 5; do # Wait up to 5 seconds
+                           fuser -s -m $DIRS || break
                            sleep 1
-                           [ -z "`fuser -m $DIRS 2> /dev/null`" ] && break
                        done

-                       pidsleft=`fuser -m $DIRS 2>/dev/null`
-                       if [ "$pidsleft" ] ; then
+                       if fuser -s -m $DIRS; then
                            [ "$VERBOSE" = no ] || log_action_begin_msg 
"Killing non-system processes"
-                           fuser -k TERM -m $DIRS
+                           fuser -k -KILL -s -m $DIRS
                            [ "$VERBOSE" = no ] || log_action_end_msg 0
                        fi
                else


--
Markus


--- End Message ---
--- Begin Message ---
Source: sysvinit
Source-Version: 2.86.ds1-33

We believe that the bug you reported is fixed in the latest version of
sysvinit, which is due to be installed in the Debian FTP archive:

initscripts_2.86.ds1-33_i386.deb
  to pool/main/s/sysvinit/initscripts_2.86.ds1-33_i386.deb
sysv-rc_2.86.ds1-33_all.deb
  to pool/main/s/sysvinit/sysv-rc_2.86.ds1-33_all.deb
sysvinit-utils_2.86.ds1-33_i386.deb
  to pool/main/s/sysvinit/sysvinit-utils_2.86.ds1-33_i386.deb
sysvinit_2.86.ds1-33.diff.gz
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-33.diff.gz
sysvinit_2.86.ds1-33.dsc
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-33.dsc
sysvinit_2.86.ds1-33_i386.deb
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-33_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <[EMAIL PROTECTED]> (supplier of updated sysvinit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri,  6 Oct 2006 19:51:05 +0200
Source: sysvinit
Binary: sysv-rc sysvinit-utils sysvinit initscripts
Architecture: source i386 all
Version: 2.86.ds1-33
Distribution: unstable
Urgency: low
Maintainer: Debian sysvinit maintainers 
<[email protected]>
Changed-By: Petter Reinholdtsen <[EMAIL PROTECTED]>
Description: 
 initscripts - Scripts for initializing and shutting down the system
 sysv-rc    - System-V-like runlevel change mechanism
 sysvinit   - System-V-like init utilities
 sysvinit-utils - System-V-like utilities
Closes: 390936 391115 391122 391312
Changes: 
 sysvinit (2.86.ds1-33) unstable; urgency=low
 .
   * Do not insert /dev/.static/dev in /etc/mtab, and do not try to
     umount it either.  Avoids confusing users. (Closes: #391122)
   * Let initscripts conflict with udev << 0.080-1, and stop calling
     mountdevsub.sh from mtab.sh. (Closes: #391312)
   * Do not fail to install initscripts even if /lib/init/rw/ can
     not be mounted. (Closes: #391115)
   * Adjust how fuser is called by umountnfs, using the exit code from
     fuser instead of looking at its output. Based on patch from Markus
     Schoder. (Closes: 390936)
Files: 
 c942df04b90792cc4538142ab438703a 910 admin required sysvinit_2.86.ds1-33.dsc
 1aa5d5de40fc3885f82d9737fc4fef19 135088 admin required 
sysvinit_2.86.ds1-33.diff.gz
 6e1958ff3297a5b0a809086f906e4e6e 108846 admin required 
sysvinit_2.86.ds1-33_i386.deb
 73582cfe5b9a3328365390664fc32a2e 64726 admin required 
sysvinit-utils_2.86.ds1-33_i386.deb
 60a6f080b157846fcc056fa670511486 57996 admin required 
initscripts_2.86.ds1-33_i386.deb
 34db4e103f3fbcd0c0ea8ce3f6c0ffe5 56168 admin required 
sysv-rc_2.86.ds1-33_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFJpig20zMSyow1ykRAopfAKCYGz2DPe+6gyiFOUMIYvFLI3TiBwCgm75M
A09Lv9eBvr0fDi137Lm8tUU=
=ARFt
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to