Your message dated Tue, 10 Oct 2006 02:09:25 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#392010: fixed in nsca 2.6-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Subject: nsca: crashes on malformed command line
Package: nsca
Version: 2.6-1
Severity: normal
Tags: patch
Hello,
the send_nsca command crashes when you give it a command line containing
the -c or -d parameters with data containing "%n" format strings:
[EMAIL PROTECTED]:~$ /usr/sbin/send_nsca -c %n%n%n%n
Segmentation fault
[EMAIL PROTECTED]:~$ /usr/sbin/send_nsca -d %n%n%n%n
Segmentation fault
[EMAIL PROTECTED]:~$
This is caused by two broken snprintf() calls, that can be fixed by
applying my attached patch.
Format string bugs such as these sometimes cause security issues, but I see
no security implications of this bug whatsoever. As the send_nsca binary is
not set to setuid or setgid anything, the person that runs it already has
all the permissions that the program has. It is still a bug that should be
fixed in the interest of achieving as high quality and stability as possible.
// Ulf Harnhammar
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-1-686
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Versions of packages nsca depends on:
ii libc6 2.3.6.ds1-4 GNU C Library: Shared libraries
ii libmcrypt4 2.5.7-5 De-/Encryption Library
nsca recommends no packages.
-- debconf information:
nsca/run-nsca-daemon:
--- src/send_nsca.c.old 2006-04-06 23:19:30.000000000 +0200
+++ src/send_nsca.c 2006-10-09 20:47:10.000000000 +0200
@@ -421,7 +421,7 @@ int process_arguments(int argc, char **a
/* config file */
else if(!strcmp(argv[x-1],"-c")){
if(x<argc){
-
snprintf(config_file,sizeof(config_file),argv[x]);
+
snprintf(config_file,sizeof(config_file),"%s",argv[x]);
config_file[sizeof(config_file)-1]='\x0';
x++;
}
@@ -432,7 +432,7 @@ int process_arguments(int argc, char **a
/* delimiter to use when parsing input */
else if(!strcmp(argv[x-1],"-d")){
if(x<argc){
- snprintf(delimiter,sizeof(delimiter),argv[x]);
+
snprintf(delimiter,sizeof(delimiter),"%s",argv[x]);
delimiter[sizeof(delimiter)-1]='\x0';
x++;
}
--- End Message ---
--- Begin Message ---
Source: nsca
Source-Version: 2.6-2
We believe that the bug you reported is fixed in the latest version of
nsca, which is due to be installed in the Debian FTP archive:
nsca_2.6-2.diff.gz
to pool/main/n/nsca/nsca_2.6-2.diff.gz
nsca_2.6-2.dsc
to pool/main/n/nsca/nsca_2.6-2.dsc
nsca_2.6-2_i386.deb
to pool/main/n/nsca/nsca_2.6-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
sean finney <[EMAIL PROTECTED]> (supplier of updated nsca package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 09 Oct 2006 23:59:21 +0200
Source: nsca
Binary: nsca-client nsca
Architecture: source i386
Version: 2.6-2
Distribution: unstable
Urgency: low
Maintainer: Debian Nagios Maintainer Group <[EMAIL PROTECTED]>
Changed-By: sean finney <[EMAIL PROTECTED]>
Description:
nsca - Nagios service monitor agent
Closes: 382925 392010
Changes:
nsca (2.6-2) unstable; urgency=low
.
[sean finney]
* include fix for format-string crashing, thanks to Ulf Harnhammar
for the thorough description and clean patch. closes: #392010.
* new Czech debconf translations, thanks to Martin Å Ãn (closes: #382925).
* lintian fix: add debconf dependency.
* lintian ignore: multiple update-rc.d calls in postinst (resulting
from the script enabling/disabling code).
Files:
b3a4585ba5cf5ed23de99d6abf7ffa37 702 net optional nsca_2.6-2.dsc
87b72a4a601e69683e489204cd2e8828 12466 net optional nsca_2.6-2.diff.gz
ec5d476698cbbbe69ff2df10bdee70e5 35614 net optional nsca_2.6-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
iD8DBQFFKs2BynjLPm522B0RAqf5AJ9RUu8uJwsN1cQ62C+qL+DNJp4RTwCfVECP
Qfpq/PJZlkeQm8pbXeH1CKg=
=cnMA
-----END PGP SIGNATURE-----
--- End Message ---
