Your message dated Sat, 14 Oct 2006 05:47:03 -0700 with message-id <[EMAIL PROTECTED]> and subject line Bug#392835: fixed in msntp 1.6.dfsg-2 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: msntp Version: 1.6.dfsg-1 Hi, I was trying out msntp with an IP number as argument. Msntp does a gethostbyaddr() on that, and if it fails, it says "unable to locate IP address/number" and exits. There does not seem to be any reason to do a reverse lookup (other than printing the hostname to stderr). I fixed it with the following patch: --- internet.c.orig 2006-10-13 15:05:49.718249082 -0400 +++ internet.c 2006-10-13 15:12:23.039705583 -0400 @@ -80,22 +80,19 @@ if (! isdigit(hostname[0])) { errno = 0; host = gethostbyname(hostname); + if (host == NULL) fatal(1,"unable to locate IP address/number",NULL); + if (host->h_length != sizeof(struct in_addr)) + fatal(0,"the address does not seem to be an Internet one",NULL); + *address = *((struct in_addr **)host->h_addr_list)[0]; } else { - if ((ipaddr = inet_addr(hostname)) == (unsigned long)-1) + if(!inet_aton(hostname, address)) fatal(0,"invalid IP number %s",hostname); - network_to_address(address,ipaddr); errno = 0; - host = gethostbyaddr((void *)address,sizeof(struct in_addr), - AF_INET); } /* Now clear the timer and check the result. */ clear_alarm(); - if (host == NULL) fatal(1,"unable to locate IP address/number",NULL); - if (host->h_length != sizeof(struct in_addr)) - fatal(0,"the address does not seem to be an Internet one",NULL); - *address = *((struct in_addr **)host->h_addr_list)[0]; if (memcmp(address,nowhere,sizeof(struct in_addr)) == 0 || memcmp(address,anywhere,sizeof(struct in_addr)) == 0 || memcmp(address,everywhere,sizeof(struct in_addr)) == 0) @@ -103,7 +100,7 @@ if (verbose) fprintf(stderr, "%s: using NTP server %s (%s)\n", - argv0,host->h_name,inet_ntoa(*address)); + argv0,hostname,inet_ntoa(*address)); } /* Find out the port number (usually from /etc/services), and leave it in cheers, Eric
--- End Message ---
--- Begin Message ---Source: msntp Source-Version: 1.6.dfsg-2 We believe that the bug you reported is fixed in the latest version of msntp, which is due to be installed in the Debian FTP archive: msntp_1.6.dfsg-2.diff.gz to pool/main/m/msntp/msntp_1.6.dfsg-2.diff.gz msntp_1.6.dfsg-2.dsc to pool/main/m/msntp/msntp_1.6.dfsg-2.dsc msntp_1.6.dfsg-2_i386.deb to pool/main/m/msntp/msntp_1.6.dfsg-2_i386.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Adam Cécile (Le_Vert) <[EMAIL PROTECTED]> (supplier of updated msntp package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Sat, 14 Oct 2006 02:54:57 +0200 Source: msntp Binary: msntp Architecture: source i386 Version: 1.6.dfsg-2 Distribution: unstable Urgency: low Maintainer: Adam Cécile (Le_Vert) <[EMAIL PROTECTED]> Changed-By: Adam Cécile (Le_Vert) <[EMAIL PROTECTED]> Description: msntp - A very simple and portable SNTP client/server Closes: 392835 Changes: msntp (1.6.dfsg-2) unstable; urgency=low . * Merge patch from Eric Lammerts <[EMAIL PROTECTED]> to avoid a reverse IP lookup failure leading to fatal error. (Closes: #392835). Files: 166193095e2724c8c0af9d2b4a3ddb49 576 net optional msntp_1.6.dfsg-2.dsc 923c8edc4ddd308c99dc60b57c9bfe00 3619 net optional msntp_1.6.dfsg-2.diff.gz d4432916836e196c99fe731597dfdde4 37324 net optional msntp_1.6.dfsg-2_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFFMNkJeYl9593Atw0RAnobAJ4zBo2YgaRAnzyJKvSIuOKlOMZ26ACgjYBg P7STDXnia2vPs1b+0iKm8AQ= =xv8Q -----END PGP SIGNATURE-----
--- End Message ---
