Your message dated Sun, 15 Oct 2006 09:02:15 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#392012: fixed in redcloth 3.0.99.0.svn.20060519-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: redcloth
Version: 3.0.4-2
Severity: normal
Tags: patch

Hi,

When using the notextile modifier, double equalsign (==), the directive is
disregarded, while using the <notextile/> pseudo tag it DOES work:

>> RedCloth.new("This is ==_not working_==.").to_html
=> "<p>This is <em>not working</em>.</p>"
>> RedCloth.new("But this is <notextile>_working_</notextile>.").to_html
=> "<p>But this is _working_.</p>"

I found out after some debugging that this happens case because rip_offtags()
is called _before_ no_textile().  I have attached a patch that fixes this.
It also adjusts the notextile regexps somewhat to remove the needless match
for .*? after matching [^=]+ making it actually equal to [^=]+?.

Regards,

Paul

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (102, 'experimental')
Architecture: powerpc (ppc)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.18-1-powerpc
Locale: LANG=C, LC_CTYPE=nl_NL.UTF8 (charmap=UTF-8)
--- lib/redcloth.rb.orig        2006-10-09 20:22:16.000000000 +0200
+++ lib/redcloth.rb     2006-10-09 18:56:23.000000000 +0200
@@ -293,8 +293,8 @@
 
         # start processor
         @pre_list = []
-        rip_offtags text
         no_textile text
+        rip_offtags text
         hard_break text 
         unless @lite_mode
             refs text
@@ -936,9 +936,9 @@
     end
 
     def no_textile( text ) 
-        text.gsub!( /(^|\s)==([^=]+.*?)==(\s|$)?/,
+        text.gsub!( /(^|\s)==([^=]+?)==(\s|$)?/,
             '\1<notextile>\2</notextile>\3' )
-        text.gsub!( /^ *==([^=]+.*?)==/m,
+        text.gsub!( /^ *==([^=]+?)==/m,
             '\1<notextile>\2</notextile>\3' )
     end
 

--- End Message ---
--- Begin Message ---
Source: redcloth
Source-Version: 3.0.99.0.svn.20060519-1

We believe that the bug you reported is fixed in the latest version of
redcloth, which is due to be installed in the Debian FTP archive:

libredcloth-ruby1.8_3.0.99.0.svn.20060519-1_all.deb
  to pool/main/r/redcloth/libredcloth-ruby1.8_3.0.99.0.svn.20060519-1_all.deb
libredcloth-ruby_3.0.99.0.svn.20060519-1_all.deb
  to pool/main/r/redcloth/libredcloth-ruby_3.0.99.0.svn.20060519-1_all.deb
redcloth_3.0.99.0.svn.20060519-1.diff.gz
  to pool/main/r/redcloth/redcloth_3.0.99.0.svn.20060519-1.diff.gz
redcloth_3.0.99.0.svn.20060519-1.dsc
  to pool/main/r/redcloth/redcloth_3.0.99.0.svn.20060519-1.dsc
redcloth_3.0.99.0.svn.20060519.orig.tar.gz
  to pool/main/r/redcloth/redcloth_3.0.99.0.svn.20060519.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Borodaenko <[EMAIL PROTECTED]> (supplier of updated redcloth package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 15 Oct 2006 16:28:51 +0100
Source: redcloth
Binary: libredcloth-ruby libredcloth-ruby1.8
Architecture: source all
Version: 3.0.99.0.svn.20060519-1
Distribution: unstable
Urgency: low
Maintainer: Dmitry Borodaenko <[EMAIL PROTECTED]>
Changed-By: Dmitry Borodaenko <[EMAIL PROTECTED]>
Description: 
 libredcloth-ruby - Textile module for Ruby
 libredcloth-ruby1.8 - Textile module for Ruby 1.8
Closes: 389370 392012
Changes: 
 redcloth (3.0.99.0.svn.20060519-1) unstable; urgency=low
 .
   * Subversion snapshot of RedCloth 3.1.
     - includes main part of notextile fix by Paul van Tilburg
       (Closes: #392012)
     - forward-ported Paul van Tilburg's fix for (*) and (**) from 3.0.4-2
     - removed fix for (_), as it breaks more important test cases
   * notextile modifier regexp cleanup by Paul van Tilburg.
   * 'x' between numerics fixed (Closes: #389370).
   * Improved and included infinite loop fix by Fabien Penso on
     redcloth-upwards ML.
Files: 
 a08c01003fd3ade0dc68802a32aa5f04 669 interpreters optional 
redcloth_3.0.99.0.svn.20060519-1.dsc
 3fa702f0e7480ee9e2f2122c9250e382 55887 interpreters optional 
redcloth_3.0.99.0.svn.20060519.orig.tar.gz
 6a30984da89aea4f076499cc0755acc3 4016 interpreters optional 
redcloth_3.0.99.0.svn.20060519-1.diff.gz
 76161716a99988e545c2a94cc45d667a 5556 interpreters optional 
libredcloth-ruby_3.0.99.0.svn.20060519-1_all.deb
 d8c8f944c0bb450aeb27513c38bcd301 67986 interpreters optional 
libredcloth-ruby1.8_3.0.99.0.svn.20060519-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iEYEARECAAYFAkUyVFAACgkQxhqJXoXuPg77uACfdSrSbEcu/XFbs8cSAq3U3HbG
gP0An36UWYl2xzhI5WPHj8fDjscjULDZ
=qHDN
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to