Your message dated Sat, 28 Oct 2006 08:02:32 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#292587: fixed in enlightenment 1:0.16.7.2-5
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: enlightenment
Version: 1:0.16.6-3
Tags: patch
Hi!
I recently found out that having one's config dir
on a NFS share is a bad idea. Enlightenment names its
background-thumbnail-files after inode, m/ctime and
_device_ of the original file, which is a little
pointless when the device number is in the anonymous
range (that is, majors 0 and 144-146): Everytime the
share is mounted it is (most probably) assigned a
different device number, causing the entire background
cache to be rebuilt. Even worse, the old entries in
the session config and the thumbnails itself are not
deleted, so you accumulate a _LOT_ of redundant data
by and by.
Simply mapping all anonymous device numbers to a
single number in the same range fixes the problem -
patch is attached. It modifies code in:
- file.c:filedev()
- menus.c:MenuCreateFromDirectory()
and, as I stumbled across it, two typos (copy&paste
errors, to be exact) in the vicinity, namely the EDBUG()
function-entry message of
- file.c:fileinode() and filedev()
The problem exists upstream - I've sent a similar
mail to [EMAIL PROTECTED], but am still
awaiting list moderator approval; and as that's already
a week ago, I'm now also filing against the Debian
package to get things fixed for this distro at least.
I hope this is helpful and I didn't miss a reason why
enlightenment's current behaviour might be intentional...
Regards,
Jan Nordholz
Attachment: Patch for the latest upstream source (0.16.7.2)
--
Jan Nordholz
<[EMAIL PROTECTED]>
<[EMAIL PROTECTED]>
diff -Naur e16/src/file.c e16_new/src/file.c
--- e16/src/file.c Fri Aug 20 23:35:46 2004
+++ e16_new/src/file.c Mon Jan 24 13:05:44 2005
@@ -300,7 +300,7 @@
{
struct stat st;
- EDBUG(9, "filesize");
+ EDBUG(9, "fileinode");
if ((!s) || (!*s))
EDBUG_RETURN(0);
if (stat(s, &st) < 0)
@@ -313,11 +313,17 @@
{
struct stat st;
- EDBUG(9, "filesize");
+ EDBUG(9, "filedev");
if ((!s) || (!*s))
EDBUG_RETURN(0);
if (stat(s, &st) < 0)
EDBUG_RETURN(0);
+
+ /* device numbers in the anonymous range can't be relied
+ upon, so map them all on a single one */
+ if ((st.st_dev>>8)==0 || (st.st_dev>>8)==144 || \
+ (st.st_dev>>8)==145 || (st.st_dev>>8)==146)
+ EDBUG_RETURN(1);
EDBUG_RETURN((int)st.st_dev);
}
diff -Naur e16/src/menus.c e16_new/src/menus.c
--- e16/src/menus.c Fri Aug 20 23:35:46 2004
+++ e16_new/src/menus.c Mon Jan 24 12:47:23 2005
@@ -1091,6 +1091,7 @@
aa = (int)st.st_ino;
bb = (int)st.st_dev;
+ if ((bb>>8)==0 || (bb>>8)==144 || (bb>>8)==145 || (bb>>8)==146)
bb=(int)1;
cc = 0;
if (st.st_mtime > st.st_ctime)
cc = st.st_mtime;
@@ -1215,6 +1216,7 @@
aa = (int)st.st_ino;
bb = (int)st.st_dev;
+ if ((bb>>8)==0 || (bb>>8)==144 || (bb>>8)==145 || (bb>>8)==146)
bb=(int)1;
cc = 0;
if (st.st_mtime > st.st_ctime)
cc = st.st_mtime;
--- End Message ---
--- Begin Message ---
Source: enlightenment
Source-Version: 1:0.16.7.2-5
We believe that the bug you reported is fixed in the latest version of
enlightenment, which is due to be installed in the Debian FTP archive:
enlightenment-data_0.16.7.2-5_i386.deb
to pool/main/e/enlightenment/enlightenment-data_0.16.7.2-5_i386.deb
enlightenment-theme-bluesteel_0.16.7.2-5_all.deb
to pool/main/e/enlightenment/enlightenment-theme-bluesteel_0.16.7.2-5_all.deb
enlightenment-theme-brushedmetal_0.16.7.2-5_all.deb
to
pool/main/e/enlightenment/enlightenment-theme-brushedmetal_0.16.7.2-5_all.deb
enlightenment-theme-ganymede_0.16.7.2-5_all.deb
to pool/main/e/enlightenment/enlightenment-theme-ganymede_0.16.7.2-5_all.deb
enlightenment-theme-shinymetal_0.16.7.2-5_all.deb
to pool/main/e/enlightenment/enlightenment-theme-shinymetal_0.16.7.2-5_all.deb
enlightenment_0.16.7.2-5.diff.gz
to pool/main/e/enlightenment/enlightenment_0.16.7.2-5.diff.gz
enlightenment_0.16.7.2-5.dsc
to pool/main/e/enlightenment/enlightenment_0.16.7.2-5.dsc
enlightenment_0.16.7.2-5_i386.deb
to pool/main/e/enlightenment/enlightenment_0.16.7.2-5_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Laurence J. Lane <[EMAIL PROTECTED]> (supplier of updated enlightenment package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 28 Oct 2006 09:52:27 -0400
Source: enlightenment
Binary: enlightenment-theme-shinymetal enlightenment-theme-brushedmetal
enlightenment-data enlightenment-theme-bluesteel enlightenment
enlightenment-theme-ganymede
Architecture: source all i386
Version: 1:0.16.7.2-5
Distribution: unstable
Urgency: low
Maintainer: Laurence J. Lane <[EMAIL PROTECTED]>
Changed-By: Laurence J. Lane <[EMAIL PROTECTED]>
Description:
enlightenment - The Enlightenment Window Manager
enlightenment-data - Enlightenment Window Manager Run Time Data Files
enlightenment-theme-bluesteel - Hunchback's BlueSteel theme for E
enlightenment-theme-brushedmetal - Tigert's BrushedMEtal-Tigert E theme
enlightenment-theme-ganymede - cK's Ganymede theme for E
enlightenment-theme-shinymetal - Raster's ShinyMetal Theme for E
Closes: 292587
Changes:
enlightenment (1:0.16.7.2-5) unstable; urgency=low
.
* fixed cache file build problem up on NFS mounts. Reported and fixed
by Jan Christoph Nordholz. Thanks. closes: #292587
Files:
a51aeba6628dd849e8930fb50b275355 936 x11 optional enlightenment_0.16.7.2-5.dsc
8248aecbe9fa17387ba7c95977ea92e4 55705 x11 optional
enlightenment_0.16.7.2-5.diff.gz
4832a34ba648bbd6a3891f3736115dd8 3923762 x11 optional
enlightenment-theme-brushedmetal_0.16.7.2-5_all.deb
6743b321600c477ac4c2882a50fcd6c7 1305158 x11 optional
enlightenment-theme-shinymetal_0.16.7.2-5_all.deb
e8d21824144c418119294ce3b79a7cea 826838 x11 optional
enlightenment-theme-bluesteel_0.16.7.2-5_all.deb
48dad7dcbf32f152c3408262909bb6e8 2560990 x11 optional
enlightenment-theme-ganymede_0.16.7.2-5_all.deb
e9b858c322ce463b253b73087a299b5f 419262 x11 optional
enlightenment_0.16.7.2-5_i386.deb
bbdd8a7e911561c41fcf55cc60d90708 2667180 x11 optional
enlightenment-data_0.16.7.2-5_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
iD8DBQFFQ2TYxJBkNlXToekRAknuAJ4m2Msz5YOVOtMkqn3k5+BWmDCcGACfdp6l
8Oz1stLNW1Ja1ofFfnWFnk8=
=nfjn
-----END PGP SIGNATURE-----
--- End Message ---
