Your message dated Sun, 29 Oct 2006 07:17:09 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#231886: fixed in grip 3.3.1-11
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: grip
Version: 3.1.4-1
Severity: normal
Tags: patch

In an attempt to normalise the volume levels of my music, I selected
"calculate gain adjustment" and "delay encoding until disc is ripped".
The album gain passed to the MP3 encoder by the %R tag was the value for
the previous album.

The cause is that FillInTrackInfo() is called before the album gain is
known. My solution is for the %R tag to return the data from the ginfo
structure.  This may not be the ideal solution, as I am not yet sure
of the lifetime of the ginfo structure, but it has worked for a small
scale test here.

--- upstream/src/rip.c  2004-02-09 13:04:18.000000000 +0000
+++ new/src/rip.c       2004-02-09 12:58:54.000000000 +0000
@@ -1214,7 +1214,7 @@
     *munge=FALSE;
     break;
   case 'R':
-    g_snprintf(res,PATH_MAX,"%+6.2f",enc_track->disc_gain_adjustment);
+    g_snprintf(res,PATH_MAX,"%+6.2f",enc_track->ginfo->disc_gain_adjustment);
     *munge=FALSE;
     break;
 #endif

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.24-pre2
Locale: LANG=C, LC_CTYPE=C

Versions of packages grip depends on:
ii  libart-2.0-2              2.3.16-1       Library of functions for 2D graphi
ii  libatk1.0-0               1.4.1-1        The ATK accessibility toolkit
ii  libaudiofile0             0.2.3-4        The Audiofile Library
ii  libbonobo2-0              2.4.3-1        Bonobo CORBA interfaces library
ii  libbonoboui2-0            2.4.3-1        The Bonobo UI library
ii  libc6                     2.3.2.ds1-11   GNU C Library: Shared libraries an
ii  libcdparanoia0            3a9.8-10       Shared libraries for cdparanoia (r
ii  libesd0                   0.2.29-1       Enlightened Sound Daemon - Shared 
ii  libfontconfig1            2.2.1-13       generic font configuration library
ii  libfreetype6              2.1.7-2        FreeType 2 font engine, shared lib
ii  libgcc1                   1:3.3.3-0pre3  GCC support library
ii  libgconf2-4               2.4.0.1-3      GNOME configuration database syste
ii  libgcrypt1                1.1.12-4       LGPL Crypto library - runtime libr
ii  libghttp1                 1.0.9-15       original GNOME HTTP client library
ii  libglib2.0-0              2.2.3-1        The GLib library of C routines
ii  libgnome2-0               2.4.0-4        The GNOME 2 library - runtime file
ii  libgnomecanvas2-0         2.4.0-1        A powerful object-oriented display
ii  libgnomeui-0              2.4.0.1-6      The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0            2.4.1-4.1      The GNOME virtual file-system libr
ii  libgnomevfs2-common       2.4.1-4.1      The GNOME virtual file-system libr
ii  libgnutls7                0.8.12-5       GNU TLS library - runtime library
ii  libgtk2.0-0               2.2.4-3        The GTK+ graphical user interface 
ii  libid3-3.8.3              3.8.3-3        Library for manipulating ID3v1 and
ii  libjpeg62                 6b-9           The Independent JPEG Group's JPEG 
ii  libncurses5               5.3.20030719-5 Shared libraries for terminal hand
ii  liborbit2                 1:2.8.3-2      libraries for ORBit2 - a CORBA ORB
ii  libpango1.0-0             1.2.5-2.1      Layout and rendering of internatio
ii  libpopt0                  1.7-4          lib for parsing cmdline parameters
ii  libstdc++5                1:3.3.3-0pre3  The GNU Standard C++ Library v3
ii  libtasn1-0                0.1.2-1        Manage ASN.1 structures (runtime)
ii  libvte4                   1:0.11.10-3    Terminal emulator widget for GTK+ 
ii  libxft2                   2.1.2-5        FreeType-based font drawing librar
ii  libxml2                   2.6.5-1        GNOME XML library
ii  libxrender1               0.8.3-5        X Rendering Extension client libra
ii  xlibs                     4.2.1-16       X Window System client libraries
ii  zlib1g                    1:1.2.1-3      compression library - runtime

-- no debconf information




--- End Message ---
--- Begin Message ---
Source: grip
Source-Version: 3.3.1-11

We believe that the bug you reported is fixed in the latest version of
grip, which is due to be installed in the Debian FTP archive:

grip_3.3.1-11.diff.gz
  to pool/main/g/grip/grip_3.3.1-11.diff.gz
grip_3.3.1-11.dsc
  to pool/main/g/grip/grip_3.3.1-11.dsc
grip_3.3.1-11_i386.deb
  to pool/main/g/grip/grip_3.3.1-11_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <[EMAIL PROTECTED]> (supplier of updated grip package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 29 Oct 2006 15:58:00 +0100
Source: grip
Binary: grip
Architecture: source i386
Version: 3.3.1-11
Distribution: unstable
Urgency: medium
Maintainer: Daniel Baumann <[EMAIL PROTECTED]>
Changed-By: Daniel Baumann <[EMAIL PROTECTED]>
Description: 
 grip       - GNOME-based CD-player/ripper/encoder
Closes: 38447 231886 269596
Changes: 
 grip (3.3.1-11) unstable; urgency=medium
 .
   * Added patch from Adrian Cox <[EMAIL PROTECTED]> to apply album gain
     adjustment to the right album (Closes: #231886).
   * Added patch from Matt Zimmerman <[EMAIL PROTECTED]> to call executables in
     path (Closes: #269596, #38447).
Files: 
 8471706c6a993c1af7abadcc4a8d3c32 760 gnome optional grip_3.3.1-11.dsc
 db7f2001c8c400a84a0130896925a23d 42468 gnome optional grip_3.3.1-11.diff.gz
 b7dbb0c3d1790fcac9e121374b984053 470524 gnome optional grip_3.3.1-11_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFRMT3+C5cwEsrK54RAijSAJ415ia0OFIWM4qqakUEyIuxLBsTWACgyeBu
pNeljCXCKxPA+J5TONfeD5U=
=+i3n
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to