Your message dated Mon, 13 Nov 2006 05:02:18 -0800 with message-id <[EMAIL PROTECTED]> and subject line Bug#224921: fixed in gq 1.2.1-1 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: gq Version: 0.6.0-4 Severity: wishlist Tags: patch New feature: If gq asks your bind password, it will ask your bind DN as well. How to use: Just tick "ask password on first connect" on details related to the server. What if I want to relogin in another name? Browse the server's schema,and do a refresh. This will disconnect you from the server, and in the next connect, your dn and password will be asked. What is ugly in this? More ugly things;) 1. query_popup is modified in an ugly manner. 2. there should have been a different option for this, but I haven't created one. -- System Information: Debian Release: testing/ezmegmindigstabilabb Architecture: i386 Kernel: Linux kusturica 2.4.23-rsbac #3 2003. dec. 8., hétfő, 19.26.08 CET i686 Locale: LANG=hu_HU, LC_CTYPE=hu_HU Versions of packages gq depends on: ii libc6 2.3.2-7 GNU C Library: Shared libraries an ii libgdk-pixbuf2 0.22.0-3 The GdkPixBuf image library, gtk+ ii libglib1.2 1.2.10-9 The GLib library of C routines ii libgtk1.2 1.2.10-16 The GIMP Toolkit set of widgets fo ii libldap2 2.1.22-1 OpenLDAP libraries ii libssl0.9.7 0.9.7c-1 SSL shared libraries ii xlibs 4.2.1-12.1 X Window System client libraries -- no debconf informationA .arch-ids/README.dnask.id A README.dnask M src/util.c M src/util.h * modified files --- orig/src/util.c +++ mod/src/util.c @@ -255,14 +255,18 @@ } if (server->ask_pw && - server->binddn[0] != 0 && /* makes sense only if we bind as someone */ /* server->bindpw[0] == 0 && */ server->enteredpw[0] == 0) { - char *ret; + char *ret=server->binddn; + snprintf(message, sizeof(message), + _("Bind DN for server %s"), server->ldaphost); + query_popup(message, &ret, FALSE,sizeof(server->binddn)); + + ret=NULL; snprintf(message, sizeof(message), _("Password for server %s"), server->ldaphost); - if (query_popup(message, &ret, TRUE /* is_password */)) { + if (query_popup(message, &ret, TRUE /* is_password */,0)) { if (ret) { strncpy(server->enteredpw, ret, sizeof(server->enteredpw) - 1); @@ -302,6 +306,7 @@ error_flush(open_context); if (rc != LDAP_SUCCESS) { + server->enteredpw[0]=0; if (newpw) server->bindpw[0] = 0; } @@ -340,6 +345,7 @@ #endif /* definitely close this connection */ ldap_unbind(server->connection); + server->enteredpw[0]=0; server->connection = NULL; /* server->missing_closes = 0; */ } @@ -1153,7 +1159,7 @@ /* pops up a dialog to retrieve user data via a GtkEntry. This functions waits for the data and puts it into outbuf. */ -int query_popup(const char *title, gchar **outbuf, gboolean is_password) +int query_popup(const char *title, gchar **outbuf, gboolean is_password,size_t bufsize) { GtkWidget *window, *vbox1, *vbox2, *label, *inputbox, *button, *hbox0; int rc; @@ -1194,6 +1200,9 @@ gtk_box_pack_start(GTK_BOX(vbox1), label, TRUE, TRUE, 0); inputbox = gtk_entry_new(); + if(*outbuf) { + gtk_entry_set_text((GtkEntry *)inputbox,(gchar *) *outbuf); + } GTK_WIDGET_SET_FLAGS(inputbox, GTK_CAN_FOCUS); GTK_WIDGET_SET_FLAGS(inputbox, GTK_CAN_DEFAULT); @@ -1243,7 +1252,15 @@ rc = gtk_object_get_data(GTK_OBJECT(comm), "rc") != NULL; if (! gtk_object_get_data(GTK_OBJECT(comm), "destroyed") && rc) { - *outbuf = gtk_editable_get_chars(GTK_EDITABLE(inputbox), 0, -1); + gchar *p; + p = gtk_editable_get_chars(GTK_EDITABLE(inputbox), 0, -1); + if(*outbuf) + { + strncpy(*outbuf,p,bufsize); + g_free(p); + } else { + *outbuf = p; + } } else { rc = 0; *outbuf = NULL; --- orig/src/util.h +++ mod/src/util.h @@ -69,7 +69,7 @@ struct gq_template *find_template_by_name(char *templatename); void dump_mods(LDAPMod **mods); const char *find_s_by_at_oid(struct ldapserver *server, const char *oid); -int query_popup(const char *title, gchar **outbuf, gboolean is_password); +int query_popup(const char *title, gchar **outbuf, gboolean is_password, size_t bufsize); int question_popup(const char *title, const char *question); GList *get_suffixes(struct ldapserver *server);
--- End Message ---
--- Begin Message ---Source: gq Source-Version: 1.2.1-1 We believe that the bug you reported is fixed in the latest version of gq, which is due to be installed in the Debian FTP archive: gq_1.2.1-1.diff.gz to pool/main/g/gq/gq_1.2.1-1.diff.gz gq_1.2.1-1.dsc to pool/main/g/gq/gq_1.2.1-1.dsc gq_1.2.1-1_i386.deb to pool/main/g/gq/gq_1.2.1-1_i386.deb gq_1.2.1.orig.tar.gz to pool/main/g/gq/gq_1.2.1.orig.tar.gz A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Guido Trotter <[EMAIL PROTECTED]> (supplier of updated gq package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Mon, 13 Nov 2006 12:45:29 +0000 Source: gq Binary: gq Architecture: source i386 Version: 1.2.1-1 Distribution: experimental Urgency: low Maintainer: Guido Trotter <[EMAIL PROTECTED]> Changed-By: Guido Trotter <[EMAIL PROTECTED]> Description: gq - GTK-based LDAP client Closes: 224921 236127 365206 376882 Changes: gq (1.2.1-1) experimental; urgency=low . * New Upstream Release - can edit unix dates (closes: #365206) - includes freedesktop stype desktop file (closes: #376882) - can save new servers (closes: #236127) - ask for the bind dn as well as the password (closes: #224921) * Fix data/Makefile.am to fix wrong behaviour trying to install files outside of the specified $(DESTDIR) * Add build dependency on libxml-parser-perl, libgnome-keyring-dev, libgcrypt11-dev * Pass --disable-update-mimedb to configure and enable it via debhelper * Remove README.NLS and README.TLS from the shipped docs as they're not present upstream anymore Files: 5c4af925a210e926e98d7d14aaacbba1 678 net optional gq_1.2.1-1.dsc e56613c81e70727c20ffe9974cdc6df0 395701 net optional gq_1.2.1.orig.tar.gz 803799944a51731e9976f78c9ba01096 29702 net optional gq_1.2.1-1.diff.gz 49ff7caa8f4aedd3cd1de9f7965690d1 205590 net optional gq_1.2.1-1_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFFWGlnhImxTYgHUpsRAm6WAJ4jA6eC+2kYyb9Lnq1iq4W2JAbi+ACfa+/7 sQ/zdYNQUMMSfRoZrnGRaws= =ACP2 -----END PGP SIGNATURE-----
--- End Message ---
