Source: rplay
Version: 3.3.2-19
Tags: patch
User: debian-cr...@lists.debian.org
Usertags: ftcbfs
rplay fails to cross build from source, because it does not pass --host
to configure and thus attempts to build for the build architecture.
Earlier, it used a very old configure script and implemented cross
building via the CC variable. Now that dh_autoreconf is in use, we may
dispose that method and opt for dh_autoreconf instead.
As a result, dpkg-buildflags will be passed correctly and
-Werror=format-security triggers. This should be fixed properly
eventually. In order to not regress building, I'm attaching a patch that
disables format flags in hardening but leaves others enabled. Please
consider applying it.
Helmut
diff --minimal -Nru rplay-3.3.2/debian/changelog rplay-3.3.2/debian/changelog
--- rplay-3.3.2/debian/changelog 2024-08-07 22:04:35.000000000 +0200
+++ rplay-3.3.2/debian/changelog 2024-11-07 13:22:40.000000000 +0100
@@ -1,3 +1,12 @@
+rplay (3.3.2-19.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: Use dh_auto_configure. (Closes: #-1)
+ * As a result, CFLAGS are now passed and we need to turn off
+ -Werror=format-security to avoid FTBFS.
+
+ -- Helmut Grohne <hel...@subdivi.de> Thu, 07 Nov 2024 13:22:40 +0100
+
rplay (3.3.2-19) unstable; urgency=medium
* fix gcc14 issues (Closes: #1075452)
diff --minimal -Nru rplay-3.3.2/debian/rules rplay-3.3.2/debian/rules
--- rplay-3.3.2/debian/rules 2024-08-07 22:04:35.000000000 +0200
+++ rplay-3.3.2/debian/rules 2024-11-07 13:22:40.000000000 +0100
@@ -2,13 +2,13 @@
# Made with the aid of debmake, by Christoph Lameter,
# based on the sample debian/rules file for GNU hello by Ian Jackson.
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all,-format
+
CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS)
CFLAGS:=$(shell dpkg-buildflags --get CFLAGS)
CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS)
LDFLAGS:=$(shell dpkg-buildflags --get LDFLAGS)
-export DEB_BUILD_MAINT_OPTIONS = hardening=+all
-
CFLAGS += " -D_REENTRANT"
CFLAGS += $CPPFLAGS
@@ -16,11 +16,6 @@
include /usr/share/dpkg/architecture.mk
-ifeq ($(origin CC),default)
-CC = $(DEB_HOST_GNU_TYPE)-gcc
-endif
-export CC
-
i = $(shell pwd)/debian/tmp
b = $(shell pwd)/debian/build
@@ -38,7 +33,7 @@
autoupdate
dh_autoreconf
- ./configure --prefix=/usr --sysconfdir=/etc/rplay --without-x \
+ dh_auto_configure -- --sysconfdir=/etc/rplay --without-x \
--enable-rplayd-user=nobody --enable-rplayd-group=audio
cat ./include/config.h
