Bug#1089285: argus: Supporting rootless builds by default

Niels Thykier Sat, 07 Dec 2024 10:48:29 -0800

Source: argus
Version: 2:3.0.8.2-2.3
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue


Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
argus failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

ArgusSource.c: In function ‘setArgusDevice’:

ArgusSource.c:870:19: warning: ‘pcap_lookupdev’ is deprecated: use 'pcap_findalldevs' and use the first device [-Wdeprecated-declarations] 870 | setArgusDevice (src, pcap_lookupdev (errbuf), ARGUS_LIVE_DEVICE, 0);

      |                   ^~~~~~~~~~~~~~
In file included from /usr/include/pcap.h:43,
                 from ./ArgusOutput.h:66,
                 from ./ArgusUtil.h:129,
                 from ./ArgusModeler.h:331,
                 from ./argus.h:40,
                 from ArgusSource.c:67:
/usr/include/pcap/pcap.h:444:18: note: declared here
  444 | PCAP_API char   *pcap_lookupdev(char *);
      |                  ^~~~~~~~~~~~~~

gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusIgmp.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusEsp.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusArp.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusFrag.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusUdt.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusLcp.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusIsis.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusAuth.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c Argus802.11.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusApp.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusEvents.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusNetflow.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -c ArgusSflow.c gcc -O -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I/usr/include/tirpc -fno-strict-aliasing -I. -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -I./../include -DHAVE_CONFIG_H -o ../bin/argus argus.o ArgusModeler.o ArgusSource.o ArgusUtil.o ArgusOutput.o ArgusUdp.o ArgusTcp.o ArgusIcmp.o ArgusIgmp.o ArgusEsp.o ArgusArp.o ArgusFrag.o ArgusUdt.o ArgusLcp.o ArgusIsis.o ArgusAuth.o Argus802.11.o ArgusApp.o ArgusEvents.o ArgusNetflow.o ArgusSflow.o -Wl,-z,relro ../lib/argus_common.a -lm -ltirpc -lpcap -lpthread -lwrap -lnsl -lm -lz

make[2]: Leaving directory '/<<PKGBUILDDIR>>/argus'
### Done with /<<PKGBUILDDIR>>/argus
### Making in /<<PKGBUILDDIR>>/events
make[2]: Entering directory '/<<PKGBUILDDIR>>/events'
make[2]: warning: -j8 forced in submake: resetting jobserver mode.
sed 's+@PERLBIN@+/usr/bin/perl+' argus-extip.pl > ../bin/argus-extip
sed 's+@PERLBIN@+/usr/bin/perl+' argus-lsof.pl > ../bin/argus-lsof
cp -f argus-snmp.sh ../bin/argus-snmp
cp -f argus-vmstat.sh ../bin/argus-vmstat
chmod +x ../bin/argus-extip
chmod +x ../bin/argus-lsof
make[2]: Leaving directory '/<<PKGBUILDDIR>>/events'
### Done with /<<PKGBUILDDIR>>/events
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_installdirs
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
chmod -x support/System/crontab support/System/magic
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_install
   dh_installdocs
   dh_installchangelogs
   dh_installexamples
   dh_installman
   debian/rules override_dh_installinit
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_installinit --noscripts --name argus
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_systemd_start
   dh_installlogrotate
   dh_lintian
   dh_perl
   dh_link
   dh_strip_nondeterminism
   dh_compress
   debian/rules override_dh_fixperms
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_fixperms
chmod 750 debian/argus-server/var/log/argus
chgrp adm debian/argus-server/var/log/argus

chgrp: changing group of 'debian/argus-server/var/log/argus': Operation not permitted

make[1]: *** [debian/rules:22: override_dh_fixperms] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:11: binary] Error 2

dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

--------------------------------------------------------------------------------
Build finished at 2024-11-15T19:09:17Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/973977.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089285: argus: Supporting rootless builds by default

Reply via email to