Source: bombardier
Version: 0.8.3+nmu3
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
bombardier failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
/usr/include/aarch64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 11 and 36 bytes into a destination of size 11
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
display.c: In function ‘display_state’:
display.c:223:5: warning: format not a string literal and no format arguments [-Wformat-security]
  223 |     if (state->text) mvprintw(gy(HEIGHT), gx(0), state->text);
      |     ^~
display.c:226:33: warning: format not a string literal and no format arguments [-Wformat-security]
  226 |     mvprintw(gy(HEIGHT-1),gx(0),earth);
      |                                 ^~~~~
display.c:261:5: warning: format not a string literal and no format arguments [-Wformat-security] 261 | mvprintw(gy(HEIGHT-1), gx(WIDTH/2-strlen(statusstr)/2), statusstr);
      |     ^~~~~~~~
display.c: In function ‘citycompute’:
display.c:211:13: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  211 |             asprintf(&ret,"Unnamed %d", citynum);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
display.c: In function ‘display_state’:
display.c:260:5: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 260 | asprintf(&statusstr, "Blocks: %.4d/%.4d, City: %15s (%.2d), Score: %7d", state->blocks, state->numofblocks, citycompute(state->city), state->city, state->score); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
step.c: In function ‘step_state_bomb’:
step.c:39:17: warning: format not a string literal and no format arguments [-Wformat-security] 39 | asprintf(&(state->text),texts[state->houses_text[state->bombx]].text);
      |                 ^~~~~~~~
step.c:39:17: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 39 | asprintf(&(state->text),texts[state->houses_text[state->bombx]].text); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c: In function ‘defhof’:
hof.c:44:5: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   44 |     write(fd, "Teller Ede          |1908-01-15|  16384\n", 40);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c:45:5: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   45 |     write(fd, "Szil�rd Le�         |1898-02-11|   8192\n", 40);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c:46:5: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   46 |     write(fd, "Neumann J�nos       |1903-12-28|   4096\n", 40);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c:47:5: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   47 |     write(fd, "G�bor D�nes         |1900-06-05|   2048\n", 40);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c:48:5: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   48 |     write(fd, "Bolyai J�nos        |1802-12-15|   1024\n", 40);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c:49:5: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   49 |     write(fd, "E�tv�s Lor�nd       |1848-07-27|    512\n", 40);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c:50:5: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   50 |     write(fd, "Horthy Mikl�s       |1800-00-00|    256\n", 40);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c:51:5: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   51 |     write(fd, "K�d�r J�nos         |1800-00-00|    128\n", 40);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c:52:5: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   52 |     write(fd, "R�kosi M�ty�s       |1892-00-00|     64\n", 40);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c: In function ‘hof’:
hof.c:136:21: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  136 |                     write(fd, linewrite, 40);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~
hof.c:148:21: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  148 |                     write(fd, linewrite, 40);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~
hof.c:134:41: warning: ‘%-20s’ directive writing between 20 and 188 bytes into a region of size 40 [-Wformat-overflow=] 134 | sprintf(linewrite, "%-20s|%10s|%7d", names[i], dates[i], scores[i]);
      |                                         ^~~~~
In file included from /usr/include/stdio.h:970,
                 from incs.h:7,
                 from bombardier.h:6,
                 from hof.c:6:
In function ‘sprintf’,
    inlined from ‘hof’ at hof.c:134:21:
/usr/include/aarch64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 40 and 300 bytes into a destination of size 40
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
hof.c: In function ‘hof’:
hof.c:146:41: warning: ‘%-20s’ directive writing between 20 and 188 bytes into a region of size 40 [-Wformat-overflow=] 146 | sprintf(linewrite, "%-20s|%10s|%7d", names[i], dates[i], scores[i]);
      |                                         ^~~~~
In function ‘sprintf’,
    inlined from ‘hof’ at hof.c:146:21:
/usr/include/aarch64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 40 and 300 bytes into a destination of size 40
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
aarch64-linux-gnu-gcc -o bombardier bombardier.o display.o date.o randomhouse.o step.o hof.o signal.o gcurses.o -Wl,-z,relro -lncurses
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_installdirs
   dh_auto_install --destdir=debian/bombardier/
make -j16 install DESTDIR=/<<BUILDDIR>>/bombardier-0.8.3\+nmu3/debian/bombardier AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true"
make[1]: Entering directory '/<<PKGBUILDDIR>>'
install -d /<<PKGBUILDDIR>>/debian/bombardier/usr/games
install bombardier /<<PKGBUILDDIR>>/debian/bombardier/usr/games
chgrp games /<<PKGBUILDDIR>>/debian/bombardier/usr/games/bombardier
chgrp: changing group of '/<<PKGBUILDDIR>>/debian/bombardier/usr/games/bombardier': Operation not permitted
make[1]: *** [Makefile:26: install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_install: error: make -j16 install DESTDIR=/<<BUILDDIR>>/bombardier-0.8.3\+nmu3/debian/bombardier AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:12: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2024-11-15T20:28:36Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/975393.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to