Bug#1089307: crossfire: Supporting rootless builds by default

[Niels Thykier]

Source: crossfire
Version: 1.75.0-8
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
crossfire failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

make[5]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfanim'
make[4]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfanim'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfanim'
Making install in common
make[3]: Entering directory '/<<PKGBUILDDIR>>/plugins/common'
Making install in include
make[4]: Entering directory '/<<PKGBUILDDIR>>/plugins/common/include'
make[5]: Entering directory '/<<PKGBUILDDIR>>/plugins/common/include'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/<<PKGBUILDDIR>>/plugins/common/include'
make[4]: Leaving directory '/<<PKGBUILDDIR>>/plugins/common/include'
make[4]: Entering directory '/<<PKGBUILDDIR>>/plugins/common'
make[5]: Entering directory '/<<PKGBUILDDIR>>/plugins/common'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/<<PKGBUILDDIR>>/plugins/common'
make[4]: Leaving directory '/<<PKGBUILDDIR>>/plugins/common'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/plugins/common'
Making install in cflogger
make[3]: Entering directory '/<<PKGBUILDDIR>>/plugins/cflogger'
make[4]: Entering directory '/<<PKGBUILDDIR>>/plugins/cflogger'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cflogger'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cflogger'
Making install in cfnewspaper
make[3]: Entering directory '/<<PKGBUILDDIR>>/plugins/cfnewspaper'
Making install in include
make[4]: Entering directory '/<<PKGBUILDDIR>>/plugins/cfnewspaper/include'
make[5]: Entering directory '/<<PKGBUILDDIR>>/plugins/cfnewspaper/include'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfnewspaper/include'
make[4]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfnewspaper/include'
make[4]: Entering directory '/<<PKGBUILDDIR>>/plugins/cfnewspaper'
make[5]: Entering directory '/<<PKGBUILDDIR>>/plugins/cfnewspaper'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfnewspaper'
make[4]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfnewspaper'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfnewspaper'
Making install in cfcitybell
make[3]: Entering directory '/<<PKGBUILDDIR>>/plugins/cfcitybell'
Making install in include
make[4]: Entering directory '/<<PKGBUILDDIR>>/plugins/cfcitybell/include'
make[5]: Entering directory '/<<PKGBUILDDIR>>/plugins/cfcitybell/include'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfcitybell/include'
make[4]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfcitybell/include'
make[4]: Entering directory '/<<PKGBUILDDIR>>/plugins/cfcitybell'
make[5]: Entering directory '/<<PKGBUILDDIR>>/plugins/cfcitybell'
make[5]: Nothing to be done for 'install-exec-am'.

make[5]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfcitybell'
make[4]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfcitybell'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/plugins/cfcitybell'
make[3]: Entering directory '/<<PKGBUILDDIR>>/plugins'
make[4]: Entering directory '/<<PKGBUILDDIR>>/plugins'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/<<PKGBUILDDIR>>/plugins'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/plugins'
make[2]: Leaving directory '/<<PKGBUILDDIR>>/plugins'
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[3]: Entering directory '/<<PKGBUILDDIR>>'
make[3]: Nothing to be done for 'install-exec-am'.
make[3]: Nothing to be done for 'install-data-am'.
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_install

   debian/rules override_dh_installdocs
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_installdocs -X/Makefile

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_installchangelogs

   dh_installman

   dh_installinit

   dh_installsystemd

   dh_installlogrotate

   dh_perl
   dh_link

   dh_strip_nondeterminism
   dh_compress

   debian/rules override_dh_fixperms
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_fixperms \
-X /var/games/crossfire \
-X /var/games/crossfire/datafiles \
-X /var/games/crossfire/players \
-X /var/games/crossfire/temp.maps \
-X /var/games/crossfire/unique-items
! test -e debian/crossfire-server || chown games:games \
debian/crossfire-server/var/log/crossfire \
debian/crossfire-server/var/games/crossfire \
debian/crossfire-server/var/games/crossfire/account \
debian/crossfire-server/var/games/crossfire/datafiles \
debian/crossfire-server/var/games/crossfire/players \
debian/crossfire-server/var/games/crossfire/temp.maps \
debian/crossfire-server/var/games/crossfire/unique-items

make[1]: *** [debian/rules:7: override_dh_fixperms] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:3: binary] Error 2

--------------------------------------------------------------------------------
Build finished at 2024-11-15T23:22:18Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/979211.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

libtool: install: /usr/bin/install -c .libs/cfanim.lai /<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins/cfanim.la libtool: install: /usr/bin/install -c .libs/cfanim.a /<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins/cfanim.a libtool: install: chmod 644 /<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins/cfanim.a libtool: install: ranlib /<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins/cfanim.a libtool: warning: remember to run 'libtool --finish /usr/lib/aarch64-linux-gnu/crossfire/plugins' /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins' /bin/bash ../../libtool --mode=install /usr/bin/install -c cfcitybell.la '/<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins' libtool: install: /usr/bin/install -c .libs/cfcitybell.so /<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins/cfcitybell.so libtool: install: /usr/bin/install -c .libs/cfcitybell.lai /<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins/cfcitybell.la libtool: install: /usr/bin/install -c .libs/cfcitybell.a /<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins/cfcitybell.a libtool: install: chmod 644 /<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins/cfcitybell.a libtool: install: ranlib /<<PKGBUILDDIR>>/debian/tmp/usr/lib/aarch64-linux-gnu/crossfire/plugins/cfcitybell.a libtool: warning: remember to run 'libtool --finish /usr/lib/aarch64-linux-gnu/crossfire/plugins' dh_install: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installdocs: warning: Cannot auto-detect main package for crossfire-doc. If the default is wrong, please use --doc-main-package dh_installchangelogs: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installman: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installinit: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installsystemd: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installlogrotate: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_link: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_compress: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_compress: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_compress: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). chown: changing ownership of 'debian/crossfire-server/var/log/crossfire': Operation not permitted chown: changing ownership of 'debian/crossfire-server/var/games/crossfire': Operation not permitted chown: changing ownership of 'debian/crossfire-server/var/games/crossfire/account': Operation not permitted chown: changing ownership of 'debian/crossfire-server/var/games/crossfire/datafiles': Operation not permitted chown: changing ownership of 'debian/crossfire-server/var/games/crossfire/players': Operation not permitted chown: changing ownership of 'debian/crossfire-server/var/games/crossfire/temp.maps': Operation not permitted chown: changing ownership of 'debian/crossfire-server/var/games/crossfire/unique-items': Operation not permitted dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

OpenPGP_signature.asc
Description: OpenPGP digital signature