Bug#1089345: icheck: Supporting rootless builds by default

[Niels Thykier]

Source: icheck
Version: 0.9.7-6.6
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
icheck failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
dh_testdir
dh_testroot
rm -f t/04_align/result.compare
/usr/bin/make clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
rm -f typegen.c typegen CType/Native.pm
/usr/bin/make -C ext/CParse-Parser-PerlXS clean
make[2]: Entering directory '/<<PKGBUILDDIR>>/ext/CParse-Parser-PerlXS'
make[2]: *** No rule to make target 'clean'.  Stop.
make[2]: Leaving directory '/<<PKGBUILDDIR>>/ext/CParse-Parser-PerlXS'
make[1]: [Makefile:5: clean] Error 2 (ignored)
rm -f ext/CParse-Parser-PerlXS/Makefile.old
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
rm -f debian/build-stamp
dh_clean

 debian/rules binary
dh_testdir
/usr/bin/make
make[1]: Entering directory '/<<PKGBUILDDIR>>'
./typegen.pl > typegen.c.new
mv typegen.c.new typegen.c
gcc -std=gnu99 -o typegen typegen.c
./typegen > CType/Native.pm.new
mv CType/Native.pm.new CType/Native.pm

Generating a Unix-style Makefile
Writing Makefile for CParse::Parser::PerlXS
Writing MYMETA.yml and MYMETA.json
/usr/bin/make -C ext/CParse-Parser-PerlXS
make[2]: Entering directory '/<<PKGBUILDDIR>>/ext/CParse-Parser-PerlXS'
cp PerlXS.pm blib/lib/CParse/Parser/PerlXS.pm
Running Mkbootstrap for PerlXS ()
chmod 644 "PerlXS.bs"

mv PerlXS.xsc PerlXS.c

rm -f blib/arch/auto/CParse/Parser/PerlXS/PerlXS.so

      \
  chmod 755 blib/arch/auto/CParse/Parser/PerlXS/PerlXS.so
make[2]: Leaving directory '/<<PKGBUILDDIR>>/ext/CParse-Parser-PerlXS'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
/usr/bin/make test
make[1]: Entering directory '/<<PKGBUILDDIR>>'
./test.pl t
Processing t/00_empty...
Processing t/01_fundamental...
Processing t/02_struct...
Processing t/03_baseline...
Processing t/04_align...
------------------------------------------------------------------------
5/5 (100%) tests passed
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
touch debian/build-stamp
dh_testdir
dh_testroot
dh_clean -k

dh_clean: warning: dh_clean -k is deprecated; use dh_prep instead
dh_clean: warning: This feature will be removed in compat 12.
dh_installdirs

/usr/bin/make install DESTDIR=/<<PKGBUILDDIR>>/debian/icheck/
make[1]: Entering directory '/<<PKGBUILDDIR>>'
mkdir -p "/<<PKGBUILDDIR>>/debian/icheck//usr/bin"
for i in icheck; \
do \
        cp $i "/<<PKGBUILDDIR>>/debian/icheck//usr/bin/$i"; \
done

do \

        cp $i "/<<PKGBUILDDIR>>/debian/icheck//usr/share/icheck/perl5/$i"; \
done
for i in CType/Native.pm; \
do \

        cp $i "/<<PKGBUILDDIR>>/debian/icheck//usr/lib/icheck/perl5/$i"; \
done
/usr/bin/make -C ext/CParse-Parser-PerlXS install
make[2]: Entering directory '/<<PKGBUILDDIR>>/ext/CParse-Parser-PerlXS'

make[2]: Leaving directory '/<<PKGBUILDDIR>>/ext/CParse-Parser-PerlXS'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_testdir
dh_testroot
dh_installman

dh_installdocs

dh_installchangelogs ChangeLog

dh_link

dh_strip

dh_strip: error: Aborting due to earlier error
make: *** [debian/rules:40: binary-arch] Error 25

--------------------------------------------------------------------------------
Build finished at 2024-11-16T18:41:01Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/997826.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use) (cd ext/CParse-Parser-PerlXS && perl Makefile.PL INSTALLDIRS=vendor INSTALLVENDORLIB=/usr/share/icheck/perl5 INSTALLVENDORARCH=/usr/lib/icheck/perl5 OPTIMIZE="-O2 -Wall -g") "/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- PerlXS.bs blib/arch/auto/CParse/Parser/PerlXS/PerlXS.bs 644 "/usr/bin/perl" "/usr/share/perl/5.40/ExtUtils/xsubpp" -typemap '/usr/share/perl/5.40/ExtUtils/typemap' PerlXS.xs > PerlXS.xsc aarch64-linux-gnu-gcc -c -I. -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -Wall -g -DVERSION=\"0.1\" -DXS_VERSION=\"0.1\" -fPIC "-I/usr/lib/aarch64-linux-gnu/perl/5.40/CORE" PerlXS.c aarch64-linux-gnu-gcc -shared -L/usr/local/lib -fstack-protector-strong PerlXS.o -o blib/arch/auto/CParse/Parser/PerlXS/PerlXS.so \ dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installdirs: warning: Compatibility levels before 10 are deprecated (level 9 in use) for i in CDecl.pm CExpr.pm CParse.pm CType.pm CDecl/Enumerator.pm CExpr/Add.pm CExpr/Alignof.pm CExpr/ArraySubscript.pm CExpr/Assign/Add.pm CExpr/Assign/BitAnd.pm CExpr/Assign/BitOr.pm CExpr/Assign/BitXor.pm CExpr/Assign/Divide.pm CExpr/Assign/Modulus.pm CExpr/Assign/Multiply.pm CExpr/Assign/ShiftLeft.pm CExpr/Assign/ShiftRight.pm CExpr/Assign/Subtract.pm CExpr/BitAnd.pm CExpr/BitOr.pm CExpr/BitXor.pm CExpr/BoolAnd.pm CExpr/BoolOr.pm CExpr/Cast.pm CExpr/Conditional.pm CExpr/Divide.pm CExpr/Equal.pm CExpr/Greater.pm CExpr/GreaterEqual.pm CExpr/Integer.pm CExpr/Less.pm CExpr/LessEqual.pm CExpr/Member.pm CExpr/MemberIndirect.pm CExpr/Modulus.pm CExpr/Multiply.pm CExpr/NotEqual.pm CExpr/Postdec.pm CExpr/Postinc.pm CExpr/Predec.pm CExpr/Preinc.pm CExpr/Ref.pm CExpr/SeqExpression.pm CExpr/ShiftLeft.pm CExpr/ShiftRight.pm CExpr/Sizeof.pm CExpr/SizeofExpr.pm CExpr/Subtract.pm CExpr/Unary/AddressOf.pm CExpr/Unary/BitNot.pm CExpr/Unary/BoolNot.pm CExpr/Unary/Deref.pm CExpr/Unary/Negative.pm CExpr/Unary/Positive.pm CParse/Attribute.pm CParse/AttributeList.pm CParse/Char.pm CParse/Declaration.pm CParse/Declarator.pm CParse/Declarator/Array.pm CParse/Declarator/Direct.pm CParse/Declarator/Function.pm CParse/Enum.pm CParse/EnumRef.pm CParse/Enumerator.pm CParse/Extension.pm CParse/Float.pm CParse/Function.pm CParse/FunctionSpecifier.pm CParse/Identifier.pm CParse/Integer.pm CParse/Namespace.pm CParse/Op.pm CParse/Op/Add.pm CParse/Op/Alignof.pm CParse/Op/ArraySubscript.pm CParse/Op/Assign.pm CParse/Op/Assign/Add.pm CParse/Op/Assign/BitAnd.pm CParse/Op/Assign/BitOr.pm CParse/Op/Assign/BitXor.pm CParse/Op/Assign/Divide.pm CParse/Op/Assign/Modulus.pm CParse/Op/Assign/Multiply.pm CParse/Op/Assign/ShiftLeft.pm CParse/Op/Assign/ShiftRight.pm CParse/Op/Assign/Subtract.pm CParse/Op/BitAnd.pm CParse/Op/BitOr.pm CParse/Op/BitXor.pm CParse/Op/BoolAnd.pm CParse/Op/BoolOr.pm CParse/Op/Call.pm CParse/Op/Cast.pm CParse/Op/Conditional.pm CParse/Op/Divide.pm CParse/Op/Equal.pm CParse/Op/Expression.pm CParse/Op/Member.pm CParse/Op/MemberIndirect.pm CParse/Op/Modulus.pm CParse/Op/Multiply.pm CParse/Op/NotEqual.pm CParse/Op/Postdec.pm CParse/Op/Postfix.pm CParse/Op/Postinc.pm CParse/Op/Predec.pm CParse/Op/Preinc.pm CParse/Op/Relation.pm CParse/Op/Relation/Greater.pm CParse/Op/Relation/GreaterEqual.pm CParse/Op/Relation/Less.pm CParse/Op/Relation/LessEqual.pm CParse/Op/Shift.pm CParse/Op/Shift/Left.pm CParse/Op/Shift/Right.pm CParse/Op/Sizeof.pm CParse/Op/SizeofExpr.pm CParse/Op/Subtract.pm CParse/Op/Unary.pm CParse/Op/Unary/AddressOf.pm CParse/Op/Unary/BitNot.pm CParse/Op/Unary/BoolNot.pm CParse/Op/Unary/Deref.pm CParse/Op/Unary/Negative.pm CParse/Op/Unary/Positive.pm CParse/ParameterDeclaration.pm CParse/Parser/Perl.pm CParse/Parser/Token/Character.pm CParse/Parser/Token/Float.pm CParse/Parser/Token/Identifier.pm CParse/Parser/Token/Integer.pm CParse/Parser/Token/Keyword.pm CParse/Parser/Token/Punctuator.pm CParse/Parser/Token/String.pm CParse/Pointer.pm CParse/StorageClass.pm CParse/String.pm CParse/Struct.pm CParse/StructDeclaration.pm CParse/StructDeclarator.pm CParse/StructRef.pm CParse/TypeName.pm CParse/TypeQualifier.pm CParse/TypeSpecifier.pm CParse/Union.pm CParse/UnionRef.pm CType/Array.pm CType/BitField.pm CType/Builtin.pm CType/Enum.pm CType/Function.pm CType/Fundamental.pm CType/Native.pm CType/Pointer.pm CType/Ref.pm CType/Struct.pm CType/Structural.pm CType/Union.pm; \ mkdir -p `dirname "/<<PKGBUILDDIR>>/debian/icheck//usr/share/icheck/perl5/$i"`; \ mkdir -p `dirname "/<<PKGBUILDDIR>>/debian/icheck//usr/lib/icheck/perl5/$i"`; \ "/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- PerlXS.bs blib/arch/auto/CParse/Parser/PerlXS/PerlXS.bs 644 Files found in blib/arch: installing files in blib/lib into architecture dependent library tree Installing /<<PKGBUILDDIR>>/debian/icheck/usr/lib/icheck/perl5/auto/CParse/Parser/PerlXS/PerlXS.so Installing /<<PKGBUILDDIR>>/debian/icheck/usr/lib/icheck/perl5/CParse/Parser/PerlXS.pm dh_installman: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installdocs: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installchangelogs: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_link: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_strip: warning: Compatibility levels before 10 are deprecated (level 9 in use) strip: unable to copy file 'debian/icheck/usr/lib/icheck/perl5/auto/CParse/Parser/PerlXS/PerlXS.so'; reason: Permission denied dh_strip: error: strip --remove-section=.comment --remove-section=.note --strip-unneeded debian/icheck/usr/lib/icheck/perl5/auto/CParse/Parser/PerlXS/PerlXS.so returned exit code 1 dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

OpenPGP_signature.asc
Description: OpenPGP digital signature