Bug#1089351: ircd-irc2: Supporting rootless builds by default

Niels Thykier Sat, 07 Dec 2024 11:30:37 -0800

Source: ircd-irc2
Version: 2.11.2p3~dfsg-7
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue


Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
ircd-irc2 failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

rm -f ircd
./version.c.SH
Building version.c...

gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../ircd -I../common -c -o version.o version.c gcc -Wl,-z,relro -Wl,-z,now -o ircd bsd.o dbuf.o packet.o send.o match.o parse.o support.o version.o channel.o class.o hash.o ircd.o list.o res.o s_auth.o s_bsd.o s_conf.o s_debug.o s_err.o s_id.o s_misc.o s_numeric.o s_send.o s_serv.o s_service.o s_user.o s_zip.o whowas.o res_init.o res_comp.o res_mkquery.o patricia.o -lm -lcrypt gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../ircd -I../common -DCLIENT_COMPILE -c -o clsupport.o ../common/support.c gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../ircd -I../common -DCLIENT_COMPILE -c -o clmatch.o ../common/match.c gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../iauth -I../common -DIAUTHPID_PATH="\"/var/run/ircd/iauth.pid\"" -c -o iauth.o ../iauth/iauth.c

../iauth/iauth.c: In function ‘write_pidfile’:

../iauth/iauth.c:139:16: warning: ignoring return value of ‘truncate’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

  139 |         (void) truncate(IAUTHPID_PATH, 0);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~

../iauth/a_log.c: In function ‘vsendto_log’:

../iauth/a_log.c:95:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

   95 |                 write(0, logbuf, strlen(logbuf));
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../iauth -I../common -c -o mod_lhex.o ../iauth/mod_lhex.c gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../iauth -I../common -c -o mod_pipe.o ../iauth/mod_pipe.c gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../iauth -I../common -c -o mod_rfc931.o ../iauth/mod_rfc931.c gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../iauth -I../common -c -o mod_socks.o ../iauth/mod_socks.c gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../iauth -I../common -c -o mod_webproxy.o ../iauth/mod_webproxy.c

rm -f iauth

gcc -Wl,-z,relro -Wl,-z,now -o iauth clsupport.o clmatch.o iauth.o a_conf.o a_io.o a_log.o mod_lhex.o mod_pipe.o mod_rfc931.o mod_socks.o mod_webproxy.o -lcrypt gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../ircd -I../common -DCHKCONF_COMPILE -DIRCDCONF_PATH="\"/etc/ircd/ircd.conf\"" \

-DIRCDCONF_DIR="\"/etc/ircd/\"" \

-DM4_PATH="\"/usr/bin/m4\"" -DIRCDM4_PATH="\"/etc/ircd/ircd.m4\"" -c -o chkconf.o ../ircd/chkconf.c

rm -f chkconf

gcc -Wl,-z,relro -Wl,-z,now -o chkconf match.o chkconf.o -lcrypt gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../common -DCONTRIB_COMPILE -c -o mkpasswd.o ../contrib/mkpasswd/mkpasswd.c

rm -f ircd-mkpasswd

gcc -Wl,-z,relro -Wl,-z,now -o ircd-mkpasswd mkpasswd.o -lcrypt gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I../common -DCONTRIB_COMPILE -DIRCDWATCH_PID_FILENAME="\"/var/run/ircd/ircdwatch.pid\"" -DIRCD_PATH="\"/usr/sbin/ircd\"" -DIRCDCONF_PATH="\"/etc/ircd/ircd.conf\"" -DIRCDPID_PATH="\"/var/run/ircd/ircd.pid\"" -c -o ircdwatch.o ../contrib/ircdwatch/ircdwatch.c

rm -f ircdwatch

gcc -Wl,-z,relro -Wl,-z,now -o ircdwatch clsupport.o clmatch.o ircdwatch.o -lcrypt make[2]: Leaving directory '/<<PKGBUILDDIR>>/builddir'

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_installdirs
   dh_auto_install --destdir=debian/ircd-irc2/
   debian/rules override_dh_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
ln -sf builddir aarch64-unknown-linux-gnu
cd builddir;../ircd/buildm4 ircd.m4
dh_install
# ircd-package
cp builddir/chkconf debian/ircd-irc2/usr/sbin
cp builddir/iauth debian/ircd-irc2/usr/sbin
cp builddir/ircd debian/ircd-irc2/usr/sbin

cp builddir/ircd-mkpasswd debian/ircd-irc2/usr/sbin cp builddir/ircdwatch debian/ircd-irc2/usr/sbin

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_installdocs
   dh_installchangelogs
   debian/rules override_dh_installexamples
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_installexamples
# convert example config to % since we're IPv6 now

sed -i -e '/^[^#]:/s,:,\%,g' debian/ircd-irc2/usr/share/doc/ircd-irc2/ircd.conf.example

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_installman
   debian/rules override_dh_installinfo
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_installinfo
# synthesize dircategory and direntry
mkdir -p debian/ircd-irc2/usr/share/info/

cat debian/ircd-irc2.info-dir-entry doc/INSTALL.info >debian/ircd-irc2/usr/share/info/ircd-irc2.info

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_systemd_enable
   dh_installinit
   dh_systemd_start
   dh_lintian
   dh_perl
   dh_link
   dh_strip_nondeterminism
   dh_compress
   debian/rules override_dh_fixperms
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_fixperms
# fix permissions of var/log/ircd
chown irc:irc debian/ircd-irc2/var/log/ircd

chown: changing ownership of 'debian/ircd-irc2/var/log/ircd': Operation not permitted

make[1]: *** [debian/rules:95: override_dh_fixperms] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:39: binary] Error 2

dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

--------------------------------------------------------------------------------
Build finished at 2024-11-16T19:08:52Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/998558.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089351: ircd-irc2: Supporting rootless builds by default

Reply via email to