Bug#1089357: leafnode: Supporting rootless builds by default

Niels Thykier Sat, 07 Dec 2024 11:33:18 -0800

Source: leafnode
Version: 1.12.0-2.1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue


Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
leafnode failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
make[4]: Leaving directory '/<<PKGBUILDDIR>>'
make 'LDFLAGS=-Wl,-z,relro -Wl,-z,now' check-TESTS
make[4]: Entering directory '/<<PKGBUILDDIR>>'
make[5]: Entering directory '/<<PKGBUILDDIR>>'
i() { ( echo '#! /bin/sh' ; \
echo "./test1 <\"$1\" | cmp - \"$2\"" ); }; i \
        `echo ./t.gal2 | sed 's/t\.\(.*\)/t\/cmp.\1t/'` \
        `echo ./t.gal2 | sed 's/t\.\(.*\)/t\/cmp.\1w/'` \
        >t.gal2 && chmod +x t.gal2
i() { ( echo '#! /bin/sh' ; \
echo "./test1 <\"$1\" | cmp - \"$2\"" ); }; i \
        `echo ./t.gal3 | sed 's/t\.\(.*\)/t\/cmp.\1t/'` \
        `echo ./t.gal3 | sed 's/t\.\(.*\)/t\/cmp.\1w/'` \
        >t.gal3 && chmod +x t.gal3
i() { ( echo '#! /bin/sh' ; \
echo "./test1 <\"$1\" | cmp - \"$2\"" ); }; i \
        `echo ./t.gal4 | sed 's/t\.\(.*\)/t\/cmp.\1t/'` \
        `echo ./t.gal4 | sed 's/t\.\(.*\)/t\/cmp.\1w/'` \
        >t.gal4 && chmod +x t.gal4
i() { ( echo '#! /bin/sh' ; \
echo "./test1 <\"$1\" | cmp - \"$2\"" ); }; i \
        `echo ./t.gal6 | sed 's/t\.\(.*\)/t\/cmp.\1t/'` \
        `echo ./t.gal6 | sed 's/t\.\(.*\)/t\/cmp.\1w/'` \
        >t.gal6 && chmod +x t.gal6
SKIP: t.validate-xml
PASS: t.pcre_extract
PASS: xsnprintf
PASS: t.gal3
PASS: t.gal6
PASS: t.gal4
PASS: t.gal2
============================================================================
Testsuite summary for leafnode 1.12.0
============================================================================
# TOTAL: 7
# PASS:  6
# SKIP:  1
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[5]: Leaving directory '/<<PKGBUILDDIR>>'
make[4]: Leaving directory '/<<PKGBUILDDIR>>'
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
Making check in doc_german
make[3]: Entering directory '/<<PKGBUILDDIR>>/doc_german'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/<<PKGBUILDDIR>>/doc_german'
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_installdirs
   dh_auto_install --destdir=debian/leafnode/

make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/leafnode AM_UPDATE_INFO_DIR=no

make[1]: Entering directory '/<<PKGBUILDDIR>>'
make 'LDFLAGS=-Wl,-z,relro -Wl,-z,now' install-recursive
make[2]: Entering directory '/<<PKGBUILDDIR>>'
Making install in .
make[3]: Entering directory '/<<PKGBUILDDIR>>'
make[4]: Entering directory '/<<PKGBUILDDIR>>'
 /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/leafnode/etc/news/leafnode'
 /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/leafnode/usr/share/man/man1'
 /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/leafnode/usr/share/man/man8'

/usr/bin/install -c -m 644 config.example filters.example '/<<PKGBUILDDIR>>/debian/leafnode/etc/news/leafnode'

 /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/leafnode/usr/bin'
 /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/leafnode/usr/sbin'

/usr/bin/install -c -m 644 newsq.1 leafnode-version.1 '/<<PKGBUILDDIR>>/debian/leafnode/usr/share/man/man1' /usr/bin/install -c -m 644 applyfilter.8 checkgroups.8 fetchnews.8 leafnode.8 texpire.8 '/<<PKGBUILDDIR>>/debian/leafnode/usr/share/man/man8'

make 'LDFLAGS=-Wl,-z,relro -Wl,-z,now' install-data-hook

/usr/bin/install -c newsq leafnode-version '/<<PKGBUILDDIR>>/debian/leafnode/usr/bin' /usr/bin/install -c leafnode fetchnews texpire checkgroups applyfilter '/<<PKGBUILDDIR>>/debian/leafnode/usr/sbin'

make[5]: Entering directory '/<<PKGBUILDDIR>>'
set -e ; for i in "" /leaf.node /failed.postings /interesting.groups \
        /out.going /message.id /temp.files ; do \
        mkdir -p /<<PKGBUILDDIR>>/debian/leafnode/var/spool/news$i ; \
if ./amiroot ; then \
 chown news:news /<<PKGBUILDDIR>>/debian/leafnode/var/spool/news/$i ; \

chmod 2775 /<<PKGBUILDDIR>>/debian/leafnode/var/spool/news/$i ; fi ; \

done

d="`dirname /<<PKGBUILDDIR>>/debian/leafnode/var/spool/news/leaf.node/lock.file`" ; mkdir -p "${d}" && \

if ./amiroot ; then \
          chown news:news "${d}" ; \
  chmod 2775 "${d}" ; fi

./install-sh -m 0755 -d /<<PKGBUILDDIR>>/debian/leafnode/usr/share/doc/leafnode ./install-sh -m 0644 ./UNINSTALL-daemontools /<<PKGBUILDDIR>>/debian/leafnode/usr/share/doc/leafnode

make[5]: Leaving directory '/<<PKGBUILDDIR>>'
make[4]: Leaving directory '/<<PKGBUILDDIR>>'
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
Making install in doc_german
make[3]: Entering directory '/<<PKGBUILDDIR>>/doc_german'
make[4]: Entering directory '/<<PKGBUILDDIR>>/doc_german'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/<<PKGBUILDDIR>>/doc_german'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/doc_german'
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make DESTDIR=debian/leafnode/ mandir=/usr/share/man install
make[2]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make 'LDFLAGS=-Wl,-z,relro -Wl,-z,now' install-recursive
make[3]: Entering directory '/<<PKGBUILDDIR>>'
Making install in .
make[4]: Entering directory '/<<PKGBUILDDIR>>'
make[5]: Entering directory '/<<PKGBUILDDIR>>'
 /usr/bin/mkdir -p 'debian/leafnode//usr/bin'
  /usr/bin/install -c newsq leafnode-version 'debian/leafnode//usr/bin'
 /usr/bin/mkdir -p 'debian/leafnode//usr/sbin'

/usr/bin/install -c leafnode fetchnews texpire checkgroups applyfilter 'debian/leafnode//usr/sbin'

 /usr/bin/mkdir -p 'debian/leafnode//etc/news/leafnode'

/usr/bin/install -c -m 644 config.example filters.example 'debian/leafnode//etc/news/leafnode'

 /usr/bin/mkdir -p 'debian/leafnode//usr/share/man/man1'

/usr/bin/install -c -m 644 newsq.1 leafnode-version.1 'debian/leafnode//usr/share/man/man1'

 /usr/bin/mkdir -p 'debian/leafnode//usr/share/man/man8'

/usr/bin/install -c -m 644 applyfilter.8 checkgroups.8 fetchnews.8 leafnode.8 texpire.8 'debian/leafnode//usr/share/man/man8'

/usr/bin/make 'LDFLAGS=-Wl,-z,relro -Wl,-z,now' install-data-hook
make[6]: Entering directory '/<<PKGBUILDDIR>>'
set -e ; for i in "" /leaf.node /failed.postings /interesting.groups \
        /out.going /message.id /temp.files ; do \
        mkdir -p debian/leafnode//var/spool/news$i ; \
if ./amiroot ; then \
 chown news:news debian/leafnode//var/spool/news/$i ; \
 chmod 2775      debian/leafnode//var/spool/news/$i ; fi ; \
done

d="`dirname debian/leafnode//var/spool/news/leaf.node/lock.file`" ; mkdir -p "${d}" && \

if ./amiroot ; then \
          chown news:news "${d}" ; \
  chmod 2775 "${d}" ; fi
./install-sh -m 0755 -d debian/leafnode//usr/share/doc/leafnode

./install-sh -m 0644 ./UNINSTALL-daemontools debian/leafnode//usr/share/doc/leafnode

make[6]: Leaving directory '/<<PKGBUILDDIR>>'
make[5]: Leaving directory '/<<PKGBUILDDIR>>'
make[4]: Leaving directory '/<<PKGBUILDDIR>>'
Making install in doc_german
make[4]: Entering directory '/<<PKGBUILDDIR>>/doc_german'
make[5]: Entering directory '/<<PKGBUILDDIR>>/doc_german'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/<<PKGBUILDDIR>>/doc_german'
make[4]: Leaving directory '/<<PKGBUILDDIR>>/doc_german'
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
rm debian/leafnode/etc/news/leafnode/config.example
cp debian/filters debian/leafnode/etc/news/leafnode/
cp debian/touch_newsgroup debian/leafnode/usr/bin
cp debian/touch_newsgroup.1 debian/leafnode/usr/share/man/man1
cp config.example debian/leafnode/usr/share/leafnode
cp debian/debian-config debian/leafnode/usr/share/leafnode
cp debian/do-fetch-news debian/leafnode/etc/news/leafnode/do-fetch-news
chown -R news:news debian/leafnode/var/spool/news

chown: changing ownership of 'debian/leafnode/var/spool/news/out.going': Operation not permitted chown: changing ownership of 'debian/leafnode/var/spool/news/temp.files': Operation not permitted chown: changing ownership of 'debian/leafnode/var/spool/news/message.id': Operation not permitted chown: changing ownership of 'debian/leafnode/var/spool/news/leaf.node': Operation not permitted chown: changing ownership of 'debian/leafnode/var/spool/news/failed.postings': Operation not permitted chown: changing ownership of 'debian/leafnode/var/spool/news/interesting.groups': Operation not permitted chown: changing ownership of 'debian/leafnode/var/spool/news': Operation not permitted

make[1]: *** [debian/rules:38: override_dh_install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:6: binary] Error 2

dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

--------------------------------------------------------------------------------
Build finished at 2024-11-16T21:03:37Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1000822.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089357: leafnode: Supporting rootless builds by default

Reply via email to