Source: mactelnet
Version: 0.6.1-1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
mactelnet failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
gcc -DHAVE_CONFIG_H -I. -DLOCALEDIR='"/usr/share/locale"' -Wdate-time -D_FORTIFY_SOURCE=2 -DFROM_MACTELNETD -DUSERSFILE='"/etc/mactelnetd.users"' -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -c -o mactelnetd-users.o `test -f 'users.c' || echo './'`users.c gcc -DHAVE_CONFIG_H -I. -DLOCALEDIR='"/usr/share/locale"' -Wdate-time -D_FORTIFY_SOURCE=2 -DFROM_MACTELNETD -DUSERSFILE='"/etc/mactelnetd.users"' -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -c -o mactelnetd-mtwei.o `test -f 'mtwei.c' || echo './'`mtwei.c
mactelnetd.c: In function ‘main’:
mactelnetd.c:1371:17: warning: ignoring return value of ‘daemon’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1371 |                 daemon(0, 0);
      |                 ^~~~~~~~~~~~
mactelnetd.c: In function ‘main_add_user’:
mactelnetd.c:1082:23: warning: ignoring return value of ‘scanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1082 |                 (void)scanf("%31s", user);
      |                       ^~~~~~~~~~~~~~~~~~~
mactelnetd.c: In function ‘user_login’:
mactelnetd.c:546:17: warning: ignoring return value of ‘chown’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  546 |                 chown(slavename, user->pw_uid, user->pw_gid);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mactelnetd.c:587:25: warning: ignoring return value of ‘dup’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  587 |                         dup(curconn->slavefd);
      |                         ^~~~~~~~~~~~~~~~~~~~~
mactelnetd.c:589:25: warning: ignoring return value of ‘dup’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  589 |                         dup(curconn->slavefd);
      |                         ^~~~~~~~~~~~~~~~~~~~~
mactelnetd.c:591:25: warning: ignoring return value of ‘dup’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  591 |                         dup(curconn->slavefd);
      |                         ^~~~~~~~~~~~~~~~~~~~~
mactelnetd.c:621:25: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  621 |                         chdir(user->pw_dir);
      |                         ^~~~~~~~~~~~~~~~~~~
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wl,-z,relro -Wl,-z,now -o macping macping.o interfaces.o protocol.o -lbsd -lcrypto -lrt gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wl,-z,relro -Wl,-z,now -o mndp mndp.o protocol.o -lbsd -lcrypto -lrt gcc -DFROM_MACTELNET -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wl,-z,relro -Wl,-z,now -o mactelnet mactelnet-mactelnet.o mactelnet-protocol.o mactelnet-console.o mactelnet-interfaces.o mactelnet-mndp.o mactelnet-autologin.o mactelnet-mtwei.o -lbsd -lcrypto -lrt gcc -DFROM_MACTELNETD -DUSERSFILE='"/etc/mactelnetd.users"' -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wl,-z,relro -Wl,-z,now -o mactelnetd mactelnetd-mactelnetd.o mactelnetd-protocol.o mactelnetd-interfaces.o mactelnetd-console.o mactelnetd-users.o mactelnetd-mtwei.o -lbsd -lcrypto -lrt make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
Making all in doc
make[2]: Entering directory '/<<PKGBUILDDIR>>/doc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>/doc'
Making all in config
make[2]: Entering directory '/<<PKGBUILDDIR>>/config'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>/config'
Making all in po
make[2]: Entering directory '/<<PKGBUILDDIR>>/po'
test ! -f ./mactelnet.pot || \
  test -z "nb.gmo bg.gmo" || make nb.gmo bg.gmo
make[3]: Entering directory '/<<PKGBUILDDIR>>/po'
make[3]: 'nb.gmo' is up to date.
make[3]: 'bg.gmo' is up to date.
make[3]: Leaving directory '/<<PKGBUILDDIR>>/po'
touch stamp-po
make[2]: Leaving directory '/<<PKGBUILDDIR>>/po'
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: Nothing to be done for 'all-am'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test
        make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
Making check in src
make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
Making check in doc
make[2]: Entering directory '/<<PKGBUILDDIR>>/doc'
make[2]: Nothing to be done for 'check'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>/doc'
Making check in config
make[2]: Entering directory '/<<PKGBUILDDIR>>/config'
make[2]: Nothing to be done for 'check'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>/config'
Making check in po
make[2]: Entering directory '/<<PKGBUILDDIR>>/po'
make[2]: Nothing to be done for 'check'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>/po'
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: Nothing to be done for 'check-am'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_auto_install
        make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/tmp 
AM_UPDATE_INFO_DIR=no
make[1]: Entering directory '/<<PKGBUILDDIR>>'
Making install in src
make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
make[3]: Nothing to be done for 'install-data-am'.
 /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/usr/bin'
 /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/usr/sbin'
/usr/bin/install -c mactelnet macping mndp '/<<PKGBUILDDIR>>/debian/tmp/usr/bin'
  /usr/bin/install -c mactelnetd '/<<PKGBUILDDIR>>/debian/tmp/usr/sbin'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
Making install in doc
make[2]: Entering directory '/<<PKGBUILDDIR>>/doc'
make[3]: Entering directory '/<<PKGBUILDDIR>>/doc'
make[3]: Nothing to be done for 'install-exec-am'.
 /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1'
/usr/bin/install -c -m 644 mactelnet.1 mndp.1 macping.1 mactelnetd.1 '/<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/doc'
make[2]: Leaving directory '/<<PKGBUILDDIR>>/doc'
Making install in config
make[2]: Entering directory '/<<PKGBUILDDIR>>/config'
make[3]: Entering directory '/<<PKGBUILDDIR>>/config'
make[3]: Nothing to be done for 'install-data-am'.
 /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/etc'
/usr/bin/install -c -m 644 mactelnetd.users '/<<PKGBUILDDIR>>/debian/tmp/etc'
make  install-exec-hook
make[4]: Entering directory '/<<PKGBUILDDIR>>/config'
chmod 600 /<<PKGBUILDDIR>>/debian/tmp/etc/mactelnetd.users
chown root /<<PKGBUILDDIR>>/debian/tmp/etc/mactelnetd.users
chown: changing ownership of '/<<PKGBUILDDIR>>/debian/tmp/etc/mactelnetd.users': Operation not permitted
make[4]: *** [Makefile:495: install-exec-hook] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/config'
make[3]: *** [Makefile:437: install-exec-am] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/config'
make[2]: *** [Makefile:384: install-am] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/config'
make[1]: *** [Makefile:373: install-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_install: error: make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/tmp AM_UPDATE_INFO_DIR=no returned exit code 2
make: *** [debian/rules:13: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2024-11-17T10:52:39Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1021658.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to