Bug#1089388: mgetty: Supporting rootless builds by default

[Niels Thykier]

Source: mgetty
Version: 1.2.1-1.4
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
mgetty failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
In vm...
make[3]: Entering directory '/<<PKGBUILDDIR>>/voice/vm'
cc -Wall -O2 -pipe -c main.c
cc -Wall -O2 -pipe -c event.c
cc -Wall -O2 -pipe -c usage.c

make[3]: Leaving directory '/<<PKGBUILDDIR>>/voice/vm'
make[2]: Leaving directory '/<<PKGBUILDDIR>>/voice'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
cd contrib; /usr/bin/make g3toxwd g3tolj
make[1]: Entering directory '/<<PKGBUILDDIR>>/contrib'
cc     g3toxwd.c   -o g3toxwd
cc     g3tolj.c   -o g3tolj
make[1]: Leaving directory '/<<PKGBUILDDIR>>/contrib'
cd frontends/X11/viewfax; /usr/bin/make
make[1]: Entering directory '/<<PKGBUILDDIR>>/frontends/X11/viewfax'

  131 | "\t-4\traw files are g4\n";
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
viewfax.c: In function ‘ShowLoop’:

      |                 ^~~~~~
In file included from viewfax.c:26:
/usr/include/X11/Xlib.h:1683:15: note: declared here
 1683 | extern KeySym XKeycodeToKeysym(
      |               ^~~~~~~~~~~~~~~~

faxinput.c: In function ‘notetiff’:

  335 |                             nstrips, count);

      |                                      t32bits {aka unsigned int}
faxinput.c: In function ‘getstrip’:

  603 |         fprintf(stderr, "%s: expected %d bytes, got %d\n",
      |                                       ~^
      |                                        |
      |                                        int
      |                                       %ld
  604 |                 pn->pathname, pn->length, n);
      |                               ~~~~~~~~~~
      |                                 |
      |                                 size_t {aka long unsigned int}

faxexpand.c: In function ‘MHexpand’:

  344 |     int EOLcnt;                 /* number of consecutive EOLs */
      |         ^~~~~~
faxexpand.c: In function ‘g4expand’:

  600 |     int EOLcnt;
      |         ^~~~~~

touch build
dh_testdir -i
dh_testroot -i
dh_prep -i
dh_installdirs -i

install -m644 callback/README \
        /<<PKGBUILDDIR>>/debian/mgetty-docs/usr/share/doc/mgetty/README.callback
install -m644 frontends/X11/viewfax/README \
        /<<PKGBUILDDIR>>/debian/mgetty-docs/usr/share/doc/mgetty/README.viewfax
install -m644 voice/doc/* \
        /<<PKGBUILDDIR>>/debian/mgetty-docs/usr/share/doc/mgetty/voice
install -m644 voice/Perl/* \
        
/<<PKGBUILDDIR>>/debian/mgetty-docs/usr/share/doc/mgetty/voice/examples/perl
install -m644 voice/scripts/* \
        
/<<PKGBUILDDIR>>/debian/mgetty-docs/usr/share/doc/mgetty/voice/examples/scripts
cp /<<PKGBUILDDIR>>/debian/inittab \
        
/<<PKGBUILDDIR>>/debian/mgetty-docs/usr/share/doc/mgetty/examples/inittab.DEBIAN
dh_installdocs -i

cp -a contrib frontends doc/*.txt doc/mgetty.texi doc/modems.db \
        doc/fhng-codes /<<PKGBUILDDIR>>/debian/win95.ppp BUGS FTP \
        README.1st THANKS TODO \
        /<<PKGBUILDDIR>>/debian/mgetty-docs/usr/share/doc/mgetty/

cp -a samples/* \
        /<<PKGBUILDDIR>>/debian/mgetty-docs/usr/share/doc/mgetty/examples
chmod +x debian/fixpaths.pl
debian/fixpaths.pl
dh_installmenu -i

dh_installinfo -i

dh_installchangelogs -i

dh_compress -i

dh_fixperms -i
dh_installdeb -i

dh_gencontrol -i

dh_md5sums -i
dh_builddeb -i

dh_testdir -a
dh_testroot -a
dh_prep -a
dh_installdirs -a

mkdir -p /<<PKGBUILDDIR>>/debian/mgetty/etc/logrotate.d

/usr/bin/make install DESTDIR=/<<PKGBUILDDIR>>/debian/mgetty
make[1]: Entering directory '/<<PKGBUILDDIR>>'
./sedscript <login.cfg.in >login.config
./sedscript <mgetty.cfg.in >mgetty.config
./sedscript <sendfax.cfg.in >sendfax.config

install -c -m 755 newslock /<<PKGBUILDDIR>>/debian/mgetty/usr/bin

if [ -f /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin/mgetty ] ; then \

if [ -f /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin/sendfax ] ; then \

install -c -s -m 755 mgetty /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin
install -c -s -m 755 sendfax /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin
test -d /<<PKGBUILDDIR>>/debian/mgetty/usr/lib/mgetty-fax  || \

test -d /<<PKGBUILDDIR>>/debian/mgetty/etc/mgetty || \

test -f /<<PKGBUILDDIR>>/debian/mgetty/etc/mgetty/login.config || \

make[1]: *** [Makefile:606: install.bin] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:116: binary-arch] Error 2

--------------------------------------------------------------------------------
Build finished at 2024-11-17T12:13:00Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1022837.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

cc -o vm main.o event.o usage.o ../../cnd.o ../../faxhng.o ../../faxlib.o ../../faxrec.o ../../faxrecp.o ../../faxsend.o ../../gettydefs.o ../../login.o ../../logname.o ../../utmp.o ../../getdisk.o ../../goodies.o ../../io.o ../../g3file.o ../../locks.o ../../tio.o ../../modem.o ../../clean_line.o ../../class1.o ../../class1lib.o ../../hyla_nsf.o ../libvoice/libvoice.a ../libutil/libutil.a -lutil gcc -Wall -O2 -Wno-uninitialized -ansi -pedantic -DHELPFILE=\"/usr/share/doc/mgetty-viewfax/viewfax.tif\" -c -o viewfax.o viewfax.c viewfax.c:131:1: warning: string length ‘606’ is greater than the length ‘509’ ISO C90 compilers are required to support [-Woverlength-strings] viewfax.c:792:17: warning: ‘XKeycodeToKeysym’ is deprecated [-Wdeprecated-declarations] 792 | switch(XKeycodeToKeysym(Disp, Event.xkey.keycode, 0)) { gcc -Wall -O2 -Wno-uninitialized -ansi -pedantic -DHELPFILE=\"/usr/share/doc/mgetty-viewfax/viewfax.tif\" -c -o faxinput.o faxinput.c faxinput.c:334:69: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘t32bits’ {aka ‘unsigned int’} [-Wformat=] 334 | "[E] StripsPerImage tag273=%d, tag279=%ld\n", | ~~^ | | | long int | %d | ~~~~~ | | faxinput.c:603:40: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=] gcc -Wall -O2 -Wno-uninitialized -ansi -pedantic -DHELPFILE=\"/usr/share/doc/mgetty-viewfax/viewfax.tif\" -c -o faxinit.o faxinit.c gcc -Wall -O2 -Wno-uninitialized -ansi -pedantic -DHELPFILE=\"/usr/share/doc/mgetty-viewfax/viewfax.tif\" -c -o faxexpand.o faxexpand.c faxexpand.c:344:9: warning: variable ‘EOLcnt’ set but not used [-Wunused-but-set-variable] faxexpand.c:600:9: warning: variable ‘EOLcnt’ set but not used [-Wunused-but-set-variable] gcc -O2 -Wno-uninitialized -ansi -pedantic -L/usr/X11R6/lib -o viewfax viewfax.o faxinput.o faxinit.o faxexpand.o -L/usr/local/lib -lX11 make[1]: Leaving directory '/<<PKGBUILDDIR>>/frontends/X11/viewfax' dh_installdirs: warning: Compatibility levels before 10 are deprecated (level 7 in use) dh_installdocs: warning: Compatibility levels before 10 are deprecated (level 7 in use) rm -rf /<<PKGBUILDDIR>>/debian/mgetty-docs/usr/share/doc/mgetty/frontends/X11/viewfax/ dh_installmenu: warning: Compatibility levels before 10 are deprecated (level 7 in use) dh_installinfo: warning: Compatibility levels before 10 are deprecated (level 7 in use) dh_installchangelogs: warning: Compatibility levels before 10 are deprecated (level 7 in use) dh_compress: warning: Compatibility levels before 10 are deprecated (level 7 in use) dh_installdeb: warning: Compatibility levels before 10 are deprecated (level 7 in use) dh_gencontrol: warning: Compatibility levels before 10 are deprecated (level 7 in use) dpkg-deb: building package 'mgetty-docs' in '../mgetty-docs_1.2.1-1.4_all.deb'. dh_installdirs: warning: Compatibility levels before 10 are deprecated (level 7 in use) cp /<<PKGBUILDDIR>>/debian/mgetty.logrotate /<<PKGBUILDDIR>>/debian/mgetty/etc/logrotate.d/mgetty test -d /<<PKGBUILDDIR>>/debian/mgetty/usr/bin || ( ./mkidirs /<<PKGBUILDDIR>>/debian/mgetty/usr/bin ; chmod 755 /<<PKGBUILDDIR>>/debian/mgetty/usr/bin ) test -d /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin || ( ./mkidirs /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin ; chmod 755 /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin ) mv -f /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin/mgetty /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin/mgetty.old ; fi mv -f /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin/sendfax /<<PKGBUILDDIR>>/debian/mgetty/usr/sbin/sendfax.old ; fi ( ./mkidirs /<<PKGBUILDDIR>>/debian/mgetty/usr/lib/mgetty-fax && chmod 755 /<<PKGBUILDDIR>>/debian/mgetty/usr/lib/mgetty-fax ) ( ./mkidirs /<<PKGBUILDDIR>>/debian/mgetty/etc/mgetty && chmod 755 /<<PKGBUILDDIR>>/debian/mgetty/etc/mgetty) install -c -o root -m 600 login.config /<<PKGBUILDDIR>>/debian/mgetty/etc/mgetty/ install: cannot change ownership of '/<<PKGBUILDDIR>>/debian/mgetty/etc/mgetty/login.config': Operation not permitted dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

OpenPGP_signature.asc
Description: OpenPGP digital signature