Bug#1089379: lpr: Supporting rootless builds by default

[Niels Thykier]

Source: lpr
Version: 1:2008.05.17.3+nmu3
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
lpr failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

make[2]: Leaving directory '/<<PKGBUILDDIR>>/lpq'
make[2]: Entering directory '/<<PKGBUILDDIR>>/lpr'
make[2]: Circular lpr.c <- lpr.o dependency dropped.

      |                   ^~~~~

   40 | static const char copyright[] =
      |                   ^~~~~~~~~

make[2]: Leaving directory '/<<PKGBUILDDIR>>/lpr'
make[2]: Entering directory '/<<PKGBUILDDIR>>/lprm'
make[2]: Circular lprm.c <- lprm.o dependency dropped.

      |                   ^~~~~

   35 | static const char copyright[] =
      |                   ^~~~~~~~~

make[2]: Leaving directory '/<<PKGBUILDDIR>>/lprm'
make[2]: Entering directory '/<<PKGBUILDDIR>>/lptest'
make[2]: Circular lptest.c <- lptest.o dependency dropped.

      |                   ^~~~~

   35 | static const char copyright[] =
      |                   ^~~~~~~~~

cc -o lptest lptest.o ../common_source/strlcpy.o ../common_source/strlcat.o
make[2]: Leaving directory '/<<PKGBUILDDIR>>/lptest'
make[2]: Entering directory '/<<PKGBUILDDIR>>/pac'
make[2]: Circular pac.c <- pac.o dependency dropped.

      |                   ^~~~~

   35 | static const char copyright[] =
      |                   ^~~~~~~~~

make[2]: Leaving directory '/<<PKGBUILDDIR>>/pac'
make[2]: Entering directory '/<<PKGBUILDDIR>>/filters'
make[2]: Circular lpf.c <- lpf.o dependency dropped.

      |                   ^~~~~

   34 | static const char copyright[] =
      |                   ^~~~~~~~~

cc -o lpf lpf.o ../common_source/strlcpy.o ../common_source/strlcat.o
make[2]: Leaving directory '/<<PKGBUILDDIR>>/filters'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
touch build-arch-stamp
dh_testdir
dh_testroot
dh_clean -k

dh_clean: warning: dh_clean -k is deprecated; use dh_prep instead
dh_clean: warning: This feature will be removed in compat 12.
dh_installdirs

touch install-stamp
dh_testdir
dh_testroot
dh_install

dh_installman

dh_installdocs

dh_installexamples

dh_installlogcheck

dh_installinit --name=lpd

dh_installcron

dh_installchangelogs

dh_strip

dh_compress

dh_fixperms
chown root.lp debian/lpr/usr/bin/lpr \
              debian/lpr/usr/bin/lpq \
              debian/lpr/usr/bin/lprm \
              debian/lpr/usr/sbin/lpc
chown: warning: '.' should be ':': ‘root.lp’

make: *** [debian/rules:55: binary-arch] Error 1

--------------------------------------------------------------------------------
Build finished at 2024-11-17T09:34:24Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1020651.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

make[2]: Circular ../common_source/getcap.c <- ../common_source/getcap.o dependency dropped. make[2]: Circular ../common_source/vis.c <- ../common_source/vis.o dependency dropped. make[2]: Circular ../common_source/strlcpy.c <- ../common_source/strlcpy.o dependency dropped. make[2]: Circular ../common_source/strlcat.c <- ../common_source/strlcat.o dependency dropped. cc -o lpq lpq.o ../common_source/displayq.o ../common_source/common.o ../common_source/common_vars.o ../common_source/getcap.o ../common_source/vis.o ../common_source/strlcpy.o ../common_source/strlcat.o cc -I/../common_source -g -Wall -g -O2 -D_GNU_SOURCE -D__KAME__ -I../common_source -c -o lpr.o lpr.c lpr.c:49:19: warning: ‘rcsid’ defined but not used [-Wunused-const-variable=] 49 | static const char rcsid[] = "$OpenBSD: lpr.c,v 1.41 2007/04/07 21:57:27 stevesk Exp $"; lpr.c:40:19: warning: ‘copyright’ defined but not used [-Wunused-const-variable=] make[2]: Circular ../common_source/startdaemon.c <- ../common_source/startdaemon.o dependency dropped. make[2]: Circular ../common_source/common.c <- ../common_source/common.o dependency dropped. make[2]: Circular ../common_source/common_vars.c <- ../common_source/common_vars.o dependency dropped. make[2]: Circular ../common_source/getcap.c <- ../common_source/getcap.o dependency dropped. make[2]: Circular ../common_source/strlcpy.c <- ../common_source/strlcpy.o dependency dropped. make[2]: Circular ../common_source/strlcat.c <- ../common_source/strlcat.o dependency dropped. cc -o lpr lpr.o ../common_source/startdaemon.o ../common_source/common.o ../common_source/common_vars.o ../common_source/getcap.o ../common_source/strlcpy.o ../common_source/strlcat.o cc -I/../common_source -Wall -g -O2 -D_GNU_SOURCE -D__KAME__ -I../common_source -c -o lprm.o lprm.c lprm.c:44:19: warning: ‘rcsid’ defined but not used [-Wunused-const-variable=] 44 | static const char rcsid[] = "$OpenBSD: lprm.c,v 1.17 2007/02/16 13:34:58 jmc Exp $"; lprm.c:35:19: warning: ‘copyright’ defined but not used [-Wunused-const-variable=] make[2]: Circular ../common_source/rmjob.c <- ../common_source/rmjob.o dependency dropped. make[2]: Circular ../common_source/startdaemon.c <- ../common_source/startdaemon.o dependency dropped. make[2]: Circular ../common_source/common.c <- ../common_source/common.o dependency dropped. make[2]: Circular ../common_source/common_vars.c <- ../common_source/common_vars.o dependency dropped. make[2]: Circular ../common_source/getcap.c <- ../common_source/getcap.o dependency dropped. make[2]: Circular ../common_source/strlcpy.c <- ../common_source/strlcpy.o dependency dropped. make[2]: Circular ../common_source/strlcat.c <- ../common_source/strlcat.o dependency dropped. cc -o lprm lprm.o ../common_source/rmjob.o ../common_source/startdaemon.o ../common_source/common.o ../common_source/common_vars.o ../common_source/getcap.o ../common_source/strlcpy.o ../common_source/strlcat.o cc -Wall -g -O2 -D_GNU_SOURCE -D__KAME__ -I../common_source -c -o lptest.o lptest.c lptest.c:44:19: warning: ‘rcsid’ defined but not used [-Wunused-const-variable=] 44 | static const char rcsid[] = "$OpenBSD: lptest.c,v 1.7 2003/06/02 23:36:53 millert Exp $"; lptest.c:35:19: warning: ‘copyright’ defined but not used [-Wunused-const-variable=] make[2]: Circular ../common_source/strlcpy.c <- ../common_source/strlcpy.o dependency dropped. make[2]: Circular ../common_source/strlcat.c <- ../common_source/strlcat.o dependency dropped. cc -I/../common_source -Wall -g -O2 -D_GNU_SOURCE -D__KAME__ -I../common_source -c -o pac.o pac.c pac.c:44:19: warning: ‘rcsid’ defined but not used [-Wunused-const-variable=] 44 | static const char rcsid[] = "$OpenBSD: pac.c,v 1.18 2007/09/02 15:19:39 deraadt Exp $"; pac.c:35:19: warning: ‘copyright’ defined but not used [-Wunused-const-variable=] make[2]: Circular ../common_source/common.c <- ../common_source/common.o dependency dropped. make[2]: Circular ../common_source/common_vars.c <- ../common_source/common_vars.o dependency dropped. make[2]: Circular ../common_source/getcap.c <- ../common_source/getcap.o dependency dropped. make[2]: Circular ../common_source/strlcpy.c <- ../common_source/strlcpy.o dependency dropped. make[2]: Circular ../common_source/strlcat.c <- ../common_source/strlcat.o dependency dropped. cc -o pac pac.o ../common_source/common.o ../common_source/common_vars.o ../common_source/getcap.o ../common_source/strlcpy.o ../common_source/strlcat.o cc -Wall -g -O2 -D_GNU_SOURCE -D__KAME__ -I../common_source -c -o lpf.o lpf.c lpf.c:43:19: warning: ‘rcsid’ defined but not used [-Wunused-const-variable=] 43 | static const char rcsid[] = "$OpenBSD: lpf.c,v 1.11 2004/04/14 20:52:20 millert Exp $"; lpf.c:34:19: warning: ‘copyright’ defined but not used [-Wunused-const-variable=] make[2]: Circular ../common_source/strlcpy.c <- ../common_source/strlcpy.o dependency dropped. make[2]: Circular ../common_source/strlcat.c <- ../common_source/strlcat.o dependency dropped. dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installdirs: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_install: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installman: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installdocs: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installexamples: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installlogcheck: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installinit: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installcron: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_installchangelogs: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_strip: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_compress: warning: Compatibility levels before 10 are deprecated (level 9 in use) chown: changing ownership of 'debian/lpr/usr/bin/lpr': Operation not permitted chown: changing ownership of 'debian/lpr/usr/bin/lpq': Operation not permitted chown: changing ownership of 'debian/lpr/usr/bin/lprm': Operation not permitted chown: changing ownership of 'debian/lpr/usr/sbin/lpc': Operation not permitted dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

OpenPGP_signature.asc
Description: OpenPGP digital signature