Source: netselect
Version: 0.3.ds1-30.2
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
netselect failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

+------------------------------------------------------------------------------+
| Build
                                                                       |
+------------------------------------------------------------------------------+


Unpack source
-------------

Format: 3.0 (quilt)
Source: netselect
Binary: netselect, netselect-apt
Architecture: any all
Version: 0.3.ds1-30.2
Maintainer: Javier Fernández-Sanguino Peña <j...@debian.org>
Homepage: http://github.com/apenwarr/netselect
Standards-Version: 4.5.1
Build-Depends: debhelper (>= 13), po-debconf
Package-List:
 netselect deb net optional arch=any
 netselect-apt deb net optional arch=all
Checksums-Sha1:
 4c911df972b402d401bfcfd692ff55e9957b65e9 20937
netselect_0.3.ds1.orig.tar.gz
 85083d7f47a2619658b6d3a8894ad4eeb85cba65 35632
netselect_0.3.ds1-30.2.debian.tar.xz
Checksums-Sha256:
 4e9f25042b55cc075184e9f8ff602d104ef5a804f09f69a71519e3ab00605c96 20937
netselect_0.3.ds1.orig.tar.gz
 00edc343d7fe8774e13675eb41b652d750a6bcbfa7c0919ed85e404a352c69ae 35632
netselect_0.3.ds1-30.2.debian.tar.xz
Files:
 a1eb3834389666dcba664ea95bc51776 20937 netselect_0.3.ds1.orig.tar.gz
ea23a01c130747c569e2a3bc11c609e5 35632 netselect_0.3.ds1-30.2.debian.tar.xz


gpgv: Signature made Sun Mar 17 17:43:05 2024 UTC
gpgv:                using RSA key 406220C8B8552802378CCE411F5C7A8B45564314
gpgv:                issuer "b...@debian.org"
gpgv: Can't check signature: No public key
dpkg-source: warning: cannot verify inline signature for ./
netselect_0.3.ds1-30.2.dsc: no acceptable signature found
dpkg-source: info: extracting netselect in /<<PKGBUILDDIR>>
dpkg-source: info: unpacking netselect_0.3.ds1.orig.tar.gz
dpkg-source: info: unpacking netselect_0.3.ds1-30.2.debian.tar.xz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: applying debian.patch

Check disk space
----------------

Sufficient free space for build

User Environment
----------------

APT_CONFIG=/var/lib/sbuild/apt.conf
HOME=/sbuild-nonexistent
LANG=en_US.UTF-8
LC_ALL=C.UTF-8
LOGNAME=debusine-worker
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
SHELL=/bin/sh
USER=debusine-worker

dpkg-buildpackage
-----------------

Command: dpkg-buildpackage -us -uc -b -rfakeroot
dpkg-buildpackage: info: source package netselect
dpkg-buildpackage: info: source version 0.3.ds1-30.2
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Bastian Germann <b...@debian.org>
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture arm64
 debian/rules clean
dh clean
dh: warning: Use of debian/compat is deprecated and will be removed in
debhelper (>= 14~).
   dh_auto_clean
dh_auto_clean: warning: Use of debian/compat is deprecated and will be
removed in debhelper (>= 14~).
        make -j4 clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
rm -f netselect netselect *.o *~ build-stamp core
rm -f mirrors_full
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_clean
dh_clean: warning: Use of debian/compat is deprecated and will be
removed in debhelper (>= 14~).
 debian/rules binary
dh binary
dh: warning: Use of debian/compat is deprecated and will be removed in
debhelper (>= 14~).
   dh_update_autotools_config
   dh_autoreconf
   dh_auto_configure
dh_auto_configure: warning: Use of debian/compat is deprecated and will
be removed in debhelper (>= 14~).
   dh_auto_build
dh_auto_build: warning: Use of debian/compat is deprecated and will be
removed in debhelper (>= 14~).
        make -j4 "INSTALL=install --strip-program=true"
make[1]: Entering directory '/<<PKGBUILDDIR>>'
gcc -O2 -Wall -I. -g -Wdate-time -D_FORTIFY_SOURCE=2  -c -o netselect.o
netselect.c
netselect.c: In function ‘send_icmp_probe’:
netselect.c:852:21: warning: taking address of packed member of ‘struct
<anonymous>’ may result in an unaligned pointer value [-Waddress-of-
packed-member]
  852 |     struct ip *ip = &op->ip;
      |                     ^~~~~~~
netselect.c:853:25: warning: taking address of packed member of ‘struct
<anonymous>’ may result in an unaligned pointer value [-Waddress-of-
packed-member]
  853 |     struct icmp *icmp = &op->icmp;
      |                         ^~~~~~~~~
netselect.c:860:18: warning: taking address of packed member of ‘struct
<anonymous>’ may result in an unaligned pointer value [-Waddress-of-
packed-member]
  860 |     gettimeofday(&op->tv, &tz);
      |                  ^~~~~~~
netselect.c: In function ‘main’:
netselect.c:202:5: warning: ignoring return value of ‘setuid’ declared
with attribute ‘warn_unused_result’ [-Wunused-result]
  202 |     setuid(getuid());
      |     ^~~~~~~~~~~~~~~~
netselect.c: In function ‘name_resolver’:
netselect.c:636:21: warning: ignoring return value of ‘write’ declared
with attribute ‘warn_unused_result’ [-Wunused-result]
  636 |                     write(pipes[1], &result, sizeof(result));
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
netselect.c:651:29: warning: ignoring return value of ‘write’ declared
with attribute ‘warn_unused_result’ [-Wunused-result]
  651 |                             write(pipes[1], &result,
sizeof(result));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
netselect.c:666:33: warning: ignoring return value of ‘write’ declared
with attribute ‘warn_unused_result’ [-Wunused-result]
  666 |                                 write(pipes[1], &result,
sizeof(result));
      |
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
netselect.c:674:25: warning: ignoring return value of ‘write’ declared
with attribute ‘warn_unused_result’ [-Wunused-result]
  674 |                         write(pipes[1], &result, sizeof(result));
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc -g -o netselect netselect.o make[1]: Leaving directory '/
<<PKGBUILDDIR>>'
   dh_auto_test
dh_auto_test: warning: Use of debian/compat is deprecated and will be
removed in debhelper (>= 14~).
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_installdirs
dh_installdirs: warning: Use of debian/compat is deprecated and will be
removed in debhelper (>= 14~).
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make PREFIX=debian/tmp/usr install
make[2]: Entering directory '/<<PKGBUILDDIR>>'
chown root netselect && chmod u+s netselect
chown: changing ownership of 'netselect': Operation not permitted
make[2]: *** [Makefile:27: install] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [debian/rules:15: override_dh_auto_install] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:9: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit
status 2
--------------------------------------------------------------------------------
Build finished at 2024-11-17T14:04:47Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1024510.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-
ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-
misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to