Source: phalanx
Version: 25-1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
phalanx failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
29 | { for( j=0; j!=ISI; j++ ) fread( (char*)ptr+i+j, 1, 1, stream ); } | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ book.c:30:35: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 30 | for( j=0; i+j<size; j++ ) fread( (char*)ptr+i+j, 1, 1, stream ); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
book.c: In function ‘linSB’:
book.c:99:22: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   99 |         if(!feof(f)) fgets(s,80,f);     /* skip to the first \n */
      |                      ^~~~~~~~~~~~~
book.c:103:17: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  103 |                 fgets(s,100,f);
      |                 ^~~~~~~~~~~~~~
book.c: In function ‘binSB’:
book.c:123:22: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  123 |         if(!feof(f)) fgets(s,80,f);     /* skip to the first \n */
      |                      ^~~~~~~~~~~~~
book.c:125:22: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  125 |         if(!feof(f)) fgets(s,100,f);
      |                      ^~~~~~~~~~~~~~
book.c: In function ‘bk’:
book.c:474:19: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  474 |                   fgets(t,126,Eco);
      |                   ^~~~~~~~~~~~~~~~
cc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -DGNUFUN -DPBOOK_DIR=\"/usr/share/phalanx\" -DSBOOK_DIR=\"/usr/share/phalanx\" -DLEARN_DIR=\"/var/games\" -DLEARN_FILE=\"phalanx.learn\" -c endgame.c -o .o/endgame.o cc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -DGNUFUN -DPBOOK_DIR=\"/usr/share/phalanx\" -DSBOOK_DIR=\"/usr/share/phalanx\" -DLEARN_DIR=\"/var/games\" -DLEARN_FILE=\"phalanx.learn\" -c learn.c -o .o/learn.o cc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -DGNUFUN -DPBOOK_DIR=\"/usr/share/phalanx\" -DSBOOK_DIR=\"/usr/share/phalanx\" -DLEARN_DIR=\"/var/games\" -DLEARN_FILE=\"phalanx.learn\" -c easy.c -o .o/easy.o cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -DGNUFUN -DPBOOK_DIR=\"/usr/share/phalanx\" -DSBOOK_DIR=\"/usr/share/phalanx\" -DLEARN_DIR=\"/var/games\" -DLEARN_FILE=\"phalanx.learn\" .o/phalanx.o .o/bcreate.o .o/search.o .o/io.o .o/data.o .o/evaluate.o .o/genmoves.o .o/moving.o .o/hash.o .o/static.o .o/levels.o .o/book.o .o/killers.o .o/endgame.o .o/learn.o .o/easy.o -Wl,-z,relro -Wl,-z,now -o phalanx
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test
        rm -fr -- /tmp/dh-xdg-rundir-5I4eLkuH
   create-stamp debian/debhelper-build-stamp
   dh_prep
        rm -f -- debian/phalanx.substvars
        rm -fr -- debian/.debhelper/generated/phalanx/ debian/phalanx/ 
debian/tmp/
   dh_installdirs
        install -m0755 -d debian/phalanx/var/games
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make prefix="/<<PKGBUILDDIR>>/debian/phalanx/usr" install
make[2]: Entering directory '/<<PKGBUILDDIR>>'
install -d 0755 /<<PKGBUILDDIR>>/debian/phalanx/usr/games
install -m 0755 phalanx /<<PKGBUILDDIR>>/debian/phalanx/usr/games
install -d 0755 /<<PKGBUILDDIR>>/debian/phalanx/usr/share/phalanx
install -m 0644 pbook.phalanx /<<PKGBUILDDIR>>/debian/phalanx/usr/share/phalanx install -m 0644 sbook.phalanx /<<PKGBUILDDIR>>/debian/phalanx/usr/share/phalanx install -d 0755 /<<PKGBUILDDIR>>/debian/phalanx/usr/share/games/plugins/xboard install -m 0644 phalanx.eng /<<PKGBUILDDIR>>/debian/phalanx/usr/share/games/plugins/xboard
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_install
        install -m0755 -d debian/phalanx/usr/games/
        cp --reflink=auto -a ./debian/xphalanx ./phalanx 
debian/phalanx/usr/games//
        install -m0755 -d debian/phalanx/usr/share/games/plugins/xboard/
cp --reflink=auto -a ./phalanx.eng debian/phalanx/usr/share/games/plugins/xboard//
        install -m0755 -d debian/phalanx/usr/share/phalanx/
cp --reflink=auto -a ./pbook.phalanx ./sbook.phalanx debian/phalanx/usr/share/phalanx//
   dh_installdocs
        install -m0755 -d debian/phalanx/usr/share/doc/phalanx
        install -m0755 -d debian/phalanx/usr/share/doc/phalanx
        cp --reflink=auto -a ./README debian/phalanx/usr/share/doc/phalanx
cp --reflink=auto -a ./debian/pondering debian/phalanx/usr/share/doc/phalanx
        chmod -R u\+rw,go=rX debian/phalanx/usr/share/doc
install -p -m0644 debian/copyright debian/phalanx/usr/share/doc/phalanx/copyright
   dh_installchangelogs
        install -m0755 -d debian/phalanx/usr/share/doc/phalanx
install -p -m0644 debian/.debhelper/generated/phalanx/dh_installchangelogs.dch.trimmed debian/phalanx/usr/share/doc/phalanx/changelog.Debian
        install -p -m0644 ./HISTORY 
debian/phalanx/usr/share/doc/phalanx/changelog
   dh_installman
        install -m0755 -d debian/phalanx/usr/share/man/man6/
install -p -m0644 ./debian/phalanx.6 debian/phalanx/usr/share/man/man6/phalanx.6
        install -m0755 -d debian/phalanx/usr/share/man/man6/
install -p -m0644 ./debian/xphalanx.6 debian/phalanx/usr/share/man/man6/xphalanx.6 man-recode --to-code UTF-8 --suffix .dh-new debian/phalanx/usr/share/man/man6/phalanx.6 man-recode --to-code UTF-8 --suffix .dh-new debian/phalanx/usr/share/man/man6/xphalanx.6 mv debian/phalanx/usr/share/man/man6/phalanx.6.dh-new debian/phalanx/usr/share/man/man6/phalanx.6
        chmod 0644 -- debian/phalanx/usr/share/man/man6/phalanx.6
mv debian/phalanx/usr/share/man/man6/xphalanx.6.dh-new debian/phalanx/usr/share/man/man6/xphalanx.6
        chmod 0644 -- debian/phalanx/usr/share/man/man6/xphalanx.6
   dh_installdebconf
        install -m0755 -d debian/phalanx/DEBIAN
        cp -f debian/config debian/phalanx/DEBIAN/config
        [META] Replace #TOKEN#s in "debian/phalanx/DEBIAN/config"
        chmod 0755 -- debian/phalanx/DEBIAN/config
        po2debconf  debian/templates > debian/phalanx/DEBIAN/templates
        mv debian/phalanx.substvars.new debian/phalanx.substvars
[META] Append autosnippet "postrm-debconf" to postrm [debian/phalanx.postrm.debhelper]
   dh_perl
   dh_link
   dh_strip_nondeterminism
   dh_compress
        cd debian/phalanx
chmod a-x usr/share/doc/phalanx/README usr/share/doc/phalanx/changelog usr/share/doc/phalanx/changelog.Debian usr/share/man/man6/phalanx.6 usr/share/man/man6/xphalanx.6 gzip -9nf usr/share/doc/phalanx/README usr/share/doc/phalanx/changelog usr/share/doc/phalanx/changelog.Debian usr/share/man/man6/phalanx.6 usr/share/man/man6/xphalanx.6
        cd '/<<PKGBUILDDIR>>'
   debian/rules override_dh_fixperms
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_fixperms
find debian/phalanx ! -type l -a -true -a -true -print0 2>/dev/null | xargs -0r chmod go=rX,u+rw,a-s find debian/phalanx/usr/share/doc -type f -a -true -a ! -regex 'debian/phalanx/usr/share/doc/[^/]*/examples/.*' -print0 2>/dev/null | xargs -0r chmod 0644 find debian/phalanx/usr/share/doc -type d -a -true -a -true -print0 2>/dev/null | xargs -0r chmod 0755 find debian/phalanx/usr/share/man -type f -a -true -a -true -print0 2>/dev/null | xargs -0r chmod 0644 find debian/phalanx -type f \( -name '*.so.*' -o -name '*.so' -o -name '*.la' -o -name '*.a' -o -name '*.js' -o -name '*.css' -o -name '*.scss' -o -name '*.sass' -o -name '*.jpeg' -o -name '*.jpg' -o -name '*.png' -o -name '*.gif' -o -name '*.cmxs' -o -name '*.node' \) -a -true -a -true -print0 2>/dev/null | xargs -0r chmod 0644 find debian/phalanx/usr/games -type f -a -true -a -true -print0 2>/dev/null | xargs -0r chmod a+x
chgrp games /<<PKGBUILDDIR>>/debian/phalanx/usr/games/phalanx
chgrp: changing group of '/<<PKGBUILDDIR>>/debian/phalanx/usr/games/phalanx': Operation not permitted
make[1]: *** [debian/rules:15: override_dh_fixperms] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:7: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2024-11-17T19:27:14Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1027499.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to