Bug#1089397: netmaze: Supporting rootless builds by default

Niels Thykier Sat, 07 Dec 2024 12:06:54 -0800

Source: netmaze
Version: 0.81+jpg0.82-18
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue


Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
netmaze failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

197 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"

      |   ^~~~~~~

gcc -g -O3 -fno-strict-aliasing -Dlinux -D__aarch64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -DSH_MEM -c -o allmove.o allmove.c In file included from /usr/include/aarch64-linux-gnu/bits/libc-header-start.h:33,

                 from /usr/include/stdio.h:28,
                 from allmove.c:5:

/usr/include/features.h:197:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] 197 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"

      |   ^~~~~~~

gcc -g -O3 -fno-strict-aliasing -Dlinux -D__aarch64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -DSH_MEM -c -o maze.o maze.c In file included from /usr/include/aarch64-linux-gnu/bits/libc-header-start.h:33,

                 from /usr/include/stdio.h:28,
                 from maze.c:5:

      |   ^~~~~~~

gcc -g -O3 -fno-strict-aliasing -Dlinux -D__aarch64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -DSH_MEM -c -o iocntl.o iocntl.c In file included from /usr/include/aarch64-linux-gnu/bits/libc-header-start.h:33,

                 from /usr/include/stdio.h:28,
                 from iocntl.c:1:

      |   ^~~~~~~

In file included from /usr/include/aarch64-linux-gnu/sys/types.h:25,
                 from audio.c:1:

      |   ^~~~~~~

gcc -g -O3 -fno-strict-aliasing -Dlinux -D__aarch64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -DSH_MEM -c -o texture.o texture.c In file included from /usr/include/aarch64-linux-gnu/bits/libc-header-start.h:33,

                 from /usr/include/stdlib.h:26,
                 from texture.c:6:

      |   ^~~~~~~
rm -f netmaze

gcc -o netmaze -g -O3 -fno-strict-aliasing x11cntrl.o draw_3d.o x11smiley.o x11gfx.o netmaze.o network.o allmove.o maze.o iocntl.o audio.o texture.o -lXext -lX11 -lm gcc -g -O3 -fno-strict-aliasing -Dlinux -D__aarch64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -DSH_MEM -c -o netserv.o netserv.c

In file included from /usr/include/aarch64-linux-gnu/sys/types.h:25,
                 from /usr/include/aarch64-linux-gnu/sys/param.h:25,
                 from netmaze.h:1,
                 from netserv.c:19:

      |   ^~~~~~~
In function ‘read_pipe’,
    inlined from ‘handle_input’ at netserv.c:442:11:

netserv.c:2085:14: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]

 2085 |   buf[count] = 0;
      |   ~~~~~~~~~~~^~~
netserv.c: In function ‘handle_input’:

netserv.c:432:8: note: at offset 256 into destination object ‘line’ of size 256

  432 |   char line[256],name[100];
      |        ^~~~
rm -f netserv

gcc -o netserv -g -O3 -fno-strict-aliasing netserv.o maze.o -lXext -lX11 -lm gcc -g -O3 -fno-strict-aliasing -Dlinux -D__aarch64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -DSH_MEM -c -o follower.o follower.c In file included from /usr/include/aarch64-linux-gnu/bits/libc-header-start.h:33,

                 from /usr/include/string.h:26,
                 from follower.c:6:

      |   ^~~~~~~

In file included from /usr/include/aarch64-linux-gnu/sys/types.h:25,
                 from /usr/include/aarch64-linux-gnu/sys/param.h:25,
                 from netmaze.h:1,
                 from robot.c:7:

      |   ^~~~~~~
rm -f follower

gcc -o follower -g -O3 -fno-strict-aliasing follower.o allmove.o robot.o network.o maze.o -lm gcc -g -O3 -fno-strict-aliasing -Dlinux -D__aarch64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -DSH_MEM -c -o dummy.o dummy.c In file included from /usr/include/aarch64-linux-gnu/bits/libc-header-start.h:33,

                 from /usr/include/string.h:26,
                 from dummy.c:5:

      |   ^~~~~~~
rm -f dummy

gcc -o dummy -g -O3 -fno-strict-aliasing dummy.o allmove.o robot.o network.o maze.o gcc -g -O3 -fno-strict-aliasing -Dlinux -D__aarch64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -DSH_MEM -c -o better.o better.c In file included from /usr/include/aarch64-linux-gnu/bits/libc-header-start.h:33,

                 from /usr/include/math.h:27,
                 from better.c:14:

      |   ^~~~~~~
rm -f betterbot

gcc -o betterbot -g -O3 -fno-strict-aliasing better.o allmove.o robot.o network.o maze.o -lm make[1]: Leaving directory '/<<PKGBUILDDIR>>'

touch build
rm -rf debian/tmp
install -d debian/tmp debian/tmp/DEBIAN debian/tmp/usr/games \
        debian/tmp/usr/share/doc/netmaze debian/tmp/usr/lib/menu \
        debian/tmp/usr/lib/games/netmaze
install -o root -g root -m 0755 netmaze debian/tmp/usr/games

install: cannot change ownership of 'debian/tmp/usr/games/netmaze': Operation not permitted

make: *** [debian/rules:44: binary-arch] Error 1

dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

--------------------------------------------------------------------------------
Build finished at 2024-11-17T14:00:06Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1024465.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089397: netmaze: Supporting rootless builds by default

Reply via email to