Bug#1089417: pptp-linux: Supporting rootless builds by default

Niels Thykier Sat, 07 Dec 2024 12:20:43 -0800

Source: pptp-linux
Version: 1.10.0-1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue


Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
pptp-linux failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

util.c: In function ‘_log’:

util.c:29:34: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 245 [-Wformat-truncation=]

   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
      |                                  ^~~~~~~~~~~~~~~~~~~~~
   30 |          log_string, label, func, file, line, buf);     \
      |                                               ~~~
util.c:47:5: note: in expansion of macro ‘MAKE_STRING’
   47 |     MAKE_STRING("log");
      |     ^~~~~~~~~~~
util.c:29:52: note: format string is defined here
   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
      |                                                    ^~
In file included from /usr/include/stdio.h:970,
                 from util.c:7:
In function ‘snprintf’,
    inlined from ‘_log’ at util.c:47:5:

/usr/include/aarch64-linux-gnu/bits/stdio2.h:68:10: note: ‘__builtin___snprintf_chk’ output 12 or more bytes (assuming 267) into a destination of size 256 68 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   69 |                                    __glibc_objsize (__s), __fmt,
      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   70 |                                    __va_arg_pack ());
      |                                    ~~~~~~~~~~~~~~~~~
util.c: In function ‘_warn’:

util.c:29:34: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 244 [-Wformat-truncation=]

   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
      |                                  ^~~~~~~~~~~~~~~~~~~~~
   30 |          log_string, label, func, file, line, buf);     \
      |                                               ~~~
util.c:54:5: note: in expansion of macro ‘MAKE_STRING’
   54 |     MAKE_STRING("warn");
      |     ^~~~~~~~~~~
util.c:29:52: note: format string is defined here
   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
      |                                                    ^~
In function ‘snprintf’,
    inlined from ‘_warn’ at util.c:54:5:

/usr/include/aarch64-linux-gnu/bits/stdio2.h:68:10: note: ‘__builtin___snprintf_chk’ output 13 or more bytes (assuming 268) into a destination of size 256 68 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   69 |                                    __glibc_objsize (__s), __fmt,
      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   70 |                                    __va_arg_pack ());
      |                                    ~~~~~~~~~~~~~~~~~
pptp_ctrl.c: In function ‘randci’:

pptp_ctrl.c:336:17: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

  336 |                 read(fd, &i, 2);
      |                 ^~~~~~~~~~~~~~~

util.c: In function ‘_fatal’:

util.c:29:34: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 243 [-Wformat-truncation=]

   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
      |                                  ^~~~~~~~~~~~~~~~~~~~~
   30 |          log_string, label, func, file, line, buf);     \
      |                                               ~~~
util.c:62:5: note: in expansion of macro ‘MAKE_STRING’
   62 |     MAKE_STRING("fatal");
      |     ^~~~~~~~~~~
util.c:29:52: note: format string is defined here
   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
      |                                                    ^~
In function ‘snprintf’,
    inlined from ‘_fatal’ at util.c:62:5:

/usr/include/aarch64-linux-gnu/bits/stdio2.h:68:10: note: ‘__builtin___snprintf_chk’ output 14 or more bytes (assuming 269) into a destination of size 256 68 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   69 |                                    __glibc_objsize (__s), __fmt,
      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   70 |                                    __va_arg_pack ());
      |                                    ~~~~~~~~~~~~~~~~~

gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -c -o pptp_callmgr.o pptp_callmgr.c gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -c -o routing.o routing.c gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -c -o pptp_compat.o pptp_compat.c

routing.c: In function ‘routing_init’:

routing.c:121:3: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

  121 |   fgets(buf, 255, p);
      |   ^~~~~~~~~~~~~~~~~~
pod2man --section=8 pptpsetup > pptpsetup.8

pptp_callmgr.c: In function ‘call_callback’:

pptp_callmgr.c:76:13: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

   76 |             write(lci->unix_sock, &call_id, sizeof(call_id));
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pptp_callmgr.c: In function ‘callmgr_main’:

pptp_callmgr.c:225:13: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

  225 |             read(s, &lci->pid[0], sizeof(lci->pid[0]));
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

pptp_callmgr.c:226:13: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

  226 |             read(s, &lci->pid[1], sizeof(lci->pid[1]));
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

gcc -o pptp pptp.o pptp_gre.o ppp_fcs.o pptp_ctrl.o dirutil.o vector.o util.o version.o test-redirections.o pptp_quirks.o orckit_quirks.o pqueue.o pptp_callmgr.o routing.o pptp_compat.o -Wl,-z,relro -Wl,-z,now -lutil

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test
        make -j8 test
make[1]: Entering directory '/<<PKGBUILDDIR>>'

gcc -o vector_test vector_test.o vector.o
./vector_test
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_auto_install --destdir=debian/pptp-linux/

make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/pptp-linux AM_UPDATE_INFO_DIR=no

make[1]: Entering directory '/<<PKGBUILDDIR>>'
mkdir -p /<<PKGBUILDDIR>>/debian/pptp-linux/usr/sbin
install -o root -m 555 pptp /<<PKGBUILDDIR>>/debian/pptp-linux/usr/sbin

install: cannot change ownership of '/<<PKGBUILDDIR>>/debian/pptp-linux/usr/sbin/pptp': Operation not permitted

make[1]: *** [Makefile:75: install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'

dh_auto_install: error: make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/pptp-linux AM_UPDATE_INFO_DIR=no returned exit code 2

make: *** [debian/rules:6: binary] Error 25

dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

--------------------------------------------------------------------------------
Build finished at 2024-11-17T21:29:45Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1029897.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089417: pptp-linux: Supporting rootless builds by default

Reply via email to