Source: searchandrescue
Version: 1.5.0+dfsg-0.2
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
searchandrescue failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
 1368 |                 (unsigned int)data
      |                 ^
v3dtex.c:1373:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 1373 |                 (unsigned int)data
      |                 ^
v3dtex.c:1477:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 1477 |                     (unsigned int)cur_data_ptr
      |                     ^
v3dtex.c:1620:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 1620 |             t->data[i] = (void *)gl_texture_id;
      |                          ^
v3dtex.c: In function ‘V3DTexturePriority’:
v3dtex.c:1675:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 1675 |             tex_id_list[0] = (GLuint)t->data[i];
      |                              ^
v3dtex.c: In function ‘V3DTextureDestroy’:
v3dtex.c:1704:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 1704 |             gl_texture_id = (GLuint)(t->data[i]);
      |                             ^
Compiling module weather.o
Compiling module weatherio.o
Compiling module x3d.o
x3d.c: In function ‘X3DOpenDataGLOutput’:
x3d.c:267:25: warning: variable ‘texture_on’ set but not used [-Wunused-but-set-variable]
  267 |         GLboolean       texture_on = GL_FALSE;
      |                         ^~~~~~~~~~
Compiling module disk.o
<command-line>: warning: "__cplusplus" redefined
<built-in>: note: this is the location of the previous definition
disk.cpp: In function ‘char* ChangeDirRel(const char*, const char*)’:
disk.cpp:850:20: warning: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
  850 |             strncpy(rtn_str, npath, len);
      |             ~~~~~~~^~~~~~~~~~~~~~~~~~~~~
disk.cpp:81:53: note: length computed here
   81 | #define STRLEN(s)       (((s) != NULL) ? (int)strlen(s) : 0)
      |                                               ~~~~~~^~~
disk.cpp:845:19: note: in expansion of macro ‘STRLEN’
  845 |             len = STRLEN(npath);
      |                   ^~~~~~
disk.cpp:836:20: warning: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
  836 |             strncpy(rtn_str, cpath, len);
      |             ~~~~~~~^~~~~~~~~~~~~~~~~~~~~
disk.cpp:81:53: note: length computed here
   81 | #define STRLEN(s)       (((s) != NULL) ? (int)strlen(s) : 0)
      |                                               ~~~~~~^~~
disk.cpp:831:19: note: in expansion of macro ‘STRLEN’
  831 |             len = STRLEN(cpath);
      |                   ^~~~~~
disk.cpp:782:20: warning: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
  782 |             strncpy(rtn_str, cpath, len);
      |             ~~~~~~~^~~~~~~~~~~~~~~~~~~~~
disk.cpp:81:53: note: length computed here
   81 | #define STRLEN(s)       (((s) != NULL) ? (int)strlen(s) : 0)
      |                                               ~~~~~~^~~
disk.cpp:777:19: note: in expansion of macro ‘STRLEN’
  777 |             len = STRLEN(cpath);
      |                   ^~~~~~
Compiling module fio.o
<command-line>: warning: "__cplusplus" redefined
<built-in>: note: this is the location of the previous definition
Compiling module gww.o
<command-line>: warning: "__cplusplus" redefined
<built-in>: note: this is the location of the previous definition
Compiling module string.o
<command-line>: warning: "__cplusplus" redefined
<built-in>: note: this is the location of the previous definition
string.cpp: In function ‘void straddflag(char*, const char*, char, int)’:
string.cpp:698:20: warning: variable ‘flag_len’ set but not used [-Wunused-but-set-variable]
  698 |         int s_len, flag_len;
      |                    ^~~~~~~~
Compiling module strexp.o
<command-line>: warning: "__cplusplus" redefined
<built-in>: note: this is the location of the previous definition
strexp.cpp: In function ‘char** strchrexp(const char*, char, int*)’:
strexp.cpp:129:24: warning: ‘char* strncpy(char*, const char*, size_t)’ destination unchanged after copying no bytes [-Wstringop-truncation]
  129 |                 strncpy(ret[num - 1], head, len);
      |                 ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
Compiling module tga.o
<command-line>: warning: "__cplusplus" redefined
<built-in>: note: this is the location of the previous definition
tga.cpp: In function ‘int TgaReadHeaderFromData(const u_int8_t*, tga_data_struct*)’: tga.cpp:478:56: warning: variable ‘data_colormap’ set but not used [-Wunused-but-set-variable] 478 | const u_int8_t *data_header, *data_id_field, *data_colormap, | ^~~~~~~~~~~~~ tga.cpp: In function ‘int TgaReadFromFile(const char*, tga_data_struct*, unsigned int)’: tga.cpp:714:13: warning: variable ‘pix_total’ set but not used [-Wunused-but-set-variable]
  714 |         int pix_total, colum_count, row_count;
      |             ^~~~~~~~~
tga.cpp: In function ‘int TgaReadFromData(const u_int8_t*, tga_data_struct*, unsigned int)’: tga.cpp:1314:13: warning: variable ‘pix_total’ set but not used [-Wunused-but-set-variable]
 1314 |         int pix_total, colum_count, row_count;
      |             ^~~~~~~~~
tga.cpp: In function ‘int TgaReadPartialFromFile(tga_data_struct*, unsigned int, unsigned int)’: tga.cpp:2013:13: warning: variable ‘pix_total’ set but not used [-Wunused-but-set-variable]
 2013 |         int pix_total;
      |             ^~~~~~~~~
Compiling module tgadither.o
<command-line>: warning: "__cplusplus" redefined
<built-in>: note: this is the location of the previous definition
Linking modules...   1.1M SearchAndRescue
Build done.
To install, type "su" (to gain root privileges) and then type "make install".
make[2]: Leaving directory '/<<PKGBUILDDIR>>/sar'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
touch build-stamp
dh_testdir
dh_testroot
dh_prep
dh_installdirs
dh_installdirs: warning: Compatibility levels before 10 are deprecated (level 7 in use)
# Add here commands to install the package into debian/tmp.
/usr/bin/make install DESTDIR=`pwd`/debian/searchandrescue
make[1]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: Entering directory '/<<PKGBUILDDIR>>/sar'
Installing "SearchAndRescue"...
Installing SearchAndRescue -> /<<PKGBUILDDIR>>/debian/searchandrescue/usr//games Installing SearchAndRescue.6.bz2 -> /<<PKGBUILDDIR>>/debian/searchandrescue/usr//share/man/man6 Installing SearchAndRescue.xpm -> /<<PKGBUILDDIR>>/debian/searchandrescue/usr//share/pixmaps/ Installing SearchAndRescue2.xpm -> /<<PKGBUILDDIR>>/debian/searchandrescue/usr//share/pixmaps/ Installing SearchAndRescue3.xpm -> /<<PKGBUILDDIR>>/debian/searchandrescue/usr//share/pixmaps/ Installing SearchAndRescue4.xpm -> /<<PKGBUILDDIR>>/debian/searchandrescue/usr//share/pixmaps/ Installing SearchAndRescue5.xpm -> /<<PKGBUILDDIR>>/debian/searchandrescue/usr//share/pixmaps/
Install done.
-------------------------------------------------------------------------
Program SearchAndRescue installed in:
         /<<PKGBUILDDIR>>/debian/searchandrescue/usr//games
 Manual SearchAndRescue.6.bz2 installed in:
         /<<PKGBUILDDIR>>/debian/searchandrescue/usr//share/man/man6
 Icons installed in:
         /<<PKGBUILDDIR>>/debian/searchandrescue/usr//share/pixmaps/
 -------------------------------------------------------------------------
 Make sure that you have the latest data files for SearchAndRescue
installed in /<<PKGBUILDDIR>>/debian/searchandrescue/usr//share/games/SearchAndRescue. You can obtain the
data files from the same location you obtained SearchAndRescue.
 To run this game, type "SearchAndRescue &"
 If it runs slow, then disable some graphics options in
options->graphics.
 See "man SearchAndRescue" for command line options.
 make[2]: Leaving directory '/<<PKGBUILDDIR>>/sar'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
# Create directory .../debian/searchandrescue-common.
install -d -g root -m 755 -o root `pwd`/debian/searchandrescue-common/usr/share install: cannot change owner and permissions of ‘/<<PKGBUILDDIR>>/debian/searchandrescue-common/usr/share’: Operation not permitted
make: *** [debian/rules:53: install] Error 1
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2024-11-18T14:29:45Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1044215.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to