Bug#1089438: snake4: Supporting rootless builds by default

[Niels Thykier]

Source: snake4
Version: 1.0.14-1.1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
snake4 failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

win.c: In function ‘callbackStart’:

  155 |     winChooseLevel((int) clientData);
      |                    ^
win.c: In function ‘winInit’:

  224 |                       (XtPointer) (q + MIN_LEVEL));
      |                       ^

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test -O--parallel

   dh_testroot -O--parallel
   dh_prep -O--parallel
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_install -- 'INSTALL=install --strip-program=true'

make[2]: Entering directory '/<<PKGBUILDDIR>>'

make[2]: *** [Makefile:95: install] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'

make[1]: *** [debian/rules:9: override_dh_auto_install] Error 255
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:6: binary] Error 2

--------------------------------------------------------------------------------
Build finished at 2024-11-18T15:17:14Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1045158.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -o headbanger.o -c -Wall -s -O2 -I/local/include -I/usr/X11R6/include -I/local/include/X11 -DVERSION=\"1.0.14\" -DSCOREFILE=\"/var/games/snake4.score\" -DXK_MISCELLANY -DXK_LATIN1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard headbanger.c gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -o mushroom.o -c -Wall -s -O2 -I/local/include -I/usr/X11R6/include -I/local/include/X11 -DVERSION=\"1.0.14\" -DSCOREFILE=\"/var/games/snake4.score\" -DXK_MISCELLANY -DXK_LATIN1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard mushroom.c gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -o score.o -c -Wall -s -O2 -I/local/include -I/usr/X11R6/include -I/local/include/X11 -DVERSION=\"1.0.14\" -DSCOREFILE=\"/var/games/snake4.score\" -DXK_MISCELLANY -DXK_LATIN1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard score.c gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -o scull.o -c -Wall -s -O2 -I/local/include -I/usr/X11R6/include -I/local/include/X11 -DVERSION=\"1.0.14\" -DSCOREFILE=\"/var/games/snake4.score\" -DXK_MISCELLANY -DXK_LATIN1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard scull.c gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -o slimpill.o -c -Wall -s -O2 -I/local/include -I/usr/X11R6/include -I/local/include/X11 -DVERSION=\"1.0.14\" -DSCOREFILE=\"/var/games/snake4.score\" -DXK_MISCELLANY -DXK_LATIN1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard slimpill.c gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -o snake.o -c -Wall -s -O2 -I/local/include -I/usr/X11R6/include -I/local/include/X11 -DVERSION=\"1.0.14\" -DSCOREFILE=\"/var/games/snake4.score\" -DXK_MISCELLANY -DXK_LATIN1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard snake.c gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -o suid.o -c -Wall -s -O2 -I/local/include -I/usr/X11R6/include -I/local/include/X11 -DVERSION=\"1.0.14\" -DSCOREFILE=\"/var/games/snake4.score\" -DXK_MISCELLANY -DXK_LATIN1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard suid.c gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -o win.o -c -Wall -s -O2 -I/local/include -I/usr/X11R6/include -I/local/include/X11 -DVERSION=\"1.0.14\" -DSCOREFILE=\"/var/games/snake4.score\" -DXK_MISCELLANY -DXK_LATIN1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard win.c win.c:155:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] win.c:224:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] gcc -Wall -s -O2 -I/local/include -I/usr/X11R6/include -I/local/include/X11 -DVERSION=\"1.0.14\" -DSCOREFILE=\"/var/games/snake4.score\" -DXK_MISCELLANY -DXK_LATIN1 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -o snake4 board.o fruit.o game.o gameobject.o headbanger.o mushroom.o score.o scull.o slimpill.o snake.o snake4.o suid.o win.o -s -L/local/lib -L/usr/X11R6/lib -L/local/lib/X11 -Wl,-z,relro -lshhopt -lshhmsg -lXaw -lXt -lXpm -lX11 -Wl,-z,relro dh_auto_test: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_auto_install: warning: Compatibility levels before 10 are deprecated (level 9 in use) make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/snake4 AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true" install --strip-program=true -d -m 755 /<<PKGBUILDDIR>>/debian/snake4/usr/games /<<PKGBUILDDIR>>/debian/snake4/var/games /<<PKGBUILDDIR>>/debian/snake4/usr/share/man/man6 install: WARNING: ignoring --strip-program option as -s option was not specified install --strip-program=true -s -m 4755 -o games -g games snake4 /<<PKGBUILDDIR>>/debian/snake4/usr/games install: cannot change ownership of '/<<PKGBUILDDIR>>/debian/snake4/usr/games/snake4': Operation not permitted dh_auto_install: error: make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/snake4 AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true" returned exit code 2 dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

OpenPGP_signature.asc
Description: OpenPGP digital signature