Bug#1089440: sreview: Supporting rootless builds by default

[Niels Thykier]

Source: sreview
Version: 0.10.0-1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
sreview failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
ok 37 # skip Need a database to play with
ok 38 # skip Need a database to play with
ok 39 # skip Need a database to play with
ok 40 # skip Need a database to play with
ok 41 # skip Need a database to play with
ok 42 # skip Need a database to play with
ok 43 # skip Need a database to play with
ok 44 # skip Need a database to play with
ok 45 # skip Need a database to play with
ok 46 # skip Need a database to play with
ok 47 # skip Need a database to play with
ok 48 # skip Need a database to play with
ok 49 # skip Need a database to play with
ok 50 # skip Need a database to play with
ok 51 # skip Need a database to play with
ok

t/110-api.t .............. ok 1 # skip Need a database to play with
1..1
ok

1..1
ok
t/130-schedule.t ......... ok 1 - use SReview::Schedule::Yaml;
ok 2 - we parsed exactly one event
ok 3 - we parsed 3 talks
ok 4 - the test talk was parsed correctly
1..4
ok
All tests successful.

Result: PASS
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_installdirs
   dh_auto_install

make[1]: Entering directory '/<<PKGBUILDDIR>>'
Manifying 10 pod documents
Manifying 10 pod documents
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview.pm
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Talk.pm
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Config.pm
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Job.pm
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web.pm
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Access.pm
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Db.pm
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/API.pm
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/CodecMap.pm
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Template.pm

Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Talk/State.pm

Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1/sreview-cut.1p
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1/sreview-user.1p

Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1/sreview-config.1p

Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1/sreview-detect.1p
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1/sreview-skip.1p
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1/sreview-import.1p

Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/SReview.3pm

Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/SReview::Talk.3pm
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-dispatch
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-transcode
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-user
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-skip
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-import
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-notranscode
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-copy
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-titles
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-config
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-reply
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-inject-job
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-notify
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-autoreview
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-detect
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-web
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-upload
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-inject
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-cut
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/sreview-previews
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
chmod +x debian/sreview-master.install debian/sreview-master.dbc
dh_install

make[1]: *** [debian/rules:8: override_dh_install] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:4: binary] Error 2

--------------------------------------------------------------------------------
Build finished at 2024-11-18T15:51:14Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1046126.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

Warning: could not find configuration file /etc/sreview/config.pm, falling back to defaults at /<<PKGBUILDDIR>>/blib/lib/SReview/Config/Common.pm line 63. t/120-types.t ............ ok 1 # skip Can't test database work unless the SREVIEWTEST_DB environment variable points to a database which we may clobber and recreate Files=11, Tests=119, 6 wallclock secs ( 0.07 usr 0.02 sys + 4.98 cusr 0.79 csys = 5.86 CPU) make -j4 install DESTDIR=/<<PKGBUILDDIR>>/debian/tmp AM_UPDATE_INFO_DIR=no PREFIX=/usr Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Config/Common.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Files/Factory.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Files/Collection/HTTP.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Files/Collection/S3.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Files/Collection/HTTP/nginx/JSON.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Talk.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Room.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Config.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/User.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Finalreview.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Speaker.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Inject.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Schedule.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Review.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Track.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Volunteer.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/CreditPreviews.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Admin.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Event.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/API/Helpers.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Model/DbElement.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Model/Event.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Template/Synfig.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Template/SVG.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Talk/Progress.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Schedule/Wafer.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Schedule/Ics.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Schedule/Multi.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Schedule/Penta.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Schedule/Yaml.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Schedule/WithShadow.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Schedule/Base.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/perl5/SReview/Schedule/Filtered.pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1/sreview-dispatch.1p Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1/sreview-previews.1p Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1/sreview-notranscode.1p Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man1/sreview-transcode.1p Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/SReview::Template.3pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/SReview::Schedule::Multi.3pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/SReview::Template::SVG.3pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/SReview::Schedule::Penta.3pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/SReview::Schedule::Wafer.3pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/SReview::Schedule::Ics.3pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/SReview::Config.3pm Installing /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/SReview::Template::Synfig.3pm cp: cannot create regular file 'debian/sreview-common//usr/share/man/man3/SReview::Config.3pm': Permission denied dh_install: error: cp --reflink=auto -a debian/tmp/usr/share/man/man3/SReview::Config.3pm debian/sreview-common//usr/share/man/man3/ returned exit code 1 dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

OpenPGP_signature.asc
Description: OpenPGP digital signature