Sean Whitton writes ("Re: Bug#1108378: git-debpush: should warn for superfluous
quilt mode option on command line"):
> I think that we might want to do more than just print a warning to
> stderr, because that might not help users enough to learn how
> git-debpush works or to change their habits.
Yes. I don't know if that's enough.
> 1. say that the quilt mode option was superfluous, then print
> [acknowledge] (or similar), and require the user to press return
> before continuing
This is quite similar to:
> 2. make it work just like a failed check. The user has to type y and
> then return to continue. Sounds a bit strange in the abstract but
> might be the most useful in practice.
I think this is my preference.
I think it would be better not to introduce new ways to grumble.
Reasonable options are:
a. Refuse
b. Failed check (prompt)
c. Grumble on stderr but do it anyway
d. Silently do it anyway
Currently we don't have any (b). I'm fine if we don't add them now,
but of course programs we call (eg git) might well do (b) so we can't
avoid them entirely.
> 3. just exit, requiring the user to run the command again without the
> superfluous quilt option.
Urgh, I don't like this, UX.
> For all three, --batch would switch to just a printed warning.
I think --batch turns failed checks into errors? That seems right
here. If you're writing script and know you're passing a
possibly-superfluous quilt mode, you're writing a script which
unconditionally overrides git-debpush's determination, so you ought to
pass a specific --force-failed-check option (I forget how those are
spelled...)
Ian.
--
Ian Jackson <[email protected]> These opinions are my own.
Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.
